public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Liu Hao <lh_mouse@126.com>
To: JonY <10walls@gmail.com>, gcc-help@gcc.gnu.org
Subject: Re: mingw-w64 and __attribute__((format(printf))) issue
Date: Sun, 10 May 2020 17:03:44 +0800	[thread overview]
Message-ID: <23b06c2e-4724-d70c-1b2a-ac7e2d94a5b4@126.com> (raw)
In-Reply-To: <50dad4c6-10cd-ed24-e563-5adc6ad50afc@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]

在 2020/5/10 12:27, JonY via Gcc-help 写道:
> 
> I think option #3 is the simplest approach in the short term, though I
> prefer option #2.
> 

This patch has been accepted by MSYS2 [1], tested for bootstrapping on
both i686 and x86_64.

So here comes a 4th option: Disable `-Werror` if `--disable-werror` is
specified to the top-level configure.

EGREP'ing for `(format|__format__)\s*\(\s*(__printf__|printf)` in GCC
source reveals ~30 matches (excluding testsuites). Probably they should
all be fixed similarly, or we ignore such warnings for simplicity.
libgomp doesn't build despite `--disable-werror` at top level, which
seems a bug in this case.


[1]
https://github.com/msys2/MINGW-packages/blob/9501ee2afc8d01dc7d85383e4b22e91c30d93ca7/mingw-w64-gcc/0020-libgomp-Don-t-hard-code-MS-printf-attributes.patch


-- 
Best regards,
LH_Mouse


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-10  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  5:36 Liu Hao
2020-05-06 10:48 ` [Mingw-w64-public] " Martin Storsjö
2020-05-06 12:45   ` Liu Hao
2020-05-07  4:09   ` Liu Hao
2020-05-10  4:27 ` JonY
2020-05-10  9:03   ` Liu Hao [this message]
2020-05-12 11:14     ` JonY
2020-05-12 12:02       ` Jakub Jelinek
2020-05-12 13:15         ` Liu Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23b06c2e-4724-d70c-1b2a-ac7e2d94a5b4@126.com \
    --to=lh_mouse@126.com \
    --cc=10walls@gmail.com \
    --cc=gcc-help@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).