RE: Error on Member Initialization

RE: Error on Member Initialization

[lrtaylor]

Sorry, I just went back and look at his original code.  I see what he was doing wrong.  However, I'm still curious about my question...

Thanks,
Lyle Taylor
IS Applications

-----Original Message-----
From: lrtaylor 
Sent: Monday, September 15, 2003 11:21 AM
To: eljay@adobe.com; anw@csunv.com; gcc-help@gcc.gnu.org
Subject: RE: Error on Member Initialization

Eljay,

While that's the _preferred_ way to initialize member variables in C++, that's not always possible; sometimes you need to do more complex things to initialize your class (e.g., if you need to initialize variables differently based on certain conditions, retrieve information from a database, etc.).  Is there any _real_ difference between these two ways of initializing?

radApp::radApp()
: m_MyServer(&Log)
{}


radApp ::radApp()
{
  m_MyServer = &Log ;
}

Thanks,
Lyle Taylor
IS Applications

-----Original Message-----
From: Eljay Love-Jensen [mailto:eljay@adobe.com]
Sent: Saturday, September 13, 2003 8:28 AM
To: Allen Williams; gcc-help@gcc.gnu.org
Subject: Re: Error on Member Initialization

Hi Allen,

That's not how you initialize a member variable in C++.  (Although it's very close to how you do it in Java.)

You need to put the initialization in your radApp's constructor's initialization list.

e.g.:
radApp::radApp()
: m_MyServer(&Log)
{ }

HTH,
--Eljay

Re: Error on Member Initialization

[John Love-Jensen]

Hi Lyle,

>Is there any _real_ difference between these two ways of initializing?

Yes.  The real difference is that the initializer list occurs whether or not
it is explicitly specified.  Putting the initialization code in the
constructor's body MAY incur a performance penalty.  That's a MAY, not a FOR
SURE ... the only way to know for certain is by profiling the optimized
release executable.

In some situations, it is necessary to put more complex resource acquisition
code in the constructor's body.

But, generally speaking, initialization lists are preferable over
initialization via the constructor's body.

The sample code you presented is amenable to the preferred initialization
list solution.

HTH,
--Eljay

RE: Error on Member Initialization

[lrtaylor]

Eljay,

While that's the _preferred_ way to initialize member variables in C++, that's not always possible; sometimes you need to do more complex things to initialize your class (e.g., if you need to initialize variables differently based on certain conditions, retrieve information from a database, etc.).  Is there any _real_ difference between these two ways of initializing?

radApp::radApp()
: m_MyServer(&Log)
{}


radApp ::radApp()
{
  m_MyServer = &Log ;
}

Thanks,
Lyle Taylor
IS Applications

-----Original Message-----
From: Eljay Love-Jensen [mailto:eljay@adobe.com]
Sent: Saturday, September 13, 2003 8:28 AM
To: Allen Williams; gcc-help@gcc.gnu.org
Subject: Re: Error on Member Initialization

Hi Allen,

That's not how you initialize a member variable in C++.  (Although it's very close to how you do it in Java.)

You need to put the initialization in your radApp's constructor's initialization list.

e.g.:
radApp::radApp()
: m_MyServer(&Log)
{ }

HTH,
--Eljay

Re: Error on Member Initialization

[Eljay Love-Jensen]

Hi Allen,

That's not how you initialize a member variable in C++.  (Although it's very close to how you do it in Java.)

You need to put the initialization in your radApp's constructor's initialization list.

e.g.:
radApp::radApp()
: m_MyServer(&Log)
{ }

HTH,
--Eljay

Error on Member Initialization

[Allen Williams]

Hello,

I have the following declared:

class RADCOMMGT_API CradComMgt
    {
public:
    CradComMgt(CLog* Log=NULL);
    ~CradComMgt();

	--- snip ---
	};
/***************************************/

In another file I declare this:

extern CLog Log;                   // <- Note declaration of CLog object

class radApp : public lnDaemon
    {
  public:
    virtual void DaemonInit();

  protected:
    CradComMgt m_MyServer(&Log);	// <- Note initialization
    };
/******************************************/

I get this from the compiler:

g++ -o radApp -D_LINUX -L../Libraries -I../Headers
radApp.cpp -lApp -lLog -lSock -lNetDataSvc -lradComMgt -lradCore
In file included from radApp.cpp:16:
radApp.h:24: error: invalid data member initialization
radApp.h:24: error: (use `=' to initialize static data members)
make: *** [radApp] Error 1

Compilation exited abnormally with code 2 at Fri Sep 12 20:04:53

I have Stroustrup's C++ reference manual and Ellis and Stroustrup's C++
Annotated reference, both of which say this should be a valid form to call
the CradComMgt::CradComMgt(CLog *) constructor.  What am I doing wrong here?

Thanks in Advance,
anw