public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Development discussions related to Fedora <fedora-devel-list@redhat.com>
Cc: gcc-help@gcc.gnu.org, cmake@cmake.org
Subject: Re: compiler bug turning up in cmake package?
Date: Tue, 26 Aug 2008 15:52:00 -0000	[thread overview]
Message-ID: <48B416AA.7060407@redhat.com> (raw)
In-Reply-To: <g900oh$5fp$1@ger.gmane.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Woehlke wrote:
> The relevant code is pretty boring:
> 
> 785     bool cmELF::Valid() const
> 786     {
> 787       return this->Internal && this->Internal->GetFileType() !=
> FileTypeInvalid;
> 788     }

It's most certainly not that simple.  I haven't looked at the sources.
But the asm code does not really correspond to the code above.  The
function above is most certainly inlined.  The problem might very well
(and most likely is) in the use of this function.  Look at the

  cmELF::GetRPath()

function and where it directly or indirectly uses the Valid function.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAki0FqoACgkQ2ijCOnn/RHSU1gCfTrXyNODqmhe8HVq0/TqUimNP
qp8AoLLh96ff+ujzn7Foq7nULxhvivtX
=br4V
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2008-08-26 14:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <g900oh$5fp$1@ger.gmane.org>
2008-08-26 10:23 ` Andrew Haley
2008-08-26 15:52 ` Ulrich Drepper [this message]
2008-08-26 16:36   ` John Fine
2008-08-26 18:12     ` Matthew Woehlke
2008-08-27 11:21       ` John Fine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B416AA.7060407@redhat.com \
    --to=drepper@redhat.com \
    --cc=cmake@cmake.org \
    --cc=fedora-devel-list@redhat.com \
    --cc=gcc-help@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).