RE: How to suppress warning?

RE: How to suppress warning?

[Lev Assinovsky]

No, I work without eol (at the end of files) for years.
Just the warnings bother all of us.

----
Lev Assinovsky
Aelita Software Corporation
O&S InTrust Framework Division, Team Leader
ICQ# 165072909


> -----Original Message-----
> From: Eljay Love-Jensen [mailto:eljay@adobe.com]
> Sent: Thursday, October 23, 2003 7:21 PM
> To: Lev Assinovsky; Gcc-Help (E-mail)
> Subject: RE: How to suppress warning?
> 
> 
> Hi Lev,
> 
> Why I'm not surprised that the Windows' source files are 
> malformed.  :-)
> 
> If I'm not mistaken, the newline-at-eof is required.
> 
> Especially important for the preprocessor, such as a #endif 
> at the end of the file (since the preprocessor is less 
> forgiving), or when someone has a //-comment as the last line 
> in the file.
> 
> --Eljay
> 
> 
> 

RE: How to suppress warning?

[Eljay Love-Jensen]

Hi Lev,

If you cannot make the source code comply with the language (due to the source code being out of your control, or whatnot), you can use perl to strip out the bothersome warnings from the compiler's output.

Other tools may provide similiar facility (awk, sed, python, ...).

--Eljay

RE: How to suppress warning?

[Rupert Wood]

Eljay / Lev wrote: 

> > Sorry, but we have tons of files in SourceSafe. To do what you
> > suggest I have to stop our company for few hours, which is
> > impossible.

Then work early, work late or work a weekend :-) But I don't think it's
worth fixing: they'd slowly rot away since Windows editors don't care about
EOFs at the end of the file.

If you can convince everyone to working with 'view whitespace', though, ...
:-)

> >So there is no option like "-Wno-noendofline" ?
> Not to my knowledge.

I don't think there's a unix sourcesafe client, is there? (I guess
SourceOffSite may have one, I've never seen it.) That means you have to
check out on Windows and then copy over to unix? When I used to work with
unix and sourcesafe I wrote a few scripts to include line ending conversion
and the newline at end of file conversion at the same time as the copy. If
you edit on unix and copy back, you get the newline-at-end-of-file and any
stray LFs in sourcesafe fixed up for you; yeah, it's an unnecssary diff but
it's not a great deal as these things go.

As Eljay suggests you can strip the warning with unix tools. You could do
this on the compile line (I'm not sure I have the magic shell knowledge,
though; someething like:

    gcc foo.c 2|grep -v "no newline"

? I've never piped stderr before) or edit that into the compile rules in
your makefile  - but this means you can't use -Werror and maybe -pedantic
too. But if you're just inspecting a build log afterwards it's quite easy,
e.g.

    gmake &> build.log
    grep -v "no newline" <build.log >build2.log

Or, if you're comfortable building your own GCC it'd be easy enough to stop
the warning there. Look in gcc/cpplex.c. There's no flag test where the
warning's generated so you're right, there's no flag already to suppress
this. You could, of course, add one and submit a patch - shouldn't be too
hard :-)

Good luck,
Rup.

RE: How to suppress warning?

[Rupert Wood]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Lyle Taylor wrote: 

> Why is it that the preprocessor and compiler can't just be smart
> enough to handle it?

I think they do, they just warn anyway.

My quick test attached; looks fine on 2.95-3.4.

Rup.

[-- Attachment #2: teapot.c --]
[-- Type: text/plain, Size: 223 bytes --]

#include <stdio.h>

int main(void)
{
printf("I'm a little teapot\n");
#include "teapot.h"
printf("short and stout\n");
printf("here's my handle\n");
#include "teapot2.h"
printf("here's my spout\n");
return 0;
}

[-- Attachment #3: teapot.h --]
[-- Type: text/plain, Size: 47 bytes --]

//empty header, no newline at end of file

//

[-- Attachment #4: teapot2.h --]
[-- Type: text/plain, Size: 80 bytes --]

#ifndef _H_TEAPOT2
#define _H_TEAPOT2

// no newline at end of file

#endif

RE: How to suppress warning?

[Eljay Love-Jensen]

Hi Lev,

>Sorry, but we have tons of files in SourceSafe. To do what you suggest I have to stop our company for few hours, which is impossible.

I do not understand why post-processing the output from GCC to strip the warning that you want to ignore should stop your company.

Regardless of how many non-compliant source files you have in SourceSafe.

>So there is no option like "-Wno-noendofline" ?

Not to my knowledge.

--Eljay

RE: How to suppress warning?

[Lev Assinovsky]

Sorry, but we have tons of files in SourceSafe. To do what you suggest
I have to stop our company for few hours, which is impossible.
So there is no option like "-Wno-noendofline" ?

----
Lev Assinovsky
Aelita Software Corporation
O&S InTrust Framework Division, Team Leader
ICQ# 165072909


> -----Original Message-----
> From: Eljay Love-Jensen [mailto:eljay@adobe.com]
> Sent: Thursday, October 23, 2003 7:59 PM
> To: Lev Assinovsky; Gcc-Help (E-mail)
> Subject: RE: How to suppress warning?
> 
> 
> Hi Lev,
> 
> If you cannot make the source code comply with the language 
> (due to the source code being out of your control, or 
> whatnot), you can use perl to strip out the bothersome 
> warnings from the compiler's output.
> 
> Other tools may provide similiar facility (awk, sed, python, ...).
> 
> --Eljay
> 
> 
> 

RE: How to suppress warning?

[lrtaylor]

Why is it that the preprocessor and compiler can't just be smart enough
to handle it?  I might have expected something like this ten years ago,
but it surprises me that it's not smarter now.  Now, I'm sure it has to
do with complications in the parser, but still...

Lyle

-----Original Message-----
From: Eljay Love-Jensen [mailto:eljay@adobe.com] 
Sent: Thursday, October 23, 2003 9:21 AM
To: Lev Assinovsky; Gcc-Help (E-mail)
Subject: RE: How to suppress warning?

Hi Lev,

Why I'm not surprised that the Windows' source files are malformed.  :-)

If I'm not mistaken, the newline-at-eof is required.

Especially important for the preprocessor, such as a #endif at the end
of the file (since the preprocessor is less forgiving), or when someone
has a //-comment as the last line in the file.

--Eljay

RE: How to suppress warning?

[Eljay Love-Jensen]

Hi Lev,

Why I'm not surprised that the Windows' source files are malformed.  :-)

If I'm not mistaken, the newline-at-eof is required.

Especially important for the preprocessor, such as a #endif at the end of the file (since the preprocessor is less forgiving), or when someone has a //-comment as the last line in the file.

--Eljay

RE: How to suppress warning?

[Lev Assinovsky]

Sorry, but I am unable to modify the files.
They are coming from Windows.

----
Lev Assinovsky
Aelita Software Corporation
O&S InTrust Framework Division, Team Leader
ICQ# 165072909


> -----Original Message-----
> From: Eljay Love-Jensen [mailto:eljay@adobe.com]
> Sent: Thursday, October 23, 2003 5:41 PM
> To: Lev Assinovsky; Gcc-Help (E-mail)
> Subject: Re: How to suppress warning?
> 
> 
> Hi Lev,
> 
> >Does anybody knows how to suppress warning: "no newline at 
> end of file"
> 
> Put a newlineat the end of file.
> 
> (It's especially egregious not to have a newline at eof when 
> the last line is a preprocessor statement.)
> 
> HTH,
> --Eljay
> 
> 
> 

Re: How to suppress warning?

[Eljay Love-Jensen]

Hi Lev,

>Does anybody knows how to suppress warning: "no newline at end of file"

Put a newlineat the end of file.

(It's especially egregious not to have a newline at eof when the last line is a preprocessor statement.)

HTH,
--Eljay

How to suppress warning?

[Lev Assinovsky]

Hello folks!
Does anybody knows how to suppress warning:
"no newline at end of file"

Thanks in advance.

----
Lev Assinovsky
Aelita Software Corporation
O&S InTrust Framework Division, Team Leader
ICQ# 165072909