public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Oleg Endo <oleg.endo@t-online.de>
To: gcc-help@gcc.gnu.org
Cc: Cherry Vanc <cherry.vanc@gmail.com>
Subject: Re: fuse multiple ops into one new op
Date: Sat, 02 Aug 2014 09:09:00 -0000	[thread overview]
Message-ID: <61D7F368-A107-4C9D-AC1F-04FF7EF94629@t-online.de> (raw)
In-Reply-To: <alpine.DEB.2.11.1408020859090.31241@stedding.saclay.inria.fr>


On 02 Aug 2014, at 09:02, Marc Glisse <marc.glisse@inria.fr> wrote:

> On Fri, 1 Aug 2014, Cherry Vanc wrote:
> 
>> I need to fuse multiple instructions into a single one.
>> ...
>> r1 = (r1) op1 (const)
>> ...
>> ...
>> r1 = (r1) op2 (r2)
>> ...
>> ...
>> r3 = op3 (r1)
>> ...
>> 
>> I defined a peephole2 pattern in my GCC backend .md file. If these
>> three instructions are contiguous, then I do get my test "testnew"
>> instruction. If these instructions are far apart, I dont.
>> 
>> (define_peephole2
>> [(set (match_operand:DI 0 "register_operand" "")
>>   (op1:DI (match_dup 0) (match_operand:SI 1 "immediate_operand" "") ))
>> (set (match_dup 0)
>>   (op2:DI (match_operand:DI 2 "register_operand" "") (match_dup 0)))
>> (set (match_dup 0)
>>   (sign_extend:DI (op3:SI (match_dup 0))))]
>> "TARGET_MYCORE"
>> [(set (match_dup 0) (sign_extend:DI (op3:SI (op2:SI (op1:SI
>> (match_dup 0) (match_dup 1)) (match_dup 0)))))]
>> "")
>> 
>> (define_insn "*testnew"
>> [(set (match_operand:DI 0 "register_operand" "=d")
>>       (sign_extend:DI (op3:SI (op2:SI (op1:SI (match_dup 0)
>> (match_operand:SI 1 "immediate_operand" "I")) (match_dup 0)))))]
>> "TARGET_MYCORE"
>> "testnew 36"
>> [(set_attr "mode" "DI")])
>> 
>> How can I fuse multiple instructions that are far apart into a new
>> single opcode that MYCORE has ?
> 
> Hello,
> 
> I probably haven't looked closely enough, but could you explain why the 'combine' pass isn't already doing what you want?

Yes, this kind of stuff is usually done using the combine pass.
However, it will not try out all permutations of instructions, but
rather follow some rules.  Thus the patterns in the .md have to
match combine's expectations.  To see which patterns it tries out,
look at the rtl pass dump.  From there it should rather easy to
write down the expected pattern.  Notice also that sometimes
patterns will not be picked if the rtx costs are off.  Again,
see combine's log for when this happens.

Cheers,
Oleg

  reply	other threads:[~2014-08-02  9:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 23:18 Cherry Vanc
2014-08-02  7:02 ` Marc Glisse
2014-08-02  9:09   ` Oleg Endo [this message]
2014-08-02  9:52 ` Jeff Law
2014-08-05 23:26   ` Cherry Vanc
2014-08-05 23:27     ` Cherry Vanc
2014-08-06  5:51     ` Marc Glisse
2014-08-07 18:35       ` Cherry Vanc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61D7F368-A107-4C9D-AC1F-04FF7EF94629@t-online.de \
    --to=oleg.endo@t-online.de \
    --cc=cherry.vanc@gmail.com \
    --cc=gcc-help@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).