public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Zopolis0 <creatorsmithmdt@gmail.com>, gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: Incorrect replacement of TYPE_METHODS with TYPE_FIELDS causing segfault.
Date: Wed, 08 Jun 2022 15:02:16 +0800	[thread overview]
Message-ID: <875a5f84da00d9ade01a444a4ead4b5d4dfd9c58.camel@xry111.site> (raw)
In-Reply-To: <CAEYL+X-c5ptW7A+4E5t6Hq3Sc-0+Q43y5rAqJR+2fBB=A5d5oA@mail.gmail.com>

On Wed, 2022-06-08 at 14:47 +1000, Zopolis0 via Gcc-help wrote:

/* snip */

> java/lang/Object.java: internal compiler error: tree check: expected
> function_decl, have field_decl in layout_class_method, at java/class.cc:2627
> 
> I believe that this error is due to the following incorrect code at line
> 2589 at gcc/java/class.cc:
>   for (tree method_decl = TYPE_FIELDS (this_class);
> 
> Before it was removed, this line was:
>   for (method_decl = TYPE_METHODS (this_class);
> 
> But I have since modified it (
> https://github.com/Zopolis4/gcj/commit/1f38bc896a704290ca0b742c60c60a88d5e1fb07#diff-bf49cdc948b20b9f25afd3fbb36922a10e979a55ff9600b3b51d0ec54175b752L2592)
> in accordance with 5aaa8fb40681ee66282d73dab8c8eccbf5ee0518
> 
> Given that this was incorrect, what would be the correct way to replace
> this instance of TYPE_METHODS? Were all my replacements of TYPE_METHODS in
> gcc/java/class.cc wrong?

5aaa8fb is not a simple replacement.  For example:

   /* If there are user-defined methods, they are deemed non-trivial.  */
-  for (tmp = TYPE_METHODS (type); tmp; tmp = TREE_CHAIN (tmp))
-    if (!DECL_ARTIFICIAL (tmp))
+  for (tree fld = TYPE_FIELDS (type); fld; fld = DECL_CHAIN (fld))
+    if (TREE_CODE (TREE_TYPE (fld)) == METHOD_TYPE && !DECL_ARTIFICIAL (fld))
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       return true;

I think you need to check if the field is really a method like this.
-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2022-06-08  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  4:47 Zopolis0
2022-06-08  7:02 ` Xi Ruoyao [this message]
2022-06-08  8:13   ` Zopolis0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875a5f84da00d9ade01a444a4ead4b5d4dfd9c58.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=creatorsmithmdt@gmail.com \
    --cc=gcc-help@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).