public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Pepe <list.gcc-help@pe82.de>
To: gcc-help@gcc.gnu.org
Subject: Correct way to provide a C callback function nside C++
Date: Fri, 27 Jan 2023 14:23:53 +0100	[thread overview]
Message-ID: <B9798D57-6AD5-42B0-ABD4-28C46BB4D5CB@pe82.de> (raw)

Hi there,

I’m in an ongoing discussion about whether or not one should use extern “C” when defining a function that will be used as a callback in a statically linked C library. For example:

c_func.h:
// …
void reg_callback(void (*fn)());
// …

cpp_impl.cpp:
// …
extern “C” {
#include “c_func.h”
}

// my callback function with internal linkage
namespace {

extern “C” {
static void my_callback_A() {
	// …
}
} // extern “C”

void my_callback_B() {
	// …
}

} // namespace

void do_something() {
	reg_callback(my_callback_A);
	reg_callback(my_callback_B);
}

Both callbacks have internal linkage. Both work fine, and something like my_callback_B is found in lots of code bases.

In my opinion, using callback B is implementation defined behaviour, because it is not guaranteed that C and C++ use the same calling conventions. Therefore a function must adhere to the C calling conventions to be used as a callback in a C library, which would be callback A.

I’ve been trying to find something definitive for days now, but to no avail. Now I’m not sure what’s true or not. The counter argument is the following: The compiler should know reg_callback is a C function and make sure that a given argument would either be valid or cause a compiler error. That sounds reasonable, so I would love to know how to do it properly for future reference. Given we use gcc I was hoping to get a definitive answer in this mailing list. Thanks a lot!

Pepe

             reply	other threads:[~2023-01-27 13:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 13:23 Pepe [this message]
2023-01-27 13:48 ` Tom Kacvinsky
2023-01-27 13:51   ` Jonathan Wakely
2023-01-27 14:07 ` Jonathan Wakely
2023-01-27 14:29   ` Michael Pape
2023-01-27 14:30   ` Xi Ruoyao
2023-01-27 15:32     ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9798D57-6AD5-42B0-ABD4-28C46BB4D5CB@pe82.de \
    --to=list.gcc-help@pe82.de \
    --cc=gcc-help@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).