From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: 旋转华尔兹 <i@shuaitq.com>
Cc: gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: How can I send a patch to libstdc++-v3 about a small mistake
Date: Tue, 4 Jul 2023 17:48:39 +0100 [thread overview]
Message-ID: <CAH6eHdRWpL650O6EUPkh9XMOBdR=9A9-oZ-hiEHLURFPM9iFiQ@mail.gmail.com> (raw)
In-Reply-To: <tencent_938134FC9F8991A6CCE4D8A330978FB2A707@qq.com>
On Tue, 4 Jul 2023 at 17:43, 旋转华尔兹 <i@shuaitq.com> wrote:
>
> Hello all
>
> I found a small mistake while looking at the code of libstdc++-v3 on GitHub. link: gcc/libstdc++-v3 at master · gcc-mirror/gcc (github.com). And the wiki of GitHub repo shows that pull requests sent to this repository will be ignored and should be contributed upstream instead.
>
> So, I want to send a patch to upstream. But I have not contributed code before. I have no idea what I should do, and I have some questions below.
>
> Should I subscribe to mailing lists like gcc-help, gcc-patches and libstdc++ before sending a patch?
No, that's not necessary.
> Should I just send the patch to mailing list gcc-patches and libstdc++?
Yes.
> After I send the patch to mailing list, if there anyone will send email to me about the result or all I should do is wait a commit in git://gcc.gnu.org/git/gcc.git?
You will get replies to your email.
> What else should I do? like testing, documentation changes. I think this is a small mistake fix, this is not needed.
It depends on the patch.
> Should I send patch email using git send-email rather than email website like Gmail?
Ideally yes, but it's not necessary. If you use Gmail, you get better
results attaching the patch rather than pasting it into the email
body. And it's easier if the patch file has a .txt extension so that
Gmail sends it as text/plain not some other mime type.
> If there is anything you think I should know, you can just write it in email or give me a link. I'm happy to know.
See the "contributing" link on the GCC home page, which takes you to
https://gcc.gnu.org/contribute.html
prev parent reply other threads:[~2023-07-04 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 16:43 =?gb18030?B?0P3XqruqtvvXyA==?=
2023-07-04 16:48 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdRWpL650O6EUPkh9XMOBdR=9A9-oZ-hiEHLURFPM9iFiQ@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-help@gcc.gnu.org \
--cc=i@shuaitq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).