From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Jim Wilson <jimw@sifive.com>
Cc: Zdenek Sojka <zsojka@seznam.cz>, gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: riscv libsanitizer: error: missing terminating ' character
Date: Tue, 9 Jun 2020 14:38:39 +0100 [thread overview]
Message-ID: <CAH6eHdTvtVT+XpNW9PXgOUpZvjMPhLMHaLbyHL8-VyrU_ka_jw@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVaYmR7dgbd+Dh+bEsw0jqHSpHOtEBux6s5JYGYpe0L7RjA@mail.gmail.com>
On Tue, 9 Jun 2020 at 02:33, Jim Wilson wrote:
>
> On Fri, Jun 5, 2020 at 9:11 AM Jonathan Wakely via Gcc-help
> <gcc-help@gcc.gnu.org> wrote:
> > > It seems -std=gnu++11 should be replaced by -std=gnu++14 ; but since I
> > > couldn't find anyone else reporting this issue, maybe the problem is on my
> > > side?
> >
> > The single quote as a digit separator is a C++14 feature, so the
> > libsanitizer code should not be using it.
>
> The libsanitizer sources are imported from an external tree. We can't
> dictate what language version they are written in. It looks like we
> do have a set of local patches that we apply after a merge. So
> someone could add a local patch for this to remove the single quotes
> if necessary.
Right, what I meant is that our copy of the libsanitizer code should
not be using C++14 features, because we build it as C++11.
prev parent reply other threads:[~2020-06-09 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 5:15 Zdenek Sojka
2020-06-05 16:11 ` Jonathan Wakely
2020-06-09 1:32 ` Jim Wilson
2020-06-09 11:40 ` Zdenek Sojka
2020-06-09 13:38 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdTvtVT+XpNW9PXgOUpZvjMPhLMHaLbyHL8-VyrU_ka_jw@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-help@gcc.gnu.org \
--cc=jimw@sifive.com \
--cc=zsojka@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).