From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 92211383E838 for ; Tue, 9 Jun 2020 13:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92211383E838 Received: by mail-io1-xd2f.google.com with SMTP id y5so22707266iob.12 for ; Tue, 09 Jun 2020 06:38:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O6JeKNcPRn+YJlTGDvjRNSvPFQikaal18QxG3e2xpBk=; b=psZOzNpj933AL9a3tWEnFWynunV1hGRvAAtr3iWQtS5utEiqZ4R5NiTySO9Mp5TqeU /xcOnJJfhGkloxZkwdaa2M+GhQ7uMhkFvT2brxffuSGE7ucxRvPoRbHNaNzCXXMtf6RP /uLSwwj0jI6uI2uWB5SlcLVu3hKAv+6PY5e5GgKNOzqUBPyEAX4KwRJVvpEALsDAWGLf puMI3PiooaOToFodTAI/8i5C5109vTaaRCPG7TRzM+vanqDlZs6g9MU7URl68+n+Ug5L y3tioKaiL0hRgBKzjXUDTh27NAPa2rhO6GvjSWMCzTCT//6Z1L122lvOj3vbmrdFCUw2 KfHg== X-Gm-Message-State: AOAM5313jlj6Ewtr59jVXOlStuKf40qOO7Jzlkld2qHo0dWFEXCzxwGw IHCnL7qiQcMrlqat5UVVR3bwcrWsR30hJRKwxzs= X-Google-Smtp-Source: ABdhPJxD82jCUE/ma3hP/iKj+df7WiBOYY3u8vR00EzJEqAr6kjY8xPSdnaYF4EHacICuTcTRi/xAJBpdP12Qp3bTaQ= X-Received: by 2002:a02:cc49:: with SMTP id i9mr27335437jaq.52.1591709930045; Tue, 09 Jun 2020 06:38:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 9 Jun 2020 14:38:39 +0100 Message-ID: Subject: Re: riscv libsanitizer: error: missing terminating ' character To: Jim Wilson Cc: Zdenek Sojka , gcc-help Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-help@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-help mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 13:38:52 -0000 On Tue, 9 Jun 2020 at 02:33, Jim Wilson wrote: > > On Fri, Jun 5, 2020 at 9:11 AM Jonathan Wakely via Gcc-help > wrote: > > > It seems -std=gnu++11 should be replaced by -std=gnu++14 ; but since I > > > couldn't find anyone else reporting this issue, maybe the problem is on my > > > side? > > > > The single quote as a digit separator is a C++14 feature, so the > > libsanitizer code should not be using it. > > The libsanitizer sources are imported from an external tree. We can't > dictate what language version they are written in. It looks like we > do have a set of local patches that we apply after a merge. So > someone could add a local patch for this to remove the single quotes > if necessary. Right, what I meant is that our copy of the libsanitizer code should not be using C++14 features, because we build it as C++11.