From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by sourceware.org (Postfix) with ESMTPS id 8B35C3858D33 for ; Sun, 24 Mar 2024 09:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B35C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B35C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711272630; cv=none; b=AxDa3hdkH55duKFidaRQcAMal9AtueWepYalJYhaX7SdKTYY1FDj9BMR3UhmGOS2Zt6BKrYGL+JS+hZW/9LRhKn+S6c2T0ogVCu2EtRoj32N7qitYexezcRvoXN9yPttq1tRHOnYFrIfa1MaIuP8haXhJAt45PiAucEwNE/8v9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711272630; c=relaxed/simple; bh=okmsGlQtTsaG4YZ0jMshWyY2sNzTvcAeET21QLqCG1g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Y7KB3ic43WeFhkiMHvBz6dwcghc+6+x884ufEUjvyrbK0kHptW/FYGUgpWINA6a/7mjeuEPBWozuYPqrjyPkZf0N5fhEi3QMVjU3WpaHAe36sY02kXm4lV3m5S2pnwmx1IMrbAo38eLtn401q8rJe+QdaBvTz+O+w1vfbixydWM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-5a4f7a648dbso1893654eaf.3 for ; Sun, 24 Mar 2024 02:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711272628; x=1711877428; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dnOO2T8UCOww/6KC+oZKcC/PKXA6yQi2NBnW8CMa6fo=; b=aKQwP9KV8qYofFbZfE0WdlzjCx/ypYFpiZErj7befbWoXGYX4DCygCuEvnxPHHGEU7 ZMtKpTgnFusmJSVegLHfahl9AJG1U36aaRW05VDsHbDASZTrhaFQ+94Q5h5WNtGUdq0V 85GwbaGTpknxTgY6Q4Le/6gE4hWR/eTskOryAmmk3dmCqmqv3y0ya08FiqJdFhRw/BC9 c6w5kGtLloG+0lsabFwps2Dyuq00btBybjInj//rpQ54G7L0MNmub1g/Cvu+nzraSLiM drXnRNQdmpNaBIHdQIhOxzQE1OxtewS5x0stX9TDlDPhP9GP4W8elSxkqmQvPUJdASos b6yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711272628; x=1711877428; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dnOO2T8UCOww/6KC+oZKcC/PKXA6yQi2NBnW8CMa6fo=; b=n9D7I1UJeOtoCWGrt2nYGaH7CFbpulcJx+HdeZ/BBK6PGIBU92QIHCPHYtw2kXM+4B 5UMnGmtgcbCSWcQHuRXYS2E+uDc4KNnc+uyTPY5i4RkiQObHaJqNv78j5vQzjZC96u8p sc+GUvB0bGsm1rCGLWSTuWPLIScKKGlBs1hzfX3Rnp75F+sn2hOeCAfwG7ncRUuFrYVh 1nkobqtdTC2bbkCwnudMah34zfFgrpoy/TYDIvK63rlR8CgBg4nJiY6FAUf1MtMAtjD9 bO8QUBTR7ghmmW/xOeFDjKnjzo+2J1imLfnGA//8E8Zrs5l4EU6jH95QK2X0ttET4TWJ xPyw== X-Gm-Message-State: AOJu0Yy4GmbczTxxtaO8uGiKm5XmtyRK1W4hMezvoXjdeStp0H1FKaqj iB3ZP6FOGDVY4LCuP+KfKt/g0fLOMjCq8TbR8DmfXXUqgxB8mIaUwTxPI0kLMc8hX3ckumHobjf 8jvafdP/LH48U5AIMVQjeN/Ka3SB+kv3fOMQ= X-Google-Smtp-Source: AGHT+IHGqEaPmzk5luYGl2ZpPnZioIyiiiNG3d+Y5dklmBSoDXXzCWRuVlQM7Uqgqt+VSk0O9oEJktu4AydC8aUDHqw= X-Received: by 2002:a05:6358:560c:b0:17f:5693:2676 with SMTP id b12-20020a056358560c00b0017f56932676mr5089539rwf.8.1711272627537; Sun, 24 Mar 2024 02:30:27 -0700 (PDT) MIME-Version: 1.0 References: <20240321152611.GC19790@gate.crashing.org> In-Reply-To: <20240321152611.GC19790@gate.crashing.org> From: Centurion Date: Sun, 24 Mar 2024 13:30:16 +0400 Message-ID: Subject: Re: your mail To: Segher Boessenkool Cc: gcc-help@gcc.gnu.org Content-Type: multipart/alternative; boundary="00000000000014150a061464b567" X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000014150a061464b567 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ``` bool find_template_parameter_info::found (tree parm) { if (TREE_CODE (parm) =3D=3D TREE_LIST) parm =3D TREE_VALUE (parm); if (TREE_CODE (parm) =3D=3D TYPE_DECL) parm =3D TREE_TYPE (parm); else parm =3D DECL_INITIAL (parm); gcc_checking_assert (TEMPLATE_PARM_P (parm)); return parms.contains (parm); } ``` Is there a reason why TREE_TYPE used only for TYPE_DECL, but not for TEMPLATE_DECL ? process_template_parm initializes DECL_INITIAL for non type template parameters, but TYPE_DECL and TEMPLATE_DECL, stayed with nullptr, on the other hand as I understood it always initializes TREE_TYPE. cp/pt.cc::tree process_template_parm: ``` if (parm && TREE_CODE (parm) =3D=3D TEMPLATE_DECL) { t =3D cxx_make_type (TEMPLATE_TEMPLATE_PARM); ... TREE_TYPE (result) =3D t; ... } else { t =3D cxx_make_type (TEMPLATE_TYPE_PARM); /* parm is either IDENTIFIER_NODE or NULL_TREE. */ decl =3D build_decl (parm_loc, TYPE_DECL, parm, t); } ``` In other similar pieces of code the condition is for both for TYPE_DECL and TEMLATE_DECL: cp/pt.cc::tree template_parm_to_arg: ``` if (DECL_P (t) && DECL_TEMPLATE_PARM_P (t)) { if (TREE_CODE (t) =3D=3D TYPE_DECL || TREE_CODE (t) =3D=3D TEMPLATE_DECL) t =3D TREE_TYPE (t); else t =3D DECL_INITIAL (t); } ``` cp/pt.cc::tree get_template_parm_index: ``` if (TREE_CODE (parm) =3D=3D PARM_DECL || TREE_CODE (parm) =3D=3D CONST_DECL) parm =3D DECL_INITIAL (parm); else if (TREE_CODE (parm) =3D=3D TYPE_DECL || TREE_CODE (parm) =3D=3D TEMPLATE_DECL) parm =3D TREE_TYPE (parm); ``` Sorry if I ask stupid question. On Thu, Mar 21, 2024 at 7:28=E2=80=AFPM Segher Boessenkool < segher@kernel.crashing.org> wrote: > On Thu, Mar 21, 2024 at 07:12:23PM +0400, Centurion via Gcc-help wrote: > > HI, I am new in gcc codebase. Can you explain please why we can't just > use > > TREE_TYPE(parm) for TEMLATE_TEMPLATE_PARM and why DECL_INITIAL is needed > > for it? I tried to debug Bug 114377 and it seems to work fine. Thanks > > You cannot use TREE_TYPE if that would just access nonsense data. > > The wrong thing might still work, in many cases. If you have no > substantiation why your proposed change would work fine, chances are it > does not. Sorry. > > > Segher > > > > --- a/gcc/cp/pt.cc > > +++ b/gcc/cp/pt.cc > > @@ -11032,10 +11032,7 @@ find_template_parameter_info::found (tree parm) > > { > > if (TREE_CODE (parm) =3D=3D TREE_LIST) > > parm =3D TREE_VALUE (parm); > > - if (TREE_CODE (parm) =3D=3D TYPE_DECL) > > - parm =3D TREE_TYPE (parm); > > - else > > - parm =3D DECL_INITIAL (parm); > > + parm =3D TREE_TYPE(parm); > > gcc_checking_assert (TEMPLATE_PARM_P (parm)); > > return parms.contains (parm); > > } > --00000000000014150a061464b567--