From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 6A27E3858C83 for ; Tue, 19 Apr 2022 19:50:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A27E3858C83 Received: by mail-ej1-x634.google.com with SMTP id lc2so35018077ejb.12 for ; Tue, 19 Apr 2022 12:50:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=drTc/WkYSJ9sZQBm8wh9kdSR9N+/6AfjZaItY1c6GoI=; b=0mKH/3wEKuTdv1BwCCsUkXeQJ7NlshGt4DUuvu3viqT689k6oDqHlmVngUEhIc0U6J eC9uOeINJXpNaz7duAADJK+mHVinhOuZAj6lkm7oMqIp/hgeDNxhXz19xskedOls1s92 D7aU7d0MM/nxKEEv5rQ/NlTXx9ylQj1147XQkjdUyQgjOIqn2quQvDzGP+3BazSUJ7H3 NYSdq/lQYIn/74JD/DzqUFsu6Yj2QQj8h9DVQp6srwTXF52lVNfvDC4EFyTBVJ1OzCWd +pEwoBDmf3yPxIdpmQZph6In7bw4G/GWSyQKgfGquhwR4zFZpxCf+4BGWamO4DXLwHYl wrBQ== X-Gm-Message-State: AOAM530Z/vvSV4y20c/Ys78FjfRCB9Inm6uT5y+RMZ3KakzeRQdag0JI rSUSz6OUyKrlBTdBaUaNaqIG92PVljRRD/h+m/SCeA== X-Google-Smtp-Source: ABdhPJy/6DpeA3ej52qiSiyfe+Tp5TJPNpqDjYhF8afD9gD4Kt3ffz6mfrsRF6kPFhwJKl925aa0oRKcqZWBBDwApfU= X-Received: by 2002:a17:906:52c7:b0:6ce:a880:50a3 with SMTP id w7-20020a17090652c700b006cea88050a3mr14862666ejn.437.1650397853057; Tue, 19 Apr 2022 12:50:53 -0700 (PDT) MIME-Version: 1.0 References: <20220416053920.4hj6vcnqqlscile7@mattwilson.org> <20220416192445.dxuftlrblkhctmir@mattwilson.org> In-Reply-To: From: Ian Lance Taylor Date: Tue, 19 Apr 2022 12:50:41 -0700 Message-ID: Subject: Re: Error when building gcc w/ Go language on Solaris To: Jonathan Wakely Cc: "Matthew R. Wilson" , gcc-help , gcc-patches , gofrontend-dev Content-Type: multipart/mixed; boundary="000000000000c5355205dd0731ee" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-help@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-help mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 19:50:56 -0000 --000000000000c5355205dd0731ee Content-Type: text/plain; charset="UTF-8" On Tue, Apr 19, 2022 at 6:36 AM Jonathan Wakely wrote: > > The 'check-tail' target in libgo/Makefile.am does: > > ... | sed -n -e 's/.* \(version.*$$\)/\1/p'` >> libgo.sum > > This doesn't work with Solaris sed (and is documented by Autoconf as > being non-portable). The $ needs to be outside the back-reference > expression: > > ... | sed -n -e 's/.* \(version.*\)$$/\1/p'` >> libgo.sum > > This should be OK to change, because the $ is just an anchor and > doesn't need to be captured. > > More significantly, I see errors like: > > /export/home/jwakely/src/gcc/libgo/match.sh: line 114: ((: go1.13 : > syntax error: invalid arithmetic operator (error token is ".13 ") > > That script uses \+ in a sed script, which is not supported by POSIX > sed, because it's not in the BRE grammar. That seems to be the cause > of the match.sh errors. The attached patch fixes it. Thanks for looking. Committed to mainline like so. Ian --000000000000c5355205dd0731ee Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l26k993a0 NzVmN2I2NWQzZjc3NWYwNmJlMDhjNWQyYTk1NzNiNDlhNGI0YjFkNQpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCAyMzIx ZjY3Y2E1ZC4uNjMyMzg3MTViZDAgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotMjJiMGNjZGEz YWE0ZDE2Zjc3MGEyNmEzZWIyNTFmOGRhNjE1YzMxOAorOTljYTZiZTQwNmE1NzgxYmUwNzhmZjIz ZjQ1YTcyYjRjODRiMTZlMwogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vTWFrZWZpbGUuYW0gYi9saWJn by9NYWtlZmlsZS5hbQppbmRleCBlMGExZWVjNTJhMi4uYTVkNGI2YTM1MjUgMTAwNjQ0Ci0tLSBh L2xpYmdvL01ha2VmaWxlLmFtCisrKyBiL2xpYmdvL01ha2VmaWxlLmFtCkBAIC0xMzA1LDcgKzEz MDUsNyBAQCBjaGVjay10YWlsOiBjaGVjay1yZWN1cnNpdmUgY2hlY2stbXVsdGkKIAlpZiB0ZXN0 ICIkJHVudGVzdGVkIiAtbmUgIjAiOyB0aGVuIFwKIAkgIGVjaG8gIiMgb2YgdW50ZXN0ZWQgdGVz dGNhc2VzCQkkJHVudGVzdGVkIiA+PiBsaWJnby5zdW07IFwKIAlmaTsgXAotCWVjaG8gYGVjaG8g JChHT0MpIHwgc2VkIC1lICdzLyAuKi8vJ2AgIGAkKEdPQykgLXYgMj4mMSB8IGdyZXAgIiB2ZXJz aW9uIiB8IHNlZCAtbiAtZSAncy8uKiBcKHZlcnNpb24uKiQkXCkvXDEvcCdgID4+IGxpYmdvLnN1 bTsgXAorCWVjaG8gYGVjaG8gJChHT0MpIHwgc2VkIC1lICdzLyAuKi8vJ2AgIGAkKEdPQykgLXYg Mj4mMSB8IGdyZXAgIiB2ZXJzaW9uIiB8IHNlZCAtbiAtZSAncy8uKiBcKHZlcnNpb24uKlwpJCQv XDEvcCdgID4+IGxpYmdvLnN1bTsgXAogCWVjaG8gPj4gbGliZ28ubG9nOyBcCiAJZWNobyAicnVu dGVzdCBjb21wbGV0ZWQgYXQgYGRhdGVgIiA+PiBsaWJnby5sb2c7IFwKIAlpZiB0ZXN0ICIkJGZh aWwiIC1uZSAiMCI7IHRoZW4gXApkaWZmIC0tZ2l0IGEvbGliZ28vbWF0Y2guc2ggYi9saWJnby9t YXRjaC5zaAppbmRleCAxMzlkMGNkYmU2NC4uN2VkNTg3ZmY3OTQgMTAwNzU1Ci0tLSBhL2xpYmdv L21hdGNoLnNoCisrKyBiL2xpYmdvL21hdGNoLnNoCkBAIC0xMDAsNyArMTAwLDcgQEAgZmkKIAog Z29idWlsZCgpIHsKICAgICBsaW5lPSQoZWNobyAiJDEiIHwgc2VkIC1lICdzfC8vZ286YnVpbGQg fHwnKQotICAgIGxpbmU9JChlY2hvICIkbGluZSIgfCBzZWQgLWUgJ3MvZ28xXC5bMC05XVwrLzEv ZycgLWUgJ3MvZ29leHBlcmltZW50XC4vZ29leHBlcmltZW50LycpCisgICAgbGluZT0kKGVjaG8g IiRsaW5lIiB8IHNlZCAtZSAncy9nbzFcLlswLTldWzAtOV0qLzEvZycgLWUgJ3MvZ29leHBlcmlt ZW50XC4vZ29leHBlcmltZW50LycpCiAgICAgbGluZT0iICRsaW5lICIKICAgICB3cmFwPSdbICgp ISZ8XScKICAgICBmb3Igb25lcyBpbiAkZ29hcmNoICRnb29zICRjZ290YWcgJGNtZGxpbmV0YWcg Z2NjZ28gZ29leHBlcmltZW50ZmllbGR0cmFjazsgZG8K --000000000000c5355205dd0731ee--