From: Xi Ruoyao <xry111@xry111.site>
To: LIU Hao <lh_mouse@126.com>, stefan@franke.ms, gcc-help@gcc.gnu.org
Subject: Re: AW: optimizer discards sign information
Date: Wed, 10 Apr 2024 18:03:43 +0800 [thread overview]
Message-ID: <a62082a801866540c00b6af428212bda5a2900ac.camel@xry111.site> (raw)
In-Reply-To: <20096916-dc47-4cc9-93c1-bc910ef07327@126.com>
On Wed, 2024-04-10 at 17:57 +0800, LIU Hao via Gcc-help wrote:
> 在 2024-04-10 17:49, stefan@franke.ms 写道:
> > But I keep considering this as a bug. And clang behaves correctly!
>
> Yes there have been many reports [1]. It's a missed optimization.
Note that for this specific case:
typedef unsigned long long int u64;
typedef unsigned int u32;
typedef unsigned short u16;
u64 foo(u16 *a, u16 *b) {
u32 x = *a * *b;
u64 r = x;
return r >> 31;
}
gcc yields
foo:
xor eax, eax
ret
clang yields
foo: # @foo
movzx ecx, word ptr [rdi]
movzx eax, word ptr [rsi]
imul eax, ecx
shr eax, 31
ret
It's actually a missed-optimization of **clang**. Optimizing this
function to always return 0 **is** correct.
But for the general case:
u64 foo(u16 a, u16 b) {
u32 x = a * b;
u64 r = x;
return r;
}
there is a missed-optimization of GCC (redundant sign extension).
> You may work around it by using 32-bit parameters, or casting either
> operand to u32; casting the result will not help.
Indeed.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2024-04-10 10:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 8:52 stefan
2024-04-10 9:16 ` Alexander Monakov
2024-04-10 9:19 ` Xi Ruoyao
2024-04-10 9:40 ` LIU Hao
2024-04-10 9:44 ` Xi Ruoyao
2024-04-10 9:51 ` LIU Hao
2024-04-10 9:52 ` Xi Ruoyao
2024-04-10 10:07 ` LIU Hao
2024-04-10 10:17 ` Xi Ruoyao
2024-04-10 10:03 ` AW: " stefan
2024-04-10 10:34 ` Xi Ruoyao
2024-04-10 9:24 ` stefan
2024-04-10 9:49 ` stefan
2024-04-10 9:54 ` Xi Ruoyao
2024-04-10 9:57 ` LIU Hao
2024-04-10 10:03 ` Xi Ruoyao [this message]
2024-04-10 11:52 ` David Brown
2024-04-10 14:25 ` Stefan Franke
2024-04-10 16:51 ` David Brown
2024-04-11 0:32 ` Oleg Endo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a62082a801866540c00b6af428212bda5a2900ac.camel@xry111.site \
--to=xry111@xry111.site \
--cc=gcc-help@gcc.gnu.org \
--cc=lh_mouse@126.com \
--cc=stefan@franke.ms \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).