public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Georg-Johann Lay <avr@gjlay.de>
To: gcc-patches@gcc.gnu.org
Cc: Andrew Pinski <quic_apinski@quicinc.com>,
	Levente <leventelist@gmail.com>,
	gcc-help@gcc.gnu.org
Subject: [patch,avr,applied] Fix PR target/113156 - ICE when building libgcc
Date: Mon, 15 Jan 2024 10:50:03 +0100	[thread overview]
Message-ID: <b2200ee1-d467-41ec-b380-dd437586a6ed@gjlay.de> (raw)
In-Reply-To: <967ecf57-2f9a-4a1b-88e2-1f0e57483a39@gmail.com>

I went ahead and installed Andrew's patch

https://gcc.gnu.org/r14-7240

Johann

Am 15.01.24 um 00:19 schrieb Levente via Gcc-help:
> I'm trying to set up a toolchain for avr-dd MCUs, and I get this error 
> message when I try to compile gcc:
> Lev

--

Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Mon Jan 15 10:31:36 2024 +0100

     AVR: target/113156 - Fix ICE due to missing "Save" on 
-m[long-]double= options.

             Multilib options -mdouble= and -mlong-double= are not 
orthogonal:
             TARGET_HANDLE_OPTION = avr-common.cc::avr_handle_option() 
sets them
             such that  sizeof(double) <= sizeof(long double)  is always 
true.

     gcc/
             PR target/113156
             * config/avr/avr.opt (-mdouble, -mlong-double): Add "Save" 
flag.
             (-mbranch-cost): Set "Optimization" flag.

diff --git a/gcc/config/avr/avr.opt b/gcc/config/avr/avr.opt
index ee0b40603f0..c9f2b4d2fe5 100644
--- a/gcc/config/avr/avr.opt
+++ b/gcc/config/avr/avr.opt
@@ -27,7 +27,7 @@ Target RejectNegative Joined Var(avr_mmcu) 
MissingArgError(missing device or arc
  -mmcu=MCU	Select the target MCU.

  mgas-isr-prologues
-Target Var(avr_gasisr_prologues) UInteger Init(0) Optimization
+Target Var(avr_gasisr_prologues) UInteger Init(0) Optimization
  Allow usage of __gcc_isr pseudo instructions in ISR prologues and 
epilogues.

  mn-flash=
@@ -61,7 +61,7 @@ Target RejectNegative Mask(NO_INTERRUPTS)
  Change the stack pointer without disabling interrupts.

  mbranch-cost=
-Target Joined RejectNegative UInteger Var(avr_branch_cost) Init(0)
+Target Joined RejectNegative UInteger Var(avr_branch_cost) Init(0) 
Optimization
  Set the branch costs for conditional branch instructions.  Reasonable 
values are small, non-negative integers.  The default branch cost is 0.

  mmain-is-OS_task
@@ -124,11 +124,11 @@ Target Mask(ABSDATA)
  Assume that all data in static storage can be accessed by LDS / STS. 
This option is only useful for reduced Tiny devices.

  mdouble=
-Target Joined RejectNegative Var(avr_double) Init(0) Enum(avr_bits_e)
+Target Joined RejectNegative Var(avr_double) Init(0) Enum(avr_bits_e) Save
  -mdouble=<BITS>	Use <BITS> bits wide double type.

  mlong-double=
-Target Joined RejectNegative Var(avr_long_double) Init(0) Enum(avr_bits_e)
+Target Joined RejectNegative Var(avr_long_double) Init(0) 
Enum(avr_bits_e) Save
  -mlong-double=<BITS>	Use <BITS> bits wide long double type.

  nodevicelib

  parent reply	other threads:[~2024-01-15  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14 23:19 Can't compile GCC-14 for AVR Levente
2024-01-15  6:09 ` Xi Ruoyao
2024-01-15  9:50 ` Georg-Johann Lay [this message]
2024-01-15 11:55   ` [patch,avr,applied] Fix PR target/113156 - ICE when building libgcc Levente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2200ee1-d467-41ec-b380-dd437586a6ed@gjlay.de \
    --to=avr@gjlay.de \
    --cc=gcc-help@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=leventelist@gmail.com \
    --cc=quic_apinski@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).