From: Xi Ruoyao <xry111@mengyan1223.wang>
To: Krishna Narayanan <krishnanarayanan132002@gmail.com>,
gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: Doubt regarding the PR92209
Date: Sat, 05 Mar 2022 03:48:32 +0800 [thread overview]
Message-ID: <bec3afe124802dadc6bc5bdd301575bf17d15ca4.camel@mengyan1223.wang> (raw)
In-Reply-To: <CABhGnjuLHY66jiNtoU4sFsp6oVA6kG1u4jHe=PP=AMbkVD+O4A@mail.gmail.com>
On Sat, 2022-03-05 at 01:03 +0530, Krishna Narayanan via Gcc-help wrote:
> Hello,
> I am working on this issue(PR92209) and had a query concerning it,for
> this PR I have done by making the required change in text rather than
> a fix-it diagnostic. Either of the two should be fine right?
TL;DR gcc-help is not an ideal place to discuss this. You can send your
patch to gcc-patches to get a review, or leave a comment in the bugzilla
for discussion.
If you only change the text, it will be:
t.c:1:1: warning: a function prototype must specify the argument types [-Wstrict-prototypes]
1 | static int f();
| ^~~~~~
To me it is even worse than what we have now:
t.c:1:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
1 | static int f();
| ^~~~~~
--
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-03-04 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 19:33 Krishna Narayanan
2022-03-04 19:48 ` Xi Ruoyao [this message]
2022-03-05 13:50 ` Krishna Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bec3afe124802dadc6bc5bdd301575bf17d15ca4.camel@mengyan1223.wang \
--to=xry111@mengyan1223.wang \
--cc=gcc-help@gcc.gnu.org \
--cc=krishnanarayanan132002@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).