From: Ian Lance Taylor <iant@google.com>
To: Andy Gibbs <andyg1001@hotmail.co.uk>
Cc: <gcc-help@gcc.gnu.org>
Subject: Re: __builtin_choose_expr
Date: Mon, 10 Oct 2011 19:16:00 -0000 [thread overview]
Message-ID: <mcrwrcc64j5.fsf@coign.corp.google.com> (raw)
In-Reply-To: <BLU0-SMTP11918692115E110FEF24E6BE7FD0@phx.gbl> (Andy Gibbs's message of "Mon, 10 Oct 2011 17:00:14 +0200")
Andy Gibbs <andyg1001@hotmail.co.uk> writes:
> Attached below, therefore, is a simple patch to GCC 4.6.1 which
> implements __builtin_choose_expr for C++. From my testing, it "seems
> to work fine", but I'm afraid this is my first time hacking GCC, so I
> would be very grateful if someone much more knowledgeable than me
> could check over my patch (it should be very easy to follow) to see
> whether my approach is valid or not.
>
> If it seems to people that this is a useful / suitable addition to GCC
> generally, then I would be happy to supplement my patch with
> test-cases and proper documentation and see whether it can be merged
> into the GCC trunk. Obviously I have uses for this feature, but I
> don't know whether it has a broader appeal! ;o)
The patch looks fine to me. You should move it to trunk and submit it
to gcc-patches. You will probably need to sign a copyright assignment;
let me know if you want to start that process.
Thanks!
Ian
next prev parent reply other threads:[~2011-10-10 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 15:00 __builtin_choose_expr Andy Gibbs
2011-10-10 19:16 ` Ian Lance Taylor [this message]
2011-10-11 16:48 ` __builtin_choose_expr Andy Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mcrwrcc64j5.fsf@coign.corp.google.com \
--to=iant@google.com \
--cc=andyg1001@hotmail.co.uk \
--cc=gcc-help@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).