From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2466 invoked by alias); 10 Oct 2011 19:16:53 -0000 Received: (qmail 2448 invoked by uid 22791); 10 Oct 2011 19:16:51 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 19:16:37 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id p9AJGYoH019745 for ; Mon, 10 Oct 2011 12:16:35 -0700 Received: from pzd13 (pzd13.prod.google.com [10.243.17.205]) by wpaz17.hot.corp.google.com with ESMTP id p9AJFGuu004715 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 10 Oct 2011 12:16:33 -0700 Received: by pzd13 with SMTP id 13so28550907pzd.3 for ; Mon, 10 Oct 2011 12:16:33 -0700 (PDT) Received: by 10.68.13.40 with SMTP id e8mr38948356pbc.111.1318274193212; Mon, 10 Oct 2011 12:16:33 -0700 (PDT) Received: by 10.68.13.40 with SMTP id e8mr38948338pbc.111.1318274193050; Mon, 10 Oct 2011 12:16:33 -0700 (PDT) Received: from coign.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net. [71.133.8.30]) by mx.google.com with ESMTPS id d7sm70493355pbn.8.2011.10.10.12.16.31 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 10 Oct 2011 12:16:32 -0700 (PDT) From: Ian Lance Taylor To: Andy Gibbs Cc: Subject: Re: __builtin_choose_expr References: Date: Mon, 10 Oct 2011 19:16:00 -0000 In-Reply-To: (Andy Gibbs's message of "Mon, 10 Oct 2011 17:00:14 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-help-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-help-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg00067.txt.bz2 Andy Gibbs writes: > Attached below, therefore, is a simple patch to GCC 4.6.1 which > implements __builtin_choose_expr for C++. From my testing, it "seems > to work fine", but I'm afraid this is my first time hacking GCC, so I > would be very grateful if someone much more knowledgeable than me > could check over my patch (it should be very easy to follow) to see > whether my approach is valid or not. > > If it seems to people that this is a useful / suitable addition to GCC > generally, then I would be happy to supplement my patch with > test-cases and proper documentation and see whether it can be merged > into the GCC trunk. Obviously I have uses for this feature, but I > don't know whether it has a broader appeal! ;o) The patch looks fine to me. You should move it to trunk and submit it to gcc-patches. You will probably need to sign a copyright assignment; let me know if you want to start that process. Thanks! Ian