[Patch ARM] Fix PR target/38571

[Patch ARM] Fix PR target/38571

[Ramana Radhakrishnan]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi, 

This patch fixes PR 38571 .

Ok to commit ?

2009-04-30  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

	PR target/38571
	* config/arm/arm.h (FUNCTION_BOUNDARY): Define as 16 for Thumb.


cheers
Ramana


Ramana Radhakrishnan
GNU Tools Engineer
ARM Ltd. (www.arm.com)
Phone : +441223400495 (Direct || Voicemail)



[-- Attachment #2: align.patch --]
[-- Type: application/octet-stream, Size: 519 bytes --]

Index: gcc/config/arm/arm.h
===================================================================
--- gcc/config/arm/arm.h	(revision 146905)
+++ gcc/config/arm/arm.h	(working copy)
@@ -537,7 +537,7 @@
 #define PREFERRED_STACK_BOUNDARY \
     (arm_abi == ARM_ABI_ATPCS ? 64 : STACK_BOUNDARY)
 
-#define FUNCTION_BOUNDARY  32
+#define FUNCTION_BOUNDARY  (TARGET_THUMB ? 16: 32)
 
 /* The lowest bit is used to indicate Thumb-mode functions, so the
    vbit must go into the delta field of pointers to member

RE: [Patch ARM] Fix PR target/38571

[Richard Earnshaw]

On Thu, 2009-04-30 at 10:23 +0100, Ramana Radhakrishnan wrote:
> Hi Richard,
> 
> Setting function boundary while optimizing for space so that users don't 
> get a performance hit with thumb and 16 bit alignments and force alignment
> to 32 bits as pointed out.
> 
> Ok to commit now?
> 
> 2009-04-30  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> 
>  	PR target/38571
>  	* config/arm/arm.h (FUNCTION_BOUNDARY): Define as 16 for Thumb
> 	while optimizing for size.

OK.

RE: [Patch ARM] Fix PR target/38571

[Ramana Radhakrishnan]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Hi Richard,

Setting function boundary while optimizing for space so that users don't 
get a performance hit with thumb and 16 bit alignments and force alignment
to 32 bits as pointed out.

Ok to commit now?

2009-04-30  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

 	PR target/38571
 	* config/arm/arm.h (FUNCTION_BOUNDARY): Define as 16 for Thumb
	while optimizing for size.

cheers
Ramana

Ramana Radhakrishnan
GNU Tools Engineer
ARM Ltd. (www.arm.com)
Phone : +441223400495 (Direct || Voicemail)


> -----Original Message-----
> From: Ramana Radhakrishnan [mailto:ramana.radhakrishnan@arm.com]
> Sent: 30 April 2009 09:34
> To: Richard Earnshaw
> Cc: gcc-patches@gcc.gnu.org
> Subject: [Patch ARM] Fix PR target/38571
> 
> Hi,
> 
> This patch fixes PR 38571 .
> 
> Ok to commit ?
> 
> 
> 
> 
> cheers
> Ramana
> 
> 
> Ramana Radhakrishnan
> GNU Tools Engineer
> ARM Ltd. (www.arm.com)
> Phone : +441223400495 (Direct || Voicemail)
> 


[-- Attachment #2: align.patch --]
[-- Type: application/octet-stream, Size: 523 bytes --]

Index: config/arm/arm.h
===================================================================
--- config/arm/arm.h	(revision 146999)
+++ config/arm/arm.h	(working copy)
@@ -537,7 +537,7 @@
 #define PREFERRED_STACK_BOUNDARY \
     (arm_abi == ARM_ABI_ATPCS ? 64 : STACK_BOUNDARY)
 
-#define FUNCTION_BOUNDARY  32
+#define FUNCTION_BOUNDARY  ((TARGET_THUMB && optimize_size)? 16: 32)
 
 /* The lowest bit is used to indicate Thumb-mode functions, so the
    vbit must go into the delta field of pointers to member