* RE: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.
@ 2011-09-16 8:16 Terry Guo
0 siblings, 0 replies; 5+ messages in thread
From: Terry Guo @ 2011-09-16 8:16 UTC (permalink / raw)
To: gcc-patches; +Cc: ro
Ping.
BR,
Terry
> -----Original Message-----
> From: Terry Guo [mailto:terry.guo@arm.com]
> Sent: Sunday, September 11, 2011 9:39 AM
> To: gcc-patches@gcc.gnu.org
> Cc: ro@cebitec.uni-bielefeld.de
> Subject: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c
> for target ARM EABI.
>
> Hello,
>
> This patch aims to disable short enums for arm eabi otherwise the case
> will
> fail to be compiled due to "width of 'code' exceeds its type". Is it OK
> to
> trunk?
>
> BR,
> Terry
>
> 2011-09-09 Terry Guo <terry.guo@arm.com>
>
> * gcc.dg/tree-ssa/foldconst-3.c: Use -fno-short-enums
> for ARM EABI target.
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> index 6132362..e030f53 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> @@ -1,5 +1,6 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -fdump-tree-optimized" } */
> +/* { dg-options "-O2 -fdump-tree-optimized -fno-short-enums" { target
> arm_eabi } } */
> typedef const union tree_node *const_tree;
> typedef struct
> {
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.
2011-09-16 9:17 ` Terry Guo
@ 2011-09-16 10:45 ` Richard Earnshaw
0 siblings, 0 replies; 5+ messages in thread
From: Richard Earnshaw @ 2011-09-16 10:45 UTC (permalink / raw)
To: Terry Guo; +Cc: gcc-patches
On 16/09/11 09:28, Terry Guo wrote:
>> This is a compile-only test, and -fno-short-enums is a global option
>> that all targets support, so I'd suggest just adding -fno-short-enums
>> to
>> the standard list of options. It won't hurt those platforms where that
>> is already the default and it will fix the testcase problem for all
>> those platforms where it isn't.
>>
>> R.
>
> Agree. Here is the updated one.
>
> BR,
> Terry
>
> 2011-09-16 Terry Guo <terry.guo@arm.com>
>
> * gcc.dg/tree-ssa/foldconst-3.c: Don't use short enums.
>
>
OK.
R.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.
2011-09-16 8:30 ` Richard Earnshaw
@ 2011-09-16 9:17 ` Terry Guo
2011-09-16 10:45 ` Richard Earnshaw
0 siblings, 1 reply; 5+ messages in thread
From: Terry Guo @ 2011-09-16 9:17 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gcc-patches
> This is a compile-only test, and -fno-short-enums is a global option
> that all targets support, so I'd suggest just adding -fno-short-enums
> to
> the standard list of options. It won't hurt those platforms where that
> is already the default and it will fix the testcase problem for all
> those platforms where it isn't.
>
> R.
Agree. Here is the updated one.
BR,
Terry
2011-09-16 Terry Guo <terry.guo@arm.com>
* gcc.dg/tree-ssa/foldconst-3.c: Don't use short enums.
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
b/gcc/testsuite/gcc.dg/tree-ssa/foldcons
index 6132362..9f10886 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
+/* { dg-options "-O2 -fdump-tree-optimized -fno-short-enums" } */
typedef const union tree_node *const_tree; typedef struct {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.
2011-09-11 2:42 Terry Guo
@ 2011-09-16 8:30 ` Richard Earnshaw
2011-09-16 9:17 ` Terry Guo
0 siblings, 1 reply; 5+ messages in thread
From: Richard Earnshaw @ 2011-09-16 8:30 UTC (permalink / raw)
To: Terry Guo; +Cc: gcc-patches, ro
On 11/09/11 02:39, Terry Guo wrote:
> Hello,
>
> This patch aims to disable short enums for arm eabi otherwise the case will
> fail to be compiled due to "width of 'code' exceeds its type". Is it OK to
> trunk?
>
> BR,
> Terry
>
> 2011-09-09 Terry Guo <terry.guo@arm.com>
>
> * gcc.dg/tree-ssa/foldconst-3.c: Use -fno-short-enums
> for ARM EABI target.
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> index 6132362..e030f53 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
> @@ -1,5 +1,6 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -fdump-tree-optimized" } */
> +/* { dg-options "-O2 -fdump-tree-optimized -fno-short-enums" { target
> arm_eabi } } */
> typedef const union tree_node *const_tree;
> typedef struct
> {
>
>
This is a compile-only test, and -fno-short-enums is a global option
that all targets support, so I'd suggest just adding -fno-short-enums to
the standard list of options. It won't hurt those platforms where that
is already the default and it will fix the testcase problem for all
those platforms where it isn't.
R.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.
@ 2011-09-11 2:42 Terry Guo
2011-09-16 8:30 ` Richard Earnshaw
0 siblings, 1 reply; 5+ messages in thread
From: Terry Guo @ 2011-09-11 2:42 UTC (permalink / raw)
To: gcc-patches; +Cc: ro
Hello,
This patch aims to disable short enums for arm eabi otherwise the case will
fail to be compiled due to "width of 'code' exceeds its type". Is it OK to
trunk?
BR,
Terry
2011-09-09 Terry Guo <terry.guo@arm.com>
* gcc.dg/tree-ssa/foldconst-3.c: Use -fno-short-enums
for ARM EABI target.
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
index 6132362..e030f53 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/foldconst-3.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-optimized" } */
+/* { dg-options "-O2 -fdump-tree-optimized -fno-short-enums" { target
arm_eabi } } */
typedef const union tree_node *const_tree;
typedef struct
{
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-16 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-16 8:16 [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI Terry Guo
-- strict thread matches above, loose matches on Subject: below --
2011-09-11 2:42 Terry Guo
2011-09-16 8:30 ` Richard Earnshaw
2011-09-16 9:17 ` Terry Guo
2011-09-16 10:45 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).