> -----Original Message----- > From: Richard Earnshaw > Sent: Tuesday, November 12, 2013 18:49 > To: Joey Ye > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [patch] [arm] New option for PIC offset unfixed > > The name of the option and the documentation highlights that the > option's concept is confusing. > > I think what you really need to do is to reverse the sense of the option > name and have > > -mpic-data-is-text-relative > > with the inverse (-mno-pic-data-is-text-relative) being the active value > that triggers for vxworks. That is, PIC data being text-relative is the > default for all targets except vxworks. > > R. > > Oh, and at run time, we should be talking about segments, not sections! Richard, Thanks for quick response. Updated patch renamed the option, variables and macro. Also use segments in document. OK? 2013-11-13 Joey Ye * config/arm/arm.c (arm_option_override): Error if -mpic-data-is-text-relative without -fpic, and set for VxWorks RTP. (legitimize_pic_address): Use arm_pic_data_is_text_relative (arm_assemble_integer): Likewise. * config/arm/arm.h (TARGET_DEFAULT_PIC_DATA_IS_TEXT_RELATIVE): New macro. * config/arm/arm.opt (mpic-data-is-text-relative): New option. * doc/invoke.texi (-mpic-data-is-text-relative): Doc for new option.