From: "Sebastian Perta" <sebastian.perta@renesas.com>
To: "'DJ Delorie'" <dj@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH] RL78 one_cmplhi2 improvement
Date: Tue, 27 Feb 2018 15:33:00 -0000 [thread overview]
Message-ID: <000101d3afe0$523338a0$f699a9e0$@renesas.com> (raw)
In-Reply-To: <xnbmgjjvs4.fsf@greed.delorie.com>
HI DJ,
> One thing to try is to use (subreg:QI in a define_expand, so that
> there's a one_cmplhi2 pattern that expands to two QImode insns that
> operate on HImode input/outputs via SUBREGs.
Thank you for the suggestion! After several attempts the following is the
only successful one, however the code produced is identical with and without
the patch:
(define_expand "one_cmplhi2"
[(set (subreg:QI (match_operand:HI 0 "nonimmediate_operand") 0)
(xor:HI (subreg:QI (match_operand:HI 1 "general_operand") 0)
(const_int -1)))
(set (subreg:QI (match_dup 0) 1)
(xor:HI (subreg:QI (match_dup 1) 1)
(const_int -1)))
]
""
"DONE;"
)
Is this similar to what you had in mind?
Output code (same as before the patch ... the patch makes no difference):
_test_one_cmplhi:
mov a, [sp+4]
xor a, #-1
mov r8, a
mov a, [sp+5]
xor a, #-1
mov r9, a
ret
I also explored other options including define_split without any success.
> If it doesn't work out, consider this patch approved, though.
Can I checkin now?
Best Regards,
Sebastian
> -----Original Message-----
> From: DJ Delorie [mailto:dj@redhat.com]
> Sent: 20 February 2018 19:39
> To: Sebastian Perta <Sebastian.Perta@renesas.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] RL78 one_cmplhi2 improvement
>
>
> Const type promotion is the bane of embedded developers...
>
> One thing to try is to use (subreg:QI in a define_expand, so that
> there's a one_cmplhi2 pattern that expands to two QImode insns that
> operate on HImode input/outputs via SUBREGs.
>
> I don't have high hopes of gcc optimizing this properly in all cases,
> but it's worth trying.
>
> If it doesn't work out, consider this patch approved, though.
>
> Thanks!
next prev parent reply other threads:[~2018-02-27 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 12:15 Sebastian Perta
2018-02-20 19:44 ` DJ Delorie
2018-02-27 15:33 ` Sebastian Perta [this message]
2018-02-27 15:52 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d3afe0$523338a0$f699a9e0$@renesas.com' \
--to=sebastian.perta@renesas.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).