* [PATCH, testsuite] Add loop unrolling command line options for some test cases
@ 2011-09-21 9:17 Jiangning Liu
2011-09-21 20:28 ` Mike Stump
0 siblings, 1 reply; 6+ messages in thread
From: Jiangning Liu @ 2011-09-21 9:17 UTC (permalink / raw)
To: gcc-patches; +Cc: ro, mikestump
Hi,
The following test cases are to check predictive commoning optimization by
detecting loop unrolling times. Originally by default the max-unroll-times
is 8. If max-unroll-times is specified to be less than the expected
unrolling times, those cases would fail.
The fix is to explicitly turn on loop unroll and set max-unroll-times to 8,
which is larger than the unrolling times being detected in the cases.
ChangeLog:
2011-09-14 Jiangning Liu <jiangning.liu@arm.com>
* gcc/testsuite/gcc.dg/tree-ssa/predcom-1.c: Explicitly turn on
loop unroll and set max unroll times to 8.
* gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c: Likewise.
* gcc/testsuite/gcc.dg/tree-ssa/predcom-3.c: Likewise.
* gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c: Likewise.
* gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c: Likewise.
Thanks,
-Jiangning
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-1.c
b/gcc/testsuite/gcc.dg/tree-ssa/predcom-1.c
index 16bd5c9..f1e52e5 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-1.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-1.c
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-do run } */
-/* { dg-options "-O2 -fpredictive-commoning -fdump-tree-pcom-details" } */
+/* { dg-options "-O2 -funroll-loops --param max-unroll-times=8
-fpredictive-commoning -fdump-tree-pcom-details" } */
void abort (void);
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
b/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
index 7275f28..27e53ee 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-do run } */
-/* { dg-options "-O2 -fpredictive-commoning -fdump-tree-pcom-details" } */
+/* { dg-options "-O2 -funroll-loops --param max-unroll-times=8
-fpredictive-commoning -fdump-tree-pcom-details" } */
void abort (void);
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-3.c
b/gcc/testsuite/gcc.dg/tree-ssa/predcom-3.c
index d500234..5dfe384 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-3.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O2 -fpredictive-commoning -fdump-tree-pcom-details" } */
+/* { dg-options "-O2 -funroll-loops --param max-unroll-times=8
-fpredictive-commoning -fdump-tree-pcom-details" } */
int a[1000], b[1000];
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
b/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
index 6f06b7f..c29a46a 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-do run } */
-/* { dg-options "-O2 -fpredictive-commoning -fdump-tree-pcom-details" } */
+/* { dg-options "-O2 -funroll-loops --param max-unroll-times=8
-fpredictive-commoning -fdump-tree-pcom-details" } */
/* Test for predictive commoning of expressions, without reassociation. */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
b/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
index 134fc37..29444ab 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
@@ -1,6 +1,6 @@
/* { dg-do compile } */
/* { dg-do run } */
-/* { dg-options "-O2 -fpredictive-commoning -fdump-tree-pcom-details" } */
+/* { dg-options "-O2 -funroll-loops --param max-unroll-times=8
-fpredictive-commoning -fdump-tree-pcom-details" } */
/* Test for predictive commoning of expressions, with reassociation. */
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases
2011-09-21 9:17 [PATCH, testsuite] Add loop unrolling command line options for some test cases Jiangning Liu
@ 2011-09-21 20:28 ` Mike Stump
2011-09-22 6:32 ` Jiangning Liu
[not found] ` <4e7ab83a.ca17440a.69be.54c2SMTPIN_ADDED@mx.google.com>
0 siblings, 2 replies; 6+ messages in thread
From: Mike Stump @ 2011-09-21 20:28 UTC (permalink / raw)
To: Jiangning Liu; +Cc: gcc-patches, ro
On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
> The fix is to explicitly turn on loop unroll and set max-unroll-times to 8,
> which is larger than the unrolling times being detected in the cases.
Sounds reasonable to me. Ok, though, do watch for any comments by people that know more than I.
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH, testsuite] Add loop unrolling command line options for some test cases
2011-09-21 20:28 ` Mike Stump
@ 2011-09-22 6:32 ` Jiangning Liu
[not found] ` <4e7ab83a.ca17440a.69be.54c2SMTPIN_ADDED@mx.google.com>
1 sibling, 0 replies; 6+ messages in thread
From: Jiangning Liu @ 2011-09-22 6:32 UTC (permalink / raw)
To: 'Mike Stump'; +Cc: gcc-patches, ro
Hi Mike,
OK. I will wait 24 more hours. If no objections by then, I will get it
checked into trunk.
Thanks,
-Jiangning
> -----Original Message-----
> From: Mike Stump [mailto:mikestump@comcast.net]
> Sent: Thursday, September 22, 2011 3:10 AM
> To: Jiangning Liu
> Cc: gcc-patches@gcc.gnu.org; ro@CeBiTec.Uni-Bielefeld.DE
> Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
> for some test cases
>
> On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
> > The fix is to explicitly turn on loop unroll and set max-unroll-times
> to 8,
> > which is larger than the unrolling times being detected in the cases.
>
> Sounds reasonable to me. Ok, though, do watch for any comments by
> people that know more than I.
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <4e7ab83a.ca17440a.69be.54c2SMTPIN_ADDED@mx.google.com>]
* Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases
[not found] ` <4e7ab83a.ca17440a.69be.54c2SMTPIN_ADDED@mx.google.com>
@ 2011-09-24 14:00 ` Richard Guenther
2011-09-26 8:51 ` Jiangning Liu
[not found] ` <4e8024ea.51cce30a.63f0.1726SMTPIN_ADDED@mx.google.com>
0 siblings, 2 replies; 6+ messages in thread
From: Richard Guenther @ 2011-09-24 14:00 UTC (permalink / raw)
To: Jiangning Liu; +Cc: Mike Stump, gcc-patches, ro
On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu <jiangning.liu@arm.com> wrote:
> Hi Mike,
>
> OK. I will wait 24 more hours. If no objections by then, I will get it
> checked into trunk.
I don't think you need -funroll-loops though.
> Thanks,
> -Jiangning
>
>> -----Original Message-----
>> From: Mike Stump [mailto:mikestump@comcast.net]
>> Sent: Thursday, September 22, 2011 3:10 AM
>> To: Jiangning Liu
>> Cc: gcc-patches@gcc.gnu.org; ro@CeBiTec.Uni-Bielefeld.DE
>> Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
>> for some test cases
>>
>> On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
>> > The fix is to explicitly turn on loop unroll and set max-unroll-times
>> to 8,
>> > which is larger than the unrolling times being detected in the cases.
>>
>> Sounds reasonable to me. Ok, though, do watch for any comments by
>> people that know more than I.
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH, testsuite] Add loop unrolling command line options for some test cases
2011-09-24 14:00 ` Richard Guenther
@ 2011-09-26 8:51 ` Jiangning Liu
[not found] ` <4e8024ea.51cce30a.63f0.1726SMTPIN_ADDED@mx.google.com>
1 sibling, 0 replies; 6+ messages in thread
From: Jiangning Liu @ 2011-09-26 8:51 UTC (permalink / raw)
To: 'Richard Guenther'; +Cc: Mike Stump, gcc-patches, ro
> -----Original Message-----
> From: Richard Guenther [mailto:richard.guenther@gmail.com]
> Sent: Saturday, September 24, 2011 6:12 PM
> To: Jiangning Liu
> Cc: Mike Stump; gcc-patches@gcc.gnu.org; ro@cebitec.uni-bielefeld.de
> Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
> for some test cases
>
> On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu <jiangning.liu@arm.com>
> wrote:
> > Hi Mike,
> >
> > OK. I will wait 24 more hours. If no objections by then, I will get
> it
> > checked into trunk.
>
> I don't think you need -funroll-loops though.
>
The intention of those test cases are not hurt if -funroll-loops is added,
right?
> > Thanks,
> > -Jiangning
> >
> >> -----Original Message-----
> >> From: Mike Stump [mailto:mikestump@comcast.net]
> >> Sent: Thursday, September 22, 2011 3:10 AM
> >> To: Jiangning Liu
> >> Cc: gcc-patches@gcc.gnu.org; ro@CeBiTec.Uni-Bielefeld.DE
> >> Subject: Re: [PATCH, testsuite] Add loop unrolling command line
> options
> >> for some test cases
> >>
> >> On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
> >> > The fix is to explicitly turn on loop unroll and set max-unroll-
> times
> >> to 8,
> >> > which is larger than the unrolling times being detected in the
> cases.
> >>
> >> Sounds reasonable to me. Ok, though, do watch for any comments by
> >> people that know more than I.
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <4e8024ea.51cce30a.63f0.1726SMTPIN_ADDED@mx.google.com>]
* Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases
[not found] ` <4e8024ea.51cce30a.63f0.1726SMTPIN_ADDED@mx.google.com>
@ 2011-09-26 12:14 ` Richard Guenther
0 siblings, 0 replies; 6+ messages in thread
From: Richard Guenther @ 2011-09-26 12:14 UTC (permalink / raw)
To: Jiangning Liu; +Cc: Mike Stump, gcc-patches, ro
On Mon, Sep 26, 2011 at 9:08 AM, Jiangning Liu <jiangning.liu@arm.com> wrote:
>> -----Original Message-----
>> From: Richard Guenther [mailto:richard.guenther@gmail.com]
>> Sent: Saturday, September 24, 2011 6:12 PM
>> To: Jiangning Liu
>> Cc: Mike Stump; gcc-patches@gcc.gnu.org; ro@cebitec.uni-bielefeld.de
>> Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
>> for some test cases
>>
>> On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu <jiangning.liu@arm.com>
>> wrote:
>> > Hi Mike,
>> >
>> > OK. I will wait 24 more hours. If no objections by then, I will get
>> it
>> > checked into trunk.
>>
>> I don't think you need -funroll-loops though.
>>
>
> The intention of those test cases are not hurt if -funroll-loops is added,
> right?
Right.
>> > Thanks,
>> > -Jiangning
>> >
>> >> -----Original Message-----
>> >> From: Mike Stump [mailto:mikestump@comcast.net]
>> >> Sent: Thursday, September 22, 2011 3:10 AM
>> >> To: Jiangning Liu
>> >> Cc: gcc-patches@gcc.gnu.org; ro@CeBiTec.Uni-Bielefeld.DE
>> >> Subject: Re: [PATCH, testsuite] Add loop unrolling command line
>> options
>> >> for some test cases
>> >>
>> >> On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
>> >> > The fix is to explicitly turn on loop unroll and set max-unroll-
>> times
>> >> to 8,
>> >> > which is larger than the unrolling times being detected in the
>> cases.
>> >>
>> >> Sounds reasonable to me. Ok, though, do watch for any comments by
>> >> people that know more than I.
>> >
>> >
>> >
>> >
>> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-26 10:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-21 9:17 [PATCH, testsuite] Add loop unrolling command line options for some test cases Jiangning Liu
2011-09-21 20:28 ` Mike Stump
2011-09-22 6:32 ` Jiangning Liu
[not found] ` <4e7ab83a.ca17440a.69be.54c2SMTPIN_ADDED@mx.google.com>
2011-09-24 14:00 ` Richard Guenther
2011-09-26 8:51 ` Jiangning Liu
[not found] ` <4e8024ea.51cce30a.63f0.1726SMTPIN_ADDED@mx.google.com>
2011-09-26 12:14 ` Richard Guenther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).