public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Kyrill Tkachov" <kyrylo.tkachov@arm.com>
To: "'Jeff Law'" <law@redhat.com>,
	"Honggyu Kim" <hong.gyu.kim@lge.com>,	<gcc-patches@gcc.gnu.org>
Cc: <segher@kernel.crashing.org>,	<christophe.lyon@st.com>
Subject: RE: [PATCH v2] New testcase to check parameter passing bug
Date: Wed, 25 Mar 2015 14:05:00 -0000	[thread overview]
Message-ID: <000401d06704$c4cd8dc0$4e68a940$@arm.com> (raw)
In-Reply-To: <5512A9B1.1080104@redhat.com>



> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: 25 March 2015 12:27
> To: Honggyu Kim; gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov; segher@kernel.crashing.org; christophe.lyon@st.com
> Subject: Re: [PATCH v2] New testcase to check parameter passing bug
> 
> On 03/18/15 19:40, Honggyu Kim wrote:
> > Hi,
> >
> > I have modified the test-case to check parameter passing bug based on
> > the comments from Kyrill Tkachov, Christophe Lyon, and Segher
> > Boessenkool as follows:
> >   1. move from "gcc.target/arm" to "gcc.dg"
> >   2. change "dg-do compile" to "dg-do run"
> >
> > Please let me know if there's still something to fix more.
> > Thanks for your comment.
> >
> > Honggyu
> > ---
> >   gcc/testsuite/ChangeLog        |    4 ++++
> >   gcc/testsuite/gcc.dg/pr65358.c |   33
> +++++++++++++++++++++++++++++++++
> >   2 files changed, 37 insertions(+)
> >   create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
> >
> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index
> > 77d24a1..218f908 100644
> > --- a/gcc/testsuite/ChangeLog
> > +++ b/gcc/testsuite/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2015-03-19  Honggyu Kim  <hong.gyu.kim@lge.com>
> > +
> > +	* gcc.dg/pr65358.c: New test.
> This should be included as part of Kyrill's patch.  If the test goes in
without
> Kryill's fix, then it'll just create testsuite noise.

I'll make sure to commit this together with my fix (at
https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01014.html)
if it gets approved. I agree that there's no point taking the test in by
itself .

Thanks,
Kyrill

> 
> Jeff
> 



  reply	other threads:[~2015-03-25 14:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  2:08 [PATCH][ARM] " Honggyu Kim
2015-03-13 12:04 ` Kyrill Tkachov
2015-03-13 13:04   ` Christophe Lyon
2015-03-13 14:12   ` Segher Boessenkool
2015-03-16  0:54     ` Honggyu Kim
2015-03-18 11:53       ` Kyrill Tkachov
2015-03-19  1:40         ` [PATCH v2] " Honggyu Kim
2015-03-19  1:58           ` Honggyu Kim
2015-03-25 13:52           ` Jeff Law
2015-03-25 14:05             ` Kyrill Tkachov [this message]
2015-03-29 11:36               ` Honggyu Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000401d06704$c4cd8dc0$4e68a940$@arm.com' \
    --to=kyrylo.tkachov@arm.com \
    --cc=christophe.lyon@st.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hong.gyu.kim@lge.com \
    --cc=law@redhat.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).