> Marcus Shawcroft wrote: > On 1 May 2015 at 12:26, Wilco Dijkstra wrote: > > > > > >> Marcus Shawcroft wrote: > >> On 27 April 2015 at 14:43, Wilco Dijkstra wrote: > >> > >> >> static unsigned int > >> >> -aarch64_min_divisions_for_recip_mul (enum machine_mode mode ATTRIBUTE_UNUSED) > >> >> +aarch64_min_divisions_for_recip_mul (enum machine_mode mode) > >> >> { > >> >> - return 2; > >> >> + if (GET_MODE_UNIT_SIZE (mode) == 4) > >> >> + return aarch64_tune_params->min_div_recip_mul_sf; > >> >> + return aarch64_tune_params->min_div_recip_mul_df; > >> > >> This should be expressed directly as mode == SFmode (or DFmode) rather > >> than the indirect approach of first computing the size first. > > > > Can we never see vector types at this point? > > Fair point, curiously we don't appear to see them, but I see no reason > why we should not. Commit your patch as proposed. > > Cheers /Marcus And this one please. Wilco 2015-05-01 Wilco Dijkstra * gcc/config/aarch64/aarch64-protos.h (tune_params): Add min_div_recip_mul_sf and min_div_recip_mul_df fields. * gcc/config/aarch64/aarch64.c (aarch64_min_divisions_for_recip_mul): Return value depending on target. (generic_tunings): Initialize new target settings. (cortexa53_tunings): Likewise. (cortexa57_tunings): Likewise. (thunderx_tunings): Likewise. (xgene1_tunings): Likewise.