* [4.1/4.2 PATCH]: XFAIL remaining objc++ failures
@ 2008-02-12 7:06 Kaveh R. GHAZI
2008-02-12 17:36 ` Janis Johnson
2008-02-12 21:02 ` Mike Stump
0 siblings, 2 replies; 4+ messages in thread
From: Kaveh R. GHAZI @ 2008-02-12 7:06 UTC (permalink / raw)
To: gcc-patches; +Cc: janis187, mrs
With regards to the objc++ testsuite errors, I've fixed those that I
could, and for all of the remaining ones I've made sure there is a PR with
updated info. Therefore, this patch XFAILs the remaining objc++ testsuite
failures on the 4.1/4.2 branches. (The PR# in each case is noted in the
dg- XFAIL commands below.)
If checking is enabled several more errors occur (also all have PRs).
However I don't know how to XFAIL an error that only appears with checking
turned on without having XPASSes when checking is turned off. I left
those unhandled.
Tested on 4.1 and 4.2 on i686-unknown-linux-gnu and
x86_64-unknown-linux-gnu via "make check-obj-c++". All of the
non-checking FAILs go away. However some of the "run" tests which have
compile problems complain about "compilation failed to produce
executable", either as a WARNING or UNRESOLVED depending I think on the
version of dejagnu. But it's much better than it was.
Okay for 4.1/4.2 branches?
Thanks,
--Kaveh
2008-02-12 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* obj-c++.dg/bitfield-1.mm: Expect failures.
* obj-c++.dg/bitfield-4.mm: Likewise.
* obj-c++.dg/cxx-ivars-2.mm: Likewise.
* obj-c++.dg/encode-8.mm: Likewise.
* obj-c++.dg/isa-field-1.mm: Likewise.
* obj-c++.dg/layout-1.mm: Likewise.
* obj-c++.dg/lookup-2.mm: Likewise.
* obj-c++.dg/try-catch-2.mm: Likewise.
* obj-c++.dg/try-catch-9.mm: Likewise.
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-1.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-1.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-1.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-1.mm 2008-02-12 02:30:40.000000000 +0100
@@ -111,3 +111,13 @@ int main(void)
return 0;
}
+
+/* { dg-bogus "included from <built-in>" "PR23610" { xfail lp64 } 0 } */
+/* { dg-bogus "padding struct to align" "PR23610" { xfail lp64 } 0 } */
+
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 40 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 43 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 57 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 60 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 75 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 76 } */
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-4.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-4.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-4.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/bitfield-4.mm 2008-02-12 02:31:42.000000000 +0100
@@ -48,3 +48,9 @@ int main(void)
return 0;
}
+
+/* { dg-bogus "included from <built-in>" "PR23610" { xfail lp64 } 0 } */
+/* { dg-bogus "padding struct to align" "PR23610" { xfail lp64 } 0 } */
+
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 28 } */
+/* { dg-bogus "padding struct size" "PR23610" { xfail lp64 } 34 } */
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm 2008-02-12 02:09:03.000000000 +0100
@@ -1,7 +1,7 @@
// Check if the '- .cxx_construct' and '-.cxx_destruct' methods get called
// and if they perform their desired function.
-// { dg-do run }
+// { dg-do run { xfail { "*-*-*" } } } PR27247/PR23681
// { dg-options "-fobjc-call-cxx-cdtors" }
#include <objc/Object.h>
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/encode-8.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/encode-8.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/encode-8.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/encode-8.mm 2008-02-12 02:09:42.000000000 +0100
@@ -3,7 +3,7 @@
should be encoded as '*'). */
/* Contributed by Ziemowit Laski <zlaski@apple.com>. */
/* { dg-options "-lobjc" } */
-/* { dg-do run } */
+/* { dg-do run { xfail { "*-*-*" } } } PR27249 */
#include <string.h>
#include <stdlib.h>
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/isa-field-1.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/isa-field-1.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/isa-field-1.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/isa-field-1.mm 2008-02-12 02:10:36.000000000 +0100
@@ -1,5 +1,6 @@
/* Ensure there are no bizarre difficulties with accessing the 'isa' field of objects. */
/* { dg-do compile } */
+/* { dg-xfail-if "PR23613" { "*-*-*" } { "*" } { "" } } */
#include <objc/Object.h>
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/layout-1.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/layout-1.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/layout-1.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/layout-1.mm 2008-02-12 02:32:31.000000000 +0100
@@ -13,3 +13,5 @@
- (id) foo;
@end
+/* { dg-bogus "included from <built-in>" "PR23610" { xfail lp64 } 0 } */
+/* { dg-bogus "padding struct to align" "PR23610" { xfail lp64 } 0 } */
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/lookup-2.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/lookup-2.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/lookup-2.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/lookup-2.mm 2008-02-12 02:45:18.000000000 +0100
@@ -1,4 +1,5 @@
/* { dg-do run } */
+/* { dg-xfail-if "PR23614" { "*-*-*" } { "*" } { "" } } */
#include <objc/Object.h>
#include <stdlib.h>
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-2.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-2.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-2.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-2.mm 2008-02-12 02:41:20.000000000 +0100
@@ -3,6 +3,7 @@
/* Developed by Ziemowit Laski <zlaski@apple.com>. */
/* { dg-options "-fobjc-exceptions" } */
+/* { dg-xfail-if "PR23616" { "*-*-*" } { "*" } { "" } } */
/* { dg-do run } */
#include <objc/Object.h>
diff -rup orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-9.mm egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-9.mm
--- orig/egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-9.mm 2008-01-03 23:36:04.000000000 +0100
+++ egcc-4.1-SVN20080211/gcc/testsuite/obj-c++.dg/try-catch-9.mm 2008-02-12 02:43:22.000000000 +0100
@@ -3,6 +3,7 @@
/* Developed by Ziemowit Laski <zlaski@apple.com>. */
/* { dg-options "-fobjc-exceptions -O2" } */
+/* { dg-xfail-if "PR23616" { "*-*-*" } { "*" } { "" } } */
/* { dg-do run } */
#include <objc/Object.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.1/4.2 PATCH]: XFAIL remaining objc++ failures
2008-02-12 7:06 [4.1/4.2 PATCH]: XFAIL remaining objc++ failures Kaveh R. GHAZI
@ 2008-02-12 17:36 ` Janis Johnson
2008-02-12 21:02 ` Mike Stump
1 sibling, 0 replies; 4+ messages in thread
From: Janis Johnson @ 2008-02-12 17:36 UTC (permalink / raw)
To: Kaveh R. GHAZI; +Cc: gcc-patches, mrs
On Tue, 2008-02-12 at 01:59 -0500, Kaveh R. GHAZI wrote:
> Okay for 4.1/4.2 branches?
> 2008-02-12 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * obj-c++.dg/bitfield-1.mm: Expect failures.
> * obj-c++.dg/bitfield-4.mm: Likewise.
> * obj-c++.dg/cxx-ivars-2.mm: Likewise.
> * obj-c++.dg/encode-8.mm: Likewise.
> * obj-c++.dg/isa-field-1.mm: Likewise.
> * obj-c++.dg/layout-1.mm: Likewise.
> * obj-c++.dg/lookup-2.mm: Likewise.
> * obj-c++.dg/try-catch-2.mm: Likewise.
> * obj-c++.dg/try-catch-9.mm: Likewise.
OK. Thanks for cleaning these up.
Janis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.1/4.2 PATCH]: XFAIL remaining objc++ failures
2008-02-12 7:06 [4.1/4.2 PATCH]: XFAIL remaining objc++ failures Kaveh R. GHAZI
2008-02-12 17:36 ` Janis Johnson
@ 2008-02-12 21:02 ` Mike Stump
2008-02-13 7:08 ` Kaveh R. Ghazi
1 sibling, 1 reply; 4+ messages in thread
From: Mike Stump @ 2008-02-12 21:02 UTC (permalink / raw)
To: Kaveh R. GHAZI; +Cc: gcc-patches, janis187
On Feb 11, 2008, at 10:59 PM, Kaveh R. GHAZI wrote:
> If checking is enabled several more errors occur (also all have PRs).
> However I don't know how to XFAIL an error that only appears with
> checking
> turned on without having XPASSes when checking is turned off. I left
> those unhandled.
Technically you can run a testcase that passes with checking off and
then see it is fails or not. If it does, set checking_enabled and
then conditionalize the expectation for those testcases on
checking_enabled.
And thanks for all your hard work on this. I wish all the testsuites
were clean by the time we released, every release, for at least 4 or 5
different platforms.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.1/4.2 PATCH]: XFAIL remaining objc++ failures
2008-02-12 21:02 ` Mike Stump
@ 2008-02-13 7:08 ` Kaveh R. Ghazi
0 siblings, 0 replies; 4+ messages in thread
From: Kaveh R. Ghazi @ 2008-02-13 7:08 UTC (permalink / raw)
To: Mike Stump; +Cc: gcc-patches, janis187
From: "Mike Stump" <mrs@apple.com>
> And thanks for all your hard work on this.
You're welcome!
> I wish all the testsuites were clean by the time we released, every
> release, for at least 4 or 5 different platforms.
Me too, I'm getting pretty close on x86-linux-gnu. But I guess being the
most popular, that's the easiest.
--Kaveh
--
Kaveh R. Ghazi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-13 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-12 7:06 [4.1/4.2 PATCH]: XFAIL remaining objc++ failures Kaveh R. GHAZI
2008-02-12 17:36 ` Janis Johnson
2008-02-12 21:02 ` Mike Stump
2008-02-13 7:08 ` Kaveh R. Ghazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).