* [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target
@ 2014-09-04 2:21 Tony Wang
2014-09-09 9:34 ` Ramana Radhakrishnan
0 siblings, 1 reply; 2+ messages in thread
From: Tony Wang @ 2014-09-04 2:21 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Earnshaw, Ramana Radhakrishnan
Hi there,
This is a test case clean up patch, because orr/eor instruction for thumb1 has only two variant:
ORRS <Rdn>, <Rm>
ORR<c> <Rdn>, <Rm>
No <shift> is available for thumb1 encoding, so test case xordi3-opt.c/iordi3-opt.c is invalid for thumb1
target. This patch just disabled them for thumb1 target.
Ok for the trunk?
gcc/gcc/testsuite/ChangeLog:
2014-09-04 Tony Wang <tony.wang@arm.com>
* gcc.target/arm/xordi3-opt.c: Disable this
test case for thumb1 target.
* gcc.target/arm/iordi3-opt.c: Ditto.
diff --git a/gcc/testsuite/gcc.target/arm/iordi3-opt.c b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
index b3f465b..63fbe0b 100644
--- a/gcc/testsuite/gcc.target/arm/iordi3-opt.c
+++ b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
/* { dg-options "-O1" } */
unsigned long long or64 (unsigned long long input)
diff --git a/gcc/testsuite/gcc.target/arm/xordi3-opt.c b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
index 7e031c3..53b2bab 100644
--- a/gcc/testsuite/gcc.target/arm/xordi3-opt.c
+++ b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
/* { dg-options "-O1" } */
unsigned long long xor64 (unsigned long long input)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target
2014-09-04 2:21 [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target Tony Wang
@ 2014-09-09 9:34 ` Ramana Radhakrishnan
0 siblings, 0 replies; 2+ messages in thread
From: Ramana Radhakrishnan @ 2014-09-09 9:34 UTC (permalink / raw)
To: Tony Wang; +Cc: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan
On Thu, Sep 4, 2014 at 3:21 AM, Tony Wang <tony.wang@arm.com> wrote:
> Hi there,
>
> This is a test case clean up patch, because orr/eor instruction for thumb1 has only two variant:
>
> ORRS <Rdn>, <Rm>
> ORR<c> <Rdn>, <Rm>
> No <shift> is available for thumb1 encoding, so test case xordi3-opt.c/iordi3-opt.c is invalid for thumb1
> target. This patch just disabled them for thumb1 target.
>
> Ok for the trunk?
Ok (assuming you've tested this on suitable multilib variants :))
Ramana
>
> gcc/gcc/testsuite/ChangeLog:
> 2014-09-04 Tony Wang <tony.wang@arm.com>
>
> * gcc.target/arm/xordi3-opt.c: Disable this
> test case for thumb1 target.
> * gcc.target/arm/iordi3-opt.c: Ditto.
>
> diff --git a/gcc/testsuite/gcc.target/arm/iordi3-opt.c b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> index b3f465b..63fbe0b 100644
> --- a/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> +++ b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
> /* { dg-options "-O1" } */
>
> unsigned long long or64 (unsigned long long input)
> diff --git a/gcc/testsuite/gcc.target/arm/xordi3-opt.c b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> index 7e031c3..53b2bab 100644
> --- a/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> +++ b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
> /* { dg-options "-O1" } */
>
> unsigned long long xor64 (unsigned long long input)
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-09 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-04 2:21 [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target Tony Wang
2014-09-09 9:34 ` Ramana Radhakrishnan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).