From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19812 invoked by alias); 21 Aug 2014 06:14:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19724 invoked by uid 89); 21 Aug 2014 06:14:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Aug 2014 06:14:45 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 21 Aug 2014 07:14:43 +0100 Received: from shawin188 ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 21 Aug 2014 07:14:42 +0100 From: "Tony Wang" To: Subject: [PATCH 3/3,ARM,libgcc]Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc Date: Thu, 21 Aug 2014 06:14:00 -0000 Message-ID: <000801cfbd07$327801a0$976804e0$@arm.com> MIME-Version: 1.0 X-MC-Unique: 114082107144300201 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0009_01CFBD4A.409C2C00" X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg02084.txt.bz2 This is a multipart message in MIME format. ------=_NextPart_000_0009_01CFBD4A.409C2C00 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-length: 3601 Step 3: Test cases to verify the code size reduction. gcc/gcc/testsuite/ChangeLog: 2014-08-21 Tony Wang * gcc.target/arm/size-optimization-ieee-1.c: New test case * gcc.target/arm/size-optimization-ieee-2.c: New test case * lib/gcc-dg.exp: Add new function scan-symbol-common, scan-symbol-= yes,=20 scan-symbol-no to scan a user defined symbol in final elf file BR, Tony diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c new file mode 100644 index 0000000..46e9cdf --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c @@ -0,0 +1,30 @@ +/* { dg-do link { target { arm_thumb2_ok } } } */ +/* { dg-options "-Wl,--gc-sections" } */ +int +foo () +{ + volatile float a; + volatile float b; + volatile float c =3D a * b; + return 0; +} + +int +bar () +{ + volatile double a; + volatile double b; + volatile double c =3D a * b; + return 0; +} + +int +main () +{ + foo (); + bar (); + return 0; +} +/* { dg-final { scan-symbol-no "__aeabi_fdiv" } } */ +/* { dg-final { scan-symbol-no "__aeabi_ddiv" } } */ + diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c new file mode 100644 index 0000000..5007d62 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c @@ -0,0 +1,30 @@ +/* { dg-do link { target { arm_thumb2_ok } } } */ +/* { dg-options "-Wl,--gc-sections" } */ +int +foo () +{ + volatile float a; + volatile float b; + volatile float c =3D a / b; + return 0; +} + +int +bar () +{ + volatile double a; + volatile double b; + volatile double c =3D a / b; + return 0; +} + +int +main () +{ + foo (); + bar (); + return 0; +} +/* { dg-final { scan-symbol-yes "__aeabi_fmul" } } */ +/* { dg-final { scan-symbol-yes "__aeabi_dmul" } } */ + diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp index 3390caa..0d52e95 100644 --- a/gcc/testsuite/lib/gcc-dg.exp +++ b/gcc/testsuite/lib/gcc-dg.exp @@ -880,5 +880,57 @@ proc gdb-exists { args } { return 0; } =20 +# Scan the OUTPUT_FILE for a symbol. Return 1 if it present, or +# return 0 if it doesn't present + +proc scan-symbol-common { args } { + global nm + global base_dir + + set testcase [testname-for-summary] + set output_file "[file rootname [file tail $testcase]].exe" + + # Find nm like we find g++ in g++.exp. + if ![info exists nm] { + set nm [findfile $base_dir/../../../binutils/nm \ + $base_dir/../../../binutils/nm \ + [findfile $base_dir/../../nm $base_dir/../../nm \ + [findfile $base_dir/nm $base_dir/nm \ + [transform nm]]]] + verbose -log "nm is $nm" + } + + if { $output_file =3D=3D "" } { + fail "scan-symbol-not $args: dump file does not exist" + return + } + + set fd [open "| $nm $output_file" r] + set text [read $fd] + close $fd + + if [regexp -- [lindex $args 0] $text] { + return 1 + } else { + return 0 + } +} + +proc scan-symbol-yes { args } { + if { [scan-symbol-common $args] =3D=3D 1 } { + pass "scan-symbol-yes $args exists" + } else { + fail "scan-symbol-yes $args does not exist" + } +} + +proc scan-symbol-no { args } { + if { [scan-symbol-common $args] !=3D 1 } { + pass "scan-symbol-no $args does not exist" + } else { + fail "scan-symbol-no $args exists" + } +} + set additional_prunes "" set dg_runtest_extra_prunes ""= ------=_NextPart_000_0009_01CFBD4A.409C2C00 Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="libgcc_mul_div_code_size_reduction_3.diff" Content-Disposition: attachment; filename="libgcc_mul_div_code_size_reduction_3.diff" Content-length: 4275 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vc2l6 ZS1vcHRpbWl6YXRpb24taWVlZS0xLmMgYi9nY2MvdGVzdHN1aXRlL2djYy50 YXJnZXQvYXJtL3NpemUtb3B0aW1pemF0aW9uLWllZWUtMS5jCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjQ2ZTljZGYKLS0tIC9kZXYv bnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYXJtL3NpemUt b3B0aW1pemF0aW9uLWllZWUtMS5jCkBAIC0wLDAgKzEsMzAgQEAKKy8qIHsg ZGctZG8gbGluayB7IHRhcmdldCB7IGFybV90aHVtYjJfb2sgfSB9IH0gKi8K Ky8qIHsgZGctb3B0aW9ucyAiLVdsLC0tZ2Mtc2VjdGlvbnMiIH0gKi8KK2lu dAorZm9vICgpCit7CisgIHZvbGF0aWxlIGZsb2F0IGE7CisgIHZvbGF0aWxl IGZsb2F0IGI7CisgIHZvbGF0aWxlIGZsb2F0IGMgPSBhICogYjsKKyAgcmV0 dXJuIDA7Cit9CisKK2ludAorYmFyICgpCit7CisgIHZvbGF0aWxlIGRvdWJs ZSBhOworICB2b2xhdGlsZSBkb3VibGUgYjsKKyAgdm9sYXRpbGUgZG91Ymxl IGMgPSBhICogYjsKKyAgcmV0dXJuIDA7Cit9CisKK2ludAorbWFpbiAoKQor eworICBmb28gKCk7CisgIGJhciAoKTsKKyAgcmV0dXJuIDA7Cit9CisvKiB7 IGRnLWZpbmFsIHsgc2Nhbi1zeW1ib2wtbm8gIl9fYWVhYmlfZmRpdiIgfSB9 ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1zeW1ib2wtbm8gIl9fYWVhYmlf ZGRpdiIgfSB9ICovCisKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2Nj LnRhcmdldC9hcm0vc2l6ZS1vcHRpbWl6YXRpb24taWVlZS0yLmMgYi9nY2Mv dGVzdHN1aXRlL2djYy50YXJnZXQvYXJtL3NpemUtb3B0aW1pemF0aW9uLWll ZWUtMi5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUw MDdkNjIKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy50 YXJnZXQvYXJtL3NpemUtb3B0aW1pemF0aW9uLWllZWUtMi5jCkBAIC0wLDAg KzEsMzAgQEAKKy8qIHsgZGctZG8gbGluayB7IHRhcmdldCB7IGFybV90aHVt YjJfb2sgfSB9IH0gKi8KKy8qIHsgZGctb3B0aW9ucyAiLVdsLC0tZ2Mtc2Vj dGlvbnMiIH0gKi8KK2ludAorZm9vICgpCit7CisgIHZvbGF0aWxlIGZsb2F0 IGE7CisgIHZvbGF0aWxlIGZsb2F0IGI7CisgIHZvbGF0aWxlIGZsb2F0IGMg PSBhIC8gYjsKKyAgcmV0dXJuIDA7Cit9CisKK2ludAorYmFyICgpCit7Cisg IHZvbGF0aWxlIGRvdWJsZSBhOworICB2b2xhdGlsZSBkb3VibGUgYjsKKyAg dm9sYXRpbGUgZG91YmxlIGMgPSBhIC8gYjsKKyAgcmV0dXJuIDA7Cit9CisK K2ludAorbWFpbiAoKQoreworICBmb28gKCk7CisgIGJhciAoKTsKKyAgcmV0 dXJuIDA7Cit9CisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1zeW1ib2wteWVzICJf X2FlYWJpX2ZtdWwiIH0gfSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tc3lt Ym9sLXllcyAiX19hZWFiaV9kbXVsIiB9IH0gKi8KKwpkaWZmIC0tZ2l0IGEv Z2NjL3Rlc3RzdWl0ZS9saWIvZ2NjLWRnLmV4cCBiL2djYy90ZXN0c3VpdGUv bGliL2djYy1kZy5leHAKaW5kZXggMzM5MGNhYS4uMGQ1MmU5NSAxMDA2NDQK LS0tIGEvZ2NjL3Rlc3RzdWl0ZS9saWIvZ2NjLWRnLmV4cAorKysgYi9nY2Mv dGVzdHN1aXRlL2xpYi9nY2MtZGcuZXhwCkBAIC04ODAsNSArODgwLDU3IEBA IHByb2MgZ2RiLWV4aXN0cyB7IGFyZ3MgfSB7CiAgICAgcmV0dXJuIDA7CiB9 CiAKKyMgU2NhbiB0aGUgT1VUUFVUX0ZJTEUgZm9yIGEgc3ltYm9sLiBSZXR1 cm4gMSBpZiBpdCBwcmVzZW50LCBvcgorIyByZXR1cm4gMCBpZiBpdCBkb2Vz bid0IHByZXNlbnQKKworcHJvYyBzY2FuLXN5bWJvbC1jb21tb24geyBhcmdz IH0geworICAgIGdsb2JhbCBubQorICAgIGdsb2JhbCBiYXNlX2RpcgorCisg ICAgc2V0IHRlc3RjYXNlIFt0ZXN0bmFtZS1mb3Itc3VtbWFyeV0KKyAgICBz ZXQgb3V0cHV0X2ZpbGUgIltmaWxlIHJvb3RuYW1lIFtmaWxlIHRhaWwgJHRl c3RjYXNlXV0uZXhlIgorCisgICAgIyBGaW5kIG5tIGxpa2Ugd2UgZmluZCBn KysgaW4gZysrLmV4cC4KKyAgICBpZiAhW2luZm8gZXhpc3RzIG5tXSAgewor ICAgICAgICBzZXQgbm0gW2ZpbmRmaWxlICRiYXNlX2Rpci8uLi8uLi8uLi9i aW51dGlscy9ubSBcCisgICAgICAgICAgICAgICAgJGJhc2VfZGlyLy4uLy4u Ly4uL2JpbnV0aWxzL25tIFwKKyAgICAgICAgICAgICAgICBbZmluZGZpbGUg JGJhc2VfZGlyLy4uLy4uL25tICRiYXNlX2Rpci8uLi8uLi9ubSBcCisgICAg ICAgICAgICAgICAgICAgICAgW2ZpbmRmaWxlICRiYXNlX2Rpci9ubSAkYmFz ZV9kaXIvbm0gXAorICAgICAgICAgICAgICAgICAgICAgICBbdHJhbnNmb3Jt IG5tXV1dXQorICAgICAgICB2ZXJib3NlIC1sb2cgIm5tIGlzICRubSIKKyAg ICB9CisKKyAgICBpZiB7ICRvdXRwdXRfZmlsZSA9PSAiIiB9IHsKKyAgICAg ICAgZmFpbCAic2Nhbi1zeW1ib2wtbm90ICRhcmdzOiBkdW1wIGZpbGUgZG9l cyBub3QgZXhpc3QiCisgICAgICAgIHJldHVybgorICAgIH0KKworICAgIHNl dCBmZCBbb3BlbiAifCAkbm0gJG91dHB1dF9maWxlIiByXQorICAgIHNldCB0 ZXh0IFtyZWFkICRmZF0KKyAgICBjbG9zZSAkZmQKKworICAgIGlmIFtyZWdl eHAgLS0gW2xpbmRleCAkYXJncyAwXSAkdGV4dF0geworICAgICAgICByZXR1 cm4gMQorICAgIH0gZWxzZSB7CisgICAgICAgIHJldHVybiAwCisgICAgfQor fQorCitwcm9jIHNjYW4tc3ltYm9sLXllcyB7IGFyZ3MgfSB7CisgICAgaWYg eyBbc2Nhbi1zeW1ib2wtY29tbW9uICRhcmdzXSA9PSAxIH0geworCXBhc3Mg InNjYW4tc3ltYm9sLXllcyAkYXJncyBleGlzdHMiCisgICAgfSBlbHNlIHsK KwlmYWlsICJzY2FuLXN5bWJvbC15ZXMgJGFyZ3MgZG9lcyBub3QgZXhpc3Qi CisgICAgfQorfQorCitwcm9jIHNjYW4tc3ltYm9sLW5vIHsgYXJncyB9IHsK KyAgICBpZiB7IFtzY2FuLXN5bWJvbC1jb21tb24gJGFyZ3NdICE9IDEgfSB7 CisgICAgICAgIHBhc3MgInNjYW4tc3ltYm9sLW5vICRhcmdzIGRvZXMgbm90 IGV4aXN0IgorICAgIH0gZWxzZSB7CisgICAgICAgIGZhaWwgInNjYW4tc3lt Ym9sLW5vICRhcmdzIGV4aXN0cyIKKyAgICB9Cit9CisKIHNldCBhZGRpdGlv bmFsX3BydW5lcyAiIgogc2V0IGRnX3J1bnRlc3RfZXh0cmFfcHJ1bmVzICIi Cg== ------=_NextPart_000_0009_01CFBD4A.409C2C00--