From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 7551C3858C66 for ; Mon, 27 Mar 2023 13:32:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7551C3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32RDUHJI008991; Mon, 27 Mar 2023 13:32:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=UA1mkRRIYYhC4KSwl77SnhhcxssOnYB2gg4Cqcml7og=; b=jLMtrIbdUfSjoo63EERjpJ0mdPqn6sNp4P2SWLAjmhpSpbwiV5hD3OGoXLzp5WXXqdaW GnIQfNjJeChGNhiLr/ZDQpq9c/sD2ImDqM1xFMx/jFxCy62b5Yh1u9j+MEBAW7Spjacz 3LnzvklpaD8aTClk7QB17PZv9iCH7XxdIymB74rEHJT9Eer/3T86aefc+A5HqgfhQ5PM 2f1DQNg3tLF8tZHsVe2QHOXTnOyc2pF1U572GWij2xBw45IY6pcvtWVSmou2o5Vt7ACz zst+UMS7+9yd9dkCcw3oV+G1LFtJnNkZ+NiSEInf20UPevxje2XB5aHFQcYRJ/egeReB VA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pkc3000ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Mar 2023 13:32:02 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32RCfpno020372; Mon, 27 Mar 2023 13:32:02 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3phqd50pkn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Mar 2023 13:32:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDzA4Tkrgp5BTvHMX3ghswsItD8h6rZd5VvKvg0cjKs/72oSRaD/iNPfsqCoDDtgrOZcUGhdCGSe6/6eA2HEvtZDfUSADR7/tx4u1/m/Pizdeb1nFklzEGWM38zz/RmD1veo1L8KzRIV84WIRN/DI65Jvkj0rwluuEAWhpSSfSp6J14gnNaReZy247CCeBnpJTeqnh0yew6Mh9IFefirszXAszOrwFHJZ35EpE09AoVf+G7obGXlA57g8OGatQFYCVxiXv4wd2XiZgMKaSaXhkedXzfWh1inkS6Mq5FaZrtMMZ/6oZ/arYXxgsGqMdpsTwvr4ZJcQr3vHkYSgs5srA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UA1mkRRIYYhC4KSwl77SnhhcxssOnYB2gg4Cqcml7og=; b=Jki2buFpv6YpwPCPCm+sMdyDoMq9Y7+5hkX5ByguiAfJttCodhwIXibYaxqHAhk2oxdS4KxtD1VPhC7JeFhSea7bse6gnt+TcinFM71I732is9L3aD5nzJ0CJZBYTJm7MPsjeXpwvXlHpj2Zsy0DrLTu4W9dZdiTdF2TCir72YPejJNnRtlDwhIh1axR+CmzEFELITrERtulk0ISbl0J+VtJF9BbelNrkEo9QDDhiHCUxfHLgP0DU3hi9BsD1vV0cYBa/qT4tvxUR6pLJkoa2Ewzzw+lVt+ztuwGJueDrlceMNFHm/pB8McMrXIhRrLlNeTLz9T2PfMqNLKAv/ArGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UA1mkRRIYYhC4KSwl77SnhhcxssOnYB2gg4Cqcml7og=; b=U+AfNErcfnmERp3+7/RHZfB8v2CL4auQacj14LXxZVXX+4GfJjAUbxrc9UWVXMZSDCfIBM+gekwHh76/v2Q4YL54IC4Xnp/63wFmuTWYek3r6Vqz56X4yasym6ga+2UD7yxkWyQ9NbQEzn3XNLNS7bU9Hu96idiJ3Cqwb3scfFQ= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by SJ2PR10MB7037.namprd10.prod.outlook.com (2603:10b6:a03:4c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.41; Mon, 27 Mar 2023 13:31:59 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7030:ed2e:20d0:cd5b]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7030:ed2e:20d0:cd5b%9]) with mapi id 15.20.6178.041; Mon, 27 Mar 2023 13:31:59 +0000 From: Qing Zhao To: Joseph Myers CC: Jakub Jelinek , "Sandra@codesourcery.com" , Siddhesh Poyarekar , Richard Biener , Kees Cook , gcc Patches Subject: Re: [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Thread-Topic: [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Thread-Index: AQHZYLCBmX1Yy8capUClrLtOhyR8NQ== Date: Mon, 27 Mar 2023 13:31:59 +0000 Message-ID: <000C1AC3-F7D7-4042-9573-65AAE2456197@oracle.com> References: <20230316214715.604671-2-qing.zhao@oracle.com> <95180085-897F-4B87-BE0E-78ACF1808326@oracle.com> <7798934b-7182-eda8-604d-3a56f517b98a@codesourcery.com> In-Reply-To: <7798934b-7182-eda8-604d-3a56f517b98a@codesourcery.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.2) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|SJ2PR10MB7037:EE_ x-ms-office365-filtering-correlation-id: c5880acc-d77a-4ce2-b4ab-08db2ec7a46c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +XczXWQGbxGRZMRkujicZt9lUktAcpN1/kO4mjxQPWaVeA0SFL3Rvsn49o6sX0ExIcsl25EloZqbxSqNMsYCin4DNqPyNacN5+BnROTYokuGmF6/RwSPZcSxfgZDhtcK4eK19AQAvXfQipLEvYuBHc3UqHdiy+A9KS/93BjlYKijWTQ/mCO4JQhGiN5vXhqz9M/DJNii06e9vJ3L9upV7XvG1JaPXMokqvq5jJDLj9ugGGbJNZ41HeACZ5qqsCTb96dJ3kXBM5mGaDuw4WJITGgJUYj2l6NInBQsuJ7KjfRAEUPZQGWrJwE382lfr/8uQe8ZbXtB0uAj2Q06tT3cqaC47jmfTLEhOgq/4wpEoPY1V4UEIidG7LfEnAjq9EPVHCfDHr9/nNacy/QI2IPAbmn5hxmKHV8ypNYkoZpkynXq8t8GAQxx0dIgD0iWm7s00BKBo/GNKLoICwVYfcKB5qsjv09VV80hkwPd81Y8fPF+BTtSZJlKZ8hH0OCFFgg9A06GToY903MHjOLwBHigobKKBPFX2yIv1H0hyu5Fc/++QBVI4SPzM8RRuje1Rgb8oAs88djiprYogCrLfjJKF3iR+W6i2TIrIdsCITLIKuv5vn5AQZCIdMcmM1v8V7QjeoaTErcvLM1m8TOEXVWt7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199021)(36756003)(478600001)(54906003)(186003)(316002)(53546011)(64756008)(66446008)(8676002)(66556008)(66476007)(4326008)(76116006)(66946007)(33656002)(41300700001)(38100700002)(6512007)(71200400001)(2906002)(44832011)(8936002)(6506007)(122000001)(5660300002)(6916009)(38070700005)(2616005)(91956017)(86362001)(6486002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h9MZ+IM4L5E7XfuE9UmANJ8TfxDX2ePpm8dj/qz+ovg5Ype52rasSvsW2PXJ?= =?us-ascii?Q?x83QU72fbFreH9eaqOo6tahytO0xwzL+qbhDDSiN8K+8GZ9fjU5dayURwjOw?= =?us-ascii?Q?mErcp+TRIzK2z+belwUG/66c0lOtmHkV2loOM/uOZhvky8jNzLPtXOrLoEKz?= =?us-ascii?Q?mmgs4QWYbRbxGnKWFfEoF09LxbqkkG70sHBu1Obg0n0NprJx5zkhNLbIbPwa?= =?us-ascii?Q?YTR5Bw1sWMGarxRUmoElbTmQHrNqba9fWLOWUzA4DcsPNYZ30TeUbNAJHiFe?= =?us-ascii?Q?9HlNQDq8SI06BaTQBuyUDigJXW4tRHqY5SNgIPeuW0eIHn0XiI0FQMSQjtH0?= =?us-ascii?Q?lC7RxW12xJc/CxlRMBJ9xPQPaq3vjN7Zv1cltNlxSBIqjaWM5SiomDfKatHw?= =?us-ascii?Q?d2iGre8RWWL2myP30EJK41quVHmF6104ZrVZGJJ3iQSdwJx3DP9lCUh57lTd?= =?us-ascii?Q?FlvKwX2g/nk11b+lRq/tD8U+1sHmfnS3vnbWsQEReHky8cnIkyiuqBIRbHYl?= =?us-ascii?Q?jAUqsqvA+MzKwwstRB7wVrd4FR71aG+/2S7/39TzN5iawOzhH1Nfkb4yWebm?= =?us-ascii?Q?YV8atXQ173cT+r/hz9oQyZyqBPSNmm7k4kadnQspY8Qn7y/32wbuHhpkaZy3?= =?us-ascii?Q?0hfcOhDAZQaFm4aIxFNCp5NHRs9z5bbF/fZF4J6PRICW/RL0gGvKiB093EeF?= =?us-ascii?Q?04dSx+6NlP77Qj1zslvjBQhLhXgYs9vgIUlnxn42Ic4hbsE4jFQu+v3I0hSm?= =?us-ascii?Q?hfhAaFvRB/5kX/+WnmixO7sE4uCU2PL69nuz4dNafaEi5BMYKUANIkWY7YuY?= =?us-ascii?Q?hzT29EhjqgfKB1GHLGdmViupq0foS6/yiR+8bVsXKjOLA2OHyP4h4pIw+Ppe?= =?us-ascii?Q?7t3UIkfzZ2R3l/6xOe2leW7sQUr+UDdeY7Z9UowCniYfh3knZTbrGNrKzXzy?= =?us-ascii?Q?RbrOD6OddCjv86LyZEtAM7Dr1baUku9VyaQ/5ek1TTPilcmVqN0Sx+lCmSj6?= =?us-ascii?Q?6t7WiLleBOctddsHhulWKed2yFDidgtE2LGvGLIKpoJGG/n0t//LdA31hn1v?= =?us-ascii?Q?tbgPXHyGjKtVzeHD4npCMWf0g2khW+BIPSf1sf41g95CBRby5RJS+7vKodCy?= =?us-ascii?Q?tTEjR6ieXPjpJCP98r4qY1WsCxartRVQLXKXBf6ccySF68XHTfuiCKUMZDnw?= =?us-ascii?Q?taKTZPw6qM5HJYKKDULcHOZAzoLNF41Vq3j6I0CG8pTsvCB12m+D3szsVsd+?= =?us-ascii?Q?bVqQNT4enazFCJa02fTXX8isnWaiF2GiIx3cnT8Aoi+ys4a5uuy8fASDimZf?= =?us-ascii?Q?5eKITNEbfDcystV94WZxxvOpkdCbsMR6iQmkAJL+hsNKYDnakip2MtSDL/KA?= =?us-ascii?Q?uOO1Wo0YvB6kMKASZ+jSCeELv42iB2dljH3smPHSibF2MAAMdHA7r+djXC+E?= =?us-ascii?Q?NF+2ev/oHNEMQZ53G9YrFK8c0gSxVJf/ZK1vDnEqrCfuBy1X7dmWPP1Y1WV0?= =?us-ascii?Q?MHSNaL5Tyjm0G9XfbX/ZNFSA+tQ8TOAoVHlciUpx4JkzR5Zmf+rcnRe/UjK0?= =?us-ascii?Q?Qkt83kRdGc/L+m6xDvkIGrP+vFDiOb2DYgVSRQeB0/T0dT5EWIjoUftTDbP3?= =?us-ascii?Q?1WrA/FOSOf6lVmi5oXKsqss=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <76E0856CD9876C46898AF396F79EACE1@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /ONIS/m0sjd7OGaCpuhS+RFMllqokwV15ebdn8IaDFKOx+D5wVTNSBEfXWNS+k3ClRBxc12jAGOatQd1NBM4JIlTAYL0mA3h8dZXyVnydn1xB9RECXd1ECQQT/H6Kn1+Vz/vqjpTAtgdas3vJWB6GNNiCUUrEq0sxEQPMFb30vjYA5gi8pfhp0c2H+1NX5YZT0RvVfAA6uskQoS8wnWpwg77OLeazrKxxbWDRlAryEd5menaEeRfQyTu63NIIBnn/Fq6Mmn2N1n8DDQbRg0TSEFtaQ/ahBaFG9pQUJnEc9lM5ahGpeNuPD6Pr5nDJ6AY+xVMSfaYruu0vQEIK1/VJm867YxixtzkYBLDOnsYymSxzcCKYU34I757NgaMrKmB+nWKE4jN/E6Kz6T5ctCOF/L2c7yJRXB3675SyRfoG0YDRalMEIl/428DFaD/fP0zQjepwKUbkEkUgUP5s7h9dPeAdI5FUEEFQJ5fhwcI+Tec+77uLk1gRQW+IjlsZwKcptwewhj2Lrnf3wrVyoATbel7TF2KAmhzBcK87N+DucL7JdJYhSI/8zKx8OgcutnNAwchVmupE8rvFuWRzELo3J7iFwmyMOhRY4fdp5dTdsg8sapJ+/eAdDmqMd6z6X0PtQKf0NrPSJW2pID9zagIWhtuSeeVAXbk1RVpBWNAvuj57h8RRxf5c9orb69Y9xGIEOAoZwjCpcx0BuW+iIEnVnqUzXRQZ2zWJEGzSx7JncdfvMF8wvHQAJtn6unagR17PWUj5BtEZHYoYATo66FYKVyLbgwh49Rdydye06PDPvx5NdsXUQO7cqJOpfPYavwcfN4mL6PLnPmKZKklxEQB7l4rAKwUebmwJBtmoY93xGYPbidZtgOcvzhAWp/8/rJxHsqYDXFuAmrMcqvcG213WPCOo7pE38QtfT9xoCKWpxI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5880acc-d77a-4ce2-b4ab-08db2ec7a46c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2023 13:31:59.4389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cQ83HwWi3T5tM8Iz5RKysNjvB658+Qug8ZaTiIVnRnxGLnoYrTqQwDLN8CiW0wORGPjGo+gE/lsBlgT7/J81aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7037 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303270106 X-Proofpoint-ORIG-GUID: TuawSbpxcvB008UkDYO4-0QMMcBa4ogv X-Proofpoint-GUID: TuawSbpxcvB008UkDYO4-0QMMcBa4ogv X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Mar 23, 2023, at 2:55 PM, Joseph Myers wrote= : >=20 > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: >=20 >> gcc/c/ChangeLog: >>=20 >> PR tree-optimization/101832 >> * c-decl.cc (finish_struct): Set TYPE_INCLUDE_FLEXARRA= Y for >> struct/union type. >=20 > The C front-end changes are OK (supposing the original patch has correct= =20 > whitespace, since it seems to be messed up here). Thanks for your review. I just double checked the change in gcc/c/c-decl.cc, looks like the whitesp= aces are good: diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc index e537d33f398..14c54809b9d 100644 --- a/gcc/c/c-decl.cc +++ b/gcc/c/c-decl.cc @@ -9258,6 +9258,17 @@ finish_struct (location_t loc, tree t, tree fieldlis= t, tree attributes, /* Set DECL_NOT_FLEXARRAY flag for FIELD_DECL x. */ DECL_NOT_FLEXARRAY (x) =3D !is_flexible_array_member_p (is_last_fiel= d, x); =20 + /* Set TYPE_INCLUDE_FLEXARRAY for the context of x, t. + when x is an array and is the last field. */ + if (TREE_CODE (TREE_TYPE (x)) =3D=3D ARRAY_TYPE) + TYPE_INCLUDE_FLEXARRAY (t) + =3D is_last_field && flexible_array_member_type_p (TREE_TYPE (x)); + /* Recursively set TYPE_INCLUDE_FLEXARRAY for the context of x, t + when x is an union or record and is the last field. */ + else if (RECORD_OR_UNION_TYPE_P (TREE_TYPE (x))) + TYPE_INCLUDE_FLEXARRAY (t) + =3D is_last_field && TYPE_INCLUDE_FLEXARRAY (TREE_TYPE (x)); + if (DECL_NAME (x) || RECORD_OR_UNION_TYPE_P (TREE_TYPE (x))) saw_named_field =3D true; I guess that the git send-mail might mess up them. -:). Qing >=20 > --=20 > Joseph S. Myers > joseph@codesourcery.com