From: "Terry Guo" <terry.guo@arm.com>
To: "'Jakub Jelinek'" <jakub@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>, <ro@CeBiTec.Uni-Bielefeld.DE>,
<mikestump@comcast.net>
Subject: RE: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.
Date: Thu, 01 Sep 2011 07:46:00 -0000 [thread overview]
Message-ID: <000c01cc6879$fb1a7b50$f14f71f0$@guo@arm.com> (raw)
In-Reply-To: <20110901072314.GP2687@tyan-ft48-01.lab.bos.redhat.com>
Hello Jakub,
> The files are there to test the infrastructure. I'd say just try
> 2011-09-01 Jakub Jelinek <jakub@redhat.com>
>
> * gcc.dg/compat/struct-layout-1_test.h: Decrease bitfield size
> to work even with -fshort-enums.
>
> --- gcc/testsuite/gcc.dg/compat/struct-layout-1_test.h 2008-09-05
> 12:54:32.000000000 +0200
> +++ gcc/testsuite/gcc.dg/compat/struct-layout-1_test.h 2011-09-01
> 09:21:20.200426411 +0200
> @@ -1,5 +1 @@
> -#if (__SIZEOF_INT__ >= 4)
> -T(0,enum E2 a:31;,B(0,a,e2_m1,e2_0))
> -#else
> -T(0,enum E2 a:15;,B(0,a,e2_m1,e2_0))
> -#endif
> +T(0,enum E2 a:7;,B(0,a,e2_m1,e2_0))
>
> instead.
>
I just tried the patch, it works well. The case get passed. Would you please
commit it into trunk and GCC 4.6 branch? If you want me to do something
else, please let me know. Thanks.
BR,
Terry
prev parent reply other threads:[~2011-09-01 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:40 Terry Guo
2011-09-01 6:14 ` Jakub Jelinek
2011-09-01 6:34 ` Terry Guo
2011-09-01 6:46 ` Jakub Jelinek
2011-09-01 7:10 ` Terry Guo
2011-09-01 7:23 ` Jakub Jelinek
2011-09-01 7:46 ` Terry Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01cc6879$fb1a7b50$f14f71f0$@guo@arm.com' \
--to=terry.guo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).