* [AArch64] Do not mix statements with declarations
@ 2012-08-17 15:30 Sofiane Naci
0 siblings, 0 replies; 2+ messages in thread
From: Sofiane Naci @ 2012-08-17 15:30 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
Hi,
I've just committed the attached patch on the AArch64 branch to fix a style
issue related to mixing statements with declarations.
Thanks
Sofiane
-----
r190486 | sofiane | 2012-08-17 16:26:47 +0100 (Fri, 17 Aug 2012) | 7 lines
2012-08-17 Marcus Shawcroft <marcus.shawcroft@arm.com>
[AArch64] Do not mix statements and declarations.
* config/aarch64/aarch64.c (aarch64_simd_lane_bounds):
Do not mix statements with declarations.
[-- Attachment #2: aarch64-do-not-mix-stmt-decl.patch --]
[-- Type: application/octet-stream, Size: 526 bytes --]
Index: gcc/config/aarch64/aarch64.c
===================================================================
--- gcc/config/aarch64/aarch64.c (revision 190485)
+++ gcc/config/aarch64/aarch64.c (working copy)
@@ -6476,8 +6476,9 @@
void
aarch64_simd_lane_bounds (rtx operand, HOST_WIDE_INT low, HOST_WIDE_INT high)
{
+ HOST_WIDE_INT lane;
gcc_assert (GET_CODE (operand) == CONST_INT);
- HOST_WIDE_INT lane = INTVAL (operand);
+ lane = INTVAL (operand);
if (lane < low || lane >= high)
error ("lane out of range");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [AArch64] Do not mix statements with declarations
[not found] <502e63a2.65e7440a.624f.ffff8ae8SMTPIN_ADDED@mx.google.com>
@ 2012-08-24 14:29 ` Diego Novillo
0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2012-08-24 14:29 UTC (permalink / raw)
To: Sofiane Naci; +Cc: gcc-patches
On 2012-08-17 11:32 , Sofiane Naci wrote:
> Hi,
>
> I've just committed the attached patch on the AArch64 branch to fix a style
> issue related to mixing statements with declarations.
>
> Thanks
> Sofiane
>
> -----
>
> r190486 | sofiane | 2012-08-17 16:26:47 +0100 (Fri, 17 Aug 2012) | 7 lines
>
> 2012-08-17 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> [AArch64] Do not mix statements and declarations.
>
> * config/aarch64/aarch64.c (aarch64_simd_lane_bounds):
> Do not mix statements with declarations.
>
This is not necessary now. Code and declarations can be mixed.
Diego.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-24 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-17 15:30 [AArch64] Do not mix statements with declarations Sofiane Naci
[not found] <502e63a2.65e7440a.624f.ffff8ae8SMTPIN_ADDED@mx.google.com>
2012-08-24 14:29 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).