From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29571 invoked by alias); 16 Mar 2012 15:32:49 -0000 Received: (qmail 29558 invoked by uid 22791); 16 Mar 2012 15:32:48 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-yx0-f197.google.com (HELO mail-yx0-f197.google.com) (209.85.213.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Mar 2012 15:32:32 +0000 Received: by yenq11 with SMTP id q11so9274118yen.8 for ; Fri, 16 Mar 2012 08:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:reply-to:x-google-appengine-app-id:message-id:date :subject:from:to:cc:content-type:x-gm-message-state; bh=KbEmg/qQf0nXgttna1mMkdDxAb5gOjT4nOn4lz5DAAY=; b=X84ctrQ6dmT9iKcG6MIaWYjtP40h+V2XNXB8JYb9yWHTL5ut1hJ1TCQNKV4Gij0ouh ajg2S2x/R5iL6PEQnIedCphDLa8MjWLmOXI1tGcvwzIOrG916ZVAA5RUS9HGGGx4yPu/ 2QLTfnPgOG3db410a3OaTkOODeollzX7Mo5aPdIDpXQlj51EbzbihzOdqv7T5kY5Kqxy Coq/kn5N4KiW+HkN3swAioD+Mvt9zudWQu8KuGochkxJYZZMjlgqPsvsTq29XzwPUSWk P7Obn02P1aKEW1SYYqDBAJL3RK/NPbb++jiRVQLwf63idw3hugVY6rx/+qwfsd3gAa/T WyzA== Received: by 10.101.129.33 with SMTP id g33mr1213129ann.25.1331911951500; Fri, 16 Mar 2012 08:32:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.129.33 with SMTP id g33mr1213118ann.25.1331911951380; Fri, 16 Mar 2012 08:32:31 -0700 (PDT) Reply-To: ccoutant@google.com, saugustine@google.com, gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com X-Google-Appengine-App-Id: s~codereview-hr Message-ID: <001636c92b72bbf2c804bb5dea5f@google.com> Date: Fri, 16 Mar 2012 15:32:00 -0000 Subject: Re: [google/4.6] Fix problems with -gfission (issue 5844043) From: saugustine@google.com To: ccoutant@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-Gm-Message-State: ALoCoQkwpzJ6xuxnGjNgc2uCh70+we7gpk/11vJbUTMbuGYDXvPpn/9h2rdwzondbQIoURQVkbYVZQAgSo5olJkM4nrlXoZTHJNJdcosLSB5M5jg3KJHmaVX3TrsO0gOmZ2n3rLPdzA6CQGMje0CxF7oif6CnW/Wd0atvhml2TYdcA+DSzKAGjY= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01172.txt.bz2 On 2012/03/16 02:07:02, Cary wrote: > For google/gcc-4_6 branch. > This patch fixes several problems with -gfission: > - Bad index for range list in the compile unit DIE. > - DW_AT_ranges attribute for compile unit in the wrong file. > - Incorrect size for skeleton type unit DIEs. > - Wrote location expression using DW_OP_addr to DWO file. > - Emitted skeleton debug section even when there is no debug info. > Tested: bootstrap, gcc regression tests, hand testing on -gfission > test cases. These are OK for google 4_6. http://codereview.appspot.com/5844043/