* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 17:28 asharif
0 siblings, 0 replies; 9+ messages in thread
From: asharif @ 2012-05-16 17:28 UTC (permalink / raw)
To: shenhan, jingyu; +Cc: gcc-patches, carrot, reply
On 2012/05/16 01:02:26, shenhan wrote:
> Hi Amhad and Jing, could you take a look at this CL at
> http://codereview.appspot.com/6210060/
> Thanks,
> -Han
Shouldn't this have a corresponding ChangeLog entry and a
ChangeLog.google-gcc-4_6 entry?
http://codereview.appspot.com/6210060/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
2012-05-17 16:27 ` Han Shen(沈涵)
@ 2012-05-17 16:40 ` Diego Novillo
0 siblings, 0 replies; 9+ messages in thread
From: Diego Novillo @ 2012-05-17 16:40 UTC (permalink / raw)
To: "Han Shen(沈涵)"
Cc: asharif, jingyu, gcc-patches, carrot, reply
On 12-05-17 12:27 , Han Shen(沈涵) wrote:
> Hi, ok for approval?
OK.
Diego.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
2012-05-16 23:49 shenhan
@ 2012-05-17 16:27 ` Han Shen(沈涵)
2012-05-17 16:40 ` Diego Novillo
0 siblings, 1 reply; 9+ messages in thread
From: Han Shen(沈涵) @ 2012-05-17 16:27 UTC (permalink / raw)
To: asharif, jingyu, dnovillo; +Cc: gcc-patches, carrot, reply
Hi, ok for approval?
Thanks,
-Han
On Wed, May 16, 2012 at 4:49 PM, <shenhan@google.com> wrote:
> On 2012/05/16 23:30:28, Diego Novillo wrote:
>
>> On 12-05-16 19:22 , mailto:jingyu@google.com wrote:
>> > In my opinion, gcc/ChangeLog is for upstream commits only.
>> > It is fine that you want to port upstream gcc/ChangeLog as well.
>
> Just
>>
>> > remove your identities
>> > +2012-05-11 Han Shen <mailto:shenhan@google.com>
>>
>> > +
>> > + Backported r187569 from branches/google/gcc-4_6.
>
>
>> The convention for branches is that all the commits to them should get
>
>
>> ChangeLog entries in the file ChangeLog.<branch-tag>
>
>
>> where <branch-tag> is generally the basename of the branch URL, though
>
>
>> it is sometimes changed slightly. In the google branches we use the
>> convention 'google-<name>' for all the branches under google/*
>
>
>
>> Diego.
>
>
> Thanks, Jing and Diego.
>
> Reverted gcc/ChangeLog.
>
> Regards,
> -Han
>
> http://codereview.appspot.com/6210060/
--
Han Shen | Software Engineer | shenhan@google.com | +1-650-440-3330
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 23:49 shenhan
2012-05-17 16:27 ` Han Shen(沈涵)
0 siblings, 1 reply; 9+ messages in thread
From: shenhan @ 2012-05-16 23:49 UTC (permalink / raw)
To: asharif, jingyu, dnovillo; +Cc: gcc-patches, carrot, reply
On 2012/05/16 23:30:28, Diego Novillo wrote:
> On 12-05-16 19:22 , mailto:jingyu@google.com wrote:
> > In my opinion, gcc/ChangeLog is for upstream commits only.
> > It is fine that you want to port upstream gcc/ChangeLog as well.
Just
> > remove your identities
> > +2012-05-11 Han Shen <mailto:shenhan@google.com>
> > +
> > + Backported r187569 from branches/google/gcc-4_6.
> The convention for branches is that all the commits to them should get
> ChangeLog entries in the file ChangeLog.<branch-tag>
> where <branch-tag> is generally the basename of the branch URL, though
> it is sometimes changed slightly. In the google branches we use the
> convention 'google-<name>' for all the branches under google/*
> Diego.
Thanks, Jing and Diego.
Reverted gcc/ChangeLog.
Regards,
-Han
http://codereview.appspot.com/6210060/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
2012-05-16 23:22 jingyu
@ 2012-05-16 23:30 ` Diego Novillo
0 siblings, 0 replies; 9+ messages in thread
From: Diego Novillo @ 2012-05-16 23:30 UTC (permalink / raw)
To: shenhan, asharif, jingyu, gcc-patches, carrot, reply
On 12-05-16 19:22 , jingyu@google.com wrote:
> In my opinion, gcc/ChangeLog is for upstream commits only.
> It is fine that you want to port upstream gcc/ChangeLog as well. Just
> remove your identities
> +2012-05-11 Han Shen <shenhan@google.com>
> +
> + Backported r187569 from branches/google/gcc-4_6.
The convention for branches is that all the commits to them should get
ChangeLog entries in the file ChangeLog.<branch-tag>
where <branch-tag> is generally the basename of the branch URL, though
it is sometimes changed slightly. In the google branches we use the
convention 'google-<name>' for all the branches under google/*
Diego.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 23:22 jingyu
2012-05-16 23:30 ` Diego Novillo
0 siblings, 1 reply; 9+ messages in thread
From: jingyu @ 2012-05-16 23:22 UTC (permalink / raw)
To: shenhan, asharif; +Cc: gcc-patches, carrot, reply
In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well. Just
remove your identities
+2012-05-11 Han Shen <shenhan@google.com>
+
+ Backported r187569 from branches/google/gcc-4_6.
LGTM
On 2012/05/16 22:54:19, asharif1 wrote:
> On 2012/05/16 22:11:08, shenhan wrote:
> > On 2012/05/16 17:27:59, asharif1 wrote:
> > > On 2012/05/16 01:02:26, shenhan wrote:
> > > > Hi Amhad and Jing, could you take a look at this CL at
> > > > http://codereview.appspot.com/6210060/
> > > >
> > > > Thanks,
> > > > -Han
> > >
> > > Shouldn't this have a corresponding ChangeLog entry and a
> > > ChangeLog.google-gcc-4_6 entry?
> >
> > Hi Ahmad, thanks!
> >
> > Done recreating the patch from "svn merge -c".
> >
> > Regards,
> > -Han
> Thanks a lot, shenhan.
> lgtm.
http://codereview.appspot.com/6210060/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 22:54 asharif
0 siblings, 0 replies; 9+ messages in thread
From: asharif @ 2012-05-16 22:54 UTC (permalink / raw)
To: shenhan, jingyu; +Cc: gcc-patches, carrot, reply
On 2012/05/16 22:11:08, shenhan wrote:
> On 2012/05/16 17:27:59, asharif1 wrote:
> > On 2012/05/16 01:02:26, shenhan wrote:
> > > Hi Amhad and Jing, could you take a look at this CL at
> > > http://codereview.appspot.com/6210060/
> > >
> > > Thanks,
> > > -Han
> >
> > Shouldn't this have a corresponding ChangeLog entry and a
> > ChangeLog.google-gcc-4_6 entry?
> Hi Ahmad, thanks!
> Done recreating the patch from "svn merge -c".
> Regards,
> -Han
Thanks a lot, shenhan.
lgtm.
http://codereview.appspot.com/6210060/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 22:11 shenhan
0 siblings, 0 replies; 9+ messages in thread
From: shenhan @ 2012-05-16 22:11 UTC (permalink / raw)
To: asharif, jingyu; +Cc: gcc-patches, carrot, reply
On 2012/05/16 17:27:59, asharif1 wrote:
> On 2012/05/16 01:02:26, shenhan wrote:
> > Hi Amhad and Jing, could you take a look at this CL at
> > http://codereview.appspot.com/6210060/
> >
> > Thanks,
> > -Han
> Shouldn't this have a corresponding ChangeLog entry and a
> ChangeLog.google-gcc-4_6 entry?
Hi Ahmad, thanks!
Done recreating the patch from "svn merge -c".
Regards,
-Han
http://codereview.appspot.com/6210060/
^ permalink raw reply [flat|nested] 9+ messages in thread
* [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)
@ 2012-05-16 1:02 shenhan
0 siblings, 0 replies; 9+ messages in thread
From: shenhan @ 2012-05-16 1:02 UTC (permalink / raw)
To: asharif, jingyu; +Cc: gcc-patches, carrot, reply
Reviewers: asharif1, jingyu,
Message:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Description:
Ported r187569 from google/gcc-4_6 branch.
2012-05-11 Han Shen <shenhan@google.com>
Backport from mainline.
2012-05-01 Richard Earnshaw <rearnsha@arm.com>
* arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_DEFAULT): Avoid ifdef
comparing enumeration values. Update comments.
2012-04-26 Michael Hope <michael.hope@linaro.org>
Richard Earnshaw <rearnsha@arm.com>
* config/arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_SOFT_FLOAT):
Define.
(GLIBC_DYNAMIC_LINKER_HARD_FLOAT): Define.
(GLIBC_DYNAMIC_LINKER_DEFAULT): Define.
(GLIBC_DYNAMIC_LINKER): Redefine to use the hard float path.
Please review this at http://codereview.appspot.com/6210060/
Affected files:
M gcc/config/arm/linux-eabi.h
Index: gcc/config/arm/linux-eabi.h
===================================================================
--- gcc/config/arm/linux-eabi.h (revision 187569)
+++ gcc/config/arm/linux-eabi.h (working copy)
@@ -32,7 +32,8 @@
while (false)
/* We default to a soft-float ABI so that binaries can run on all
- target hardware. */
+ target hardware. If you override this to use the hard-float ABI then
+ change the setting of GLIBC_DYNAMIC_LINKER_DEFAULT as well. */
#undef TARGET_DEFAULT_FLOAT_ABI
#define TARGET_DEFAULT_FLOAT_ABI ARM_FLOAT_ABI_SOFT
@@ -59,11 +60,26 @@
#undef SUBTARGET_EXTRA_LINK_SPEC
#define SUBTARGET_EXTRA_LINK_SPEC " -m " TARGET_LINKER_EMULATION
-/* Use ld-linux.so.3 so that it will be possible to run "classic"
- GNU/Linux binaries on an EABI system. */
+/* GNU/Linux on ARM currently supports three dynamic linkers:
+ - ld-linux.so.2 - for the legacy ABI
+ - ld-linux.so.3 - for the EABI-derived soft-float ABI
+ - ld-linux-armhf.so.3 - for the EABI-derived hard-float ABI.
+ All the dynamic linkers live in /lib.
+ We default to soft-float, but this can be overridden by changing both
+ GLIBC_DYNAMIC_LINKER_DEFAULT and TARGET_DEFAULT_FLOAT_ABI. */
+
#undef GLIBC_DYNAMIC_LINKER
-#define GLIBC_DYNAMIC_LINKER RUNTIME_ROOT_PREFIX "/lib/ld-linux.so.3"
+#define GLIBC_DYNAMIC_LINKER_SOFT_FLOAT \
+ RUNTIME_ROOT_PREFIX "/lib/ld-linux.so.3"
+#define GLIBC_DYNAMIC_LINKER_HARD_FLOAT \
+ RUNTIME_ROOT_PREFIX "/lib/ld-linux-armhf.so.3"
+#define GLIBC_DYNAMIC_LINKER_DEFAULT GLIBC_DYNAMIC_LINKER_SOFT_FLOAT
+#define GLIBC_DYNAMIC_LINKER \
+ "%{mfloat-abi=hard:" GLIBC_DYNAMIC_LINKER_HARD_FLOAT "} \
+ %{mfloat-abi=soft*:" GLIBC_DYNAMIC_LINKER_SOFT_FLOAT "} \
+ %{!mfloat-abi=*:" GLIBC_DYNAMIC_LINKER_DEFAULT "}"
+
/* At this point, bpabi.h will have clobbered LINK_SPEC. We want to
use the GNU/Linux version, not the generic BPABI version. */
#undef LINK_SPEC
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-17 16:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-16 17:28 [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060) asharif
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 23:49 shenhan
2012-05-17 16:27 ` Han Shen(沈涵)
2012-05-17 16:40 ` Diego Novillo
2012-05-16 23:22 jingyu
2012-05-16 23:30 ` Diego Novillo
2012-05-16 22:54 asharif
2012-05-16 22:11 shenhan
2012-05-16 1:02 shenhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).