* Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
@ 2012-04-05 18:22 asharif
0 siblings, 0 replies; 5+ messages in thread
From: asharif @ 2012-04-05 18:22 UTC (permalink / raw)
To: dnovillo, jingyu, davidxl, michael.hope, andrew.stubbs; +Cc: gcc-patches, reply
Committed as r186168.
http://codereview.appspot.com/5989043/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
2012-04-05 3:57 asharif
2012-04-05 4:44 ` Michael Hope
@ 2012-04-05 16:16 ` Xinliang David Li
1 sibling, 0 replies; 5+ messages in thread
From: Xinliang David Li @ 2012-04-05 16:16 UTC (permalink / raw)
To: asharif, dnovillo, jingyu, davidxl, gcc-patches, reply
ok for google branches
David
On Wed, Apr 4, 2012 at 8:56 PM, <asharif@chromium.org> wrote:
> Reviewers: Diego Novillo, jingyu, davidxl,
>
> Message:
> Please take a look at this patch and tell me if it's OK for
> branches/google/gcc-4_6.
>
> Description:
> Backported the following patch from trunk:
>
> 2011-10-07 Andrew Stubbs <ams@codesourcery.com>
>
> gcc/
> * config/arm/predicates.md (shift_amount_operand): Remove constant
> range check.
> (shift_operator): Check range of constants for all shift operators.
>
> gcc/testsuite/
> * gcc.dg/pr50193-1.c: New file.
> * gcc.target/arm/shiftable.c: New file.
>
>
> Please review this at http://codereview.appspot.com/5989043/
>
> Affected files:
> M .
> M gcc/ChangeLog
> M gcc/ChangeLog.google-4_6
> M gcc/config/arm/predicates.md
> M gcc/testsuite/ChangeLog
> A + gcc/testsuite/gcc.dg/pr50193-1.c
> A + gcc/testsuite/gcc.target/arm/shiftable.c
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
2012-04-05 4:44 ` Michael Hope
@ 2012-04-05 12:18 ` Andrew Stubbs
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Stubbs @ 2012-04-05 12:18 UTC (permalink / raw)
To: Michael Hope; +Cc: asharif, dnovillo, jingyu, davidxl, gcc-patches, reply
On 05/04/12 05:43, Michael Hope wrote:
> Andrew, could you check that the Google guys have the final version of
> your patch?
Yes, it looks fine to me.
> Could you backport the fix to the 4.6 release branch if valid? Better
> than having the same patch in three places.
Ok, I'll need permission from a maintainer, I think.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
2012-04-05 3:57 asharif
@ 2012-04-05 4:44 ` Michael Hope
2012-04-05 12:18 ` Andrew Stubbs
2012-04-05 16:16 ` Xinliang David Li
1 sibling, 1 reply; 5+ messages in thread
From: Michael Hope @ 2012-04-05 4:44 UTC (permalink / raw)
To: Andrew Stubbs; +Cc: asharif, dnovillo, jingyu, davidxl, gcc-patches, reply
On 5 April 2012 15:56, <asharif@chromium.org> wrote:
> Reviewers: Diego Novillo, jingyu, davidxl,
>
> Message:
> Please take a look at this patch and tell me if it's OK for
> branches/google/gcc-4_6.
>
> Description:
> Backported the following patch from trunk:
>
> 2011-10-07 Andrew Stubbs <ams@codesourcery.com>
>
> gcc/
> * config/arm/predicates.md (shift_amount_operand): Remove constant
> range check.
> (shift_operator): Check range of constants for all shift operators.
>
> gcc/testsuite/
> * gcc.dg/pr50193-1.c: New file.
> * gcc.target/arm/shiftable.c: New file.
>
>
> Please review this at http://codereview.appspot.com/5989043/
>
> Affected files:
> M .
> M gcc/ChangeLog
> M gcc/ChangeLog.google-4_6
> M gcc/config/arm/predicates.md
> M gcc/testsuite/ChangeLog
> A + gcc/testsuite/gcc.dg/pr50193-1.c
> A + gcc/testsuite/gcc.target/arm/shiftable.c
Andrew, could you check that the Google guys have the final version of
your patch?
Could you backport the fix to the 4.6 release branch if valid? Better
than having the same patch in three places.
-- Michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
@ 2012-04-05 3:57 asharif
2012-04-05 4:44 ` Michael Hope
2012-04-05 16:16 ` Xinliang David Li
0 siblings, 2 replies; 5+ messages in thread
From: asharif @ 2012-04-05 3:57 UTC (permalink / raw)
To: dnovillo, jingyu, davidxl; +Cc: gcc-patches, reply
Reviewers: Diego Novillo, jingyu, davidxl,
Message:
Please take a look at this patch and tell me if it's OK for
branches/google/gcc-4_6.
Description:
Backported the following patch from trunk:
2011-10-07 Andrew Stubbs <ams@codesourcery.com>
gcc/
* config/arm/predicates.md (shift_amount_operand): Remove constant
range check.
(shift_operator): Check range of constants for all shift operators.
gcc/testsuite/
* gcc.dg/pr50193-1.c: New file.
* gcc.target/arm/shiftable.c: New file.
Please review this at http://codereview.appspot.com/5989043/
Affected files:
M .
M gcc/ChangeLog
M gcc/ChangeLog.google-4_6
M gcc/config/arm/predicates.md
M gcc/testsuite/ChangeLog
A + gcc/testsuite/gcc.dg/pr50193-1.c
A + gcc/testsuite/gcc.target/arm/shiftable.c
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-05 18:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-05 18:22 [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043) asharif
-- strict thread matches above, loose matches on Subject: below --
2012-04-05 3:57 asharif
2012-04-05 4:44 ` Michael Hope
2012-04-05 12:18 ` Andrew Stubbs
2012-04-05 16:16 ` Xinliang David Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).