From: "Roger Sayle" <roger@nextmovesoftware.com>
To: "'GCC Patches'" <gcc-patches@gcc.gnu.org>
Subject: [x86 PATCH] Allow SCmode and DImode to be tieable on TARGET_64BIT.
Date: Mon, 30 May 2022 14:22:43 +0100 [thread overview]
Message-ID: <001d01d87428$58e9c9a0$0abd5ce0$@nextmovesoftware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
This patch is a form of insurance policy in case my patch for PR 7061 runs
into problems on non-x86 targets; the middle-end can add an extra check
that the backend is happy placing SCmode and DImode values in the same
register, before creating a SUBREG. Unfortunately, ix86_modes_tieable_p
currently claims this is not allowed(?), even though the default target
hook for modes_tieable_p is to always return true [i.e. false can be
used to specifically prohibit bad combinations], and the x86_64 ABI
passes SCmode values in DImode registers!. This makes the backend's
modes_tiable_p hook a little more forgiving, and additionally enables
interconversion between SCmode and V2SFmode, and between DCmode and
VD2Fmode, which opens interesting opportunities in the future.
I believe there should currently be no code generation differences
with this change. This patch has been tested on x86_64-pc-linux-gnu
with make bootstrap and make -k check, both with and without
--target_board=unix{-m32}, with no new failures. Ok for mainline?
2022-05-30 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
* config/i386/i386.cc (ix86_modes_tieable_p): Allow SCmode to be
tieable with DImode on TARGET_64BIT, and SCmode tieable with
V2SFmode, and DCmode with V2DFmode.
Thanks in advance,
Roger
--
[-- Attachment #2: patchcx2.txt --]
[-- Type: text/plain, Size: 839 bytes --]
diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
index daa60ac..df5c80d 100644
--- a/gcc/config/i386/i386.cc
+++ b/gcc/config/i386/i386.cc
@@ -20141,6 +20141,18 @@ ix86_modes_tieable_p (machine_mode mode1, machine_mode mode2)
return (GET_MODE_SIZE (mode1) == 8
&& ix86_hard_regno_mode_ok (FIRST_MMX_REG, mode1));
+ /* SCmode and DImode can be tied. */
+ if ((mode1 == E_SCmode && mode2 == E_DImode)
+ || (mode1 == E_DImode && mode2 == E_SCmode))
+ return TARGET_64BIT;
+
+ /* [SD]Cmode and V2[SD]Fmode modes can be tied. */
+ if ((mode1 == E_SCmode && mode2 == E_V2SFmode)
+ || (mode1 == E_V2SFmode && mode2 == E_SCmode)
+ || (mode1 == E_DCmode && mode2 == E_V2DFmode)
+ || (mode1 == E_V2DFmode && mode2 == E_DCmode))
+ return true;
+
return false;
}
next reply other threads:[~2022-05-30 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 13:22 Roger Sayle [this message]
2022-05-30 20:12 ` Uros Bizjak
2022-05-30 20:13 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01d87428$58e9c9a0$0abd5ce0$@nextmovesoftware.com' \
--to=roger@nextmovesoftware.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).