Re: PATCH [cygwin/mingw ]: Don't add stdcall suffix to variadic functions

[Danny Smith <dannysmith@clear.net.nz>]

----- Original Message -----
From: "Jason Merrill"
Subject: Re: PATCH [cygwin/mingw ]: Don't add stdcall suffix to variadic
functions


| On Thu, 15 Jul 2004 18:53:33 +1200 (NZST), Danny Smith  wrote:
|
| > However, for variadic functions, which cannot be handled
| > as __stdcall because the parameter list is indefinite, it
| > leaves off the suffix
| > eg.
| > void __stdcall foo (int a, ...)
| >
| > foo stays as _foo
| >
| > Currently gcc adds @0 suffix to both types of function
| >
| > The following patch makes gcc consistent with native compiler.  It
also
| > rationalizes the two functions gen_fastcall_sufffix  and
gen_stdcall_suffix
| > (which are identical except for two statements) into a single
function
|
| Would it make more sense just to ignore the __stdcall for variadic
| functions, since it doesn't work anyway?

I tried that, by adding a check for TREE_VALUE (tree_last(
TYPE_ARG_TYPES (TREE_TYPE (decl)))
to the attribute handler in i386.c , but it didn't work, because at that
point  TARG_ARG_TYPES is still null.

The __stdcall attribute is ignored  for variadic functions in
ix86_return_pops_args, where a similar check is made.

Danny

Danny
|
| Jason