From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28758 invoked by alias); 10 Jun 2011 18:02:26 -0000 Received: (qmail 28748 invoked by uid 22791); 10 Jun 2011 18:02:25 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 18:02:09 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p5AI27pq000928 for ; Fri, 10 Jun 2011 11:02:08 -0700 Received: from yie36 (yie36.prod.google.com [10.243.66.36]) by kpbe16.cbf.corp.google.com with ESMTP id p5AI0Gn5012994 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 10 Jun 2011 11:02:06 -0700 Received: by yie36 with SMTP id 36so2302015yie.1 for ; Fri, 10 Jun 2011 11:02:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.105.198 with SMTP id k46mr1312842yhg.49.1307728925877; Fri, 10 Jun 2011 11:02:05 -0700 (PDT) Reply-To: xur@google.com, dnovillo@google.com, davidxl@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <0023547c8caf16ebf804a55f5ec0@google.com> Date: Fri, 10 Jun 2011 18:29:00 -0000 Subject: Re: [google] limit excessive load/store motions (issue4563044) From: davidxl@google.com To: xur@google.com, dnovillo@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00870.txt.bz2 Ok for google/main after the minor cleanups. Incorporate comments from maintainers when available. David http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c File gcc/gcse.c (right): http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5050 gcc/gcse.c:5050: if (ld_motion_count >= ld_motion_limit) Can you merge the check with the check below? http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5087 gcc/gcse.c:5087: }loop_lsm_limit_map; Missing space. http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5101 gcc/gcse.c:5101: /* hash equal function for loop_lsm_limit_map_htab */ missing . and one space. http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5107 gcc/gcse.c:5107: *const ptr2 = (const loop_lsm_limit_map *) p2; indentation problem. http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5112 gcc/gcse.c:5112: /* free one entry in loop_lsm_limit_map_htab */ . and space http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5254 gcc/gcse.c:5254: static void Missing documentation. http://codereview.appspot.com/4563044/diff/1/gcc/tree-ssa-loop-im.c File gcc/tree-ssa-loop-im.c (right): http://codereview.appspot.com/4563044/diff/1/gcc/tree-ssa-loop-im.c#newcode100 gcc/tree-ssa-loop-im.c:100: /* limit for lsm that can be performed for one loop */ one more space http://codereview.appspot.com/4563044/