From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20972 invoked by alias); 22 Jun 2011 20:52:17 -0000 Received: (qmail 20963 invoked by uid 22791); 22 Jun 2011 20:52:16 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 20:52:00 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p5MKpxGU026211 for ; Wed, 22 Jun 2011 13:52:00 -0700 Received: from vws4 (vws4.prod.google.com [10.241.21.132]) by wpaz21.hot.corp.google.com with ESMTP id p5MKpkod002478 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 22 Jun 2011 13:51:59 -0700 Received: by vws4 with SMTP id 4so1233717vws.1 for ; Wed, 22 Jun 2011 13:51:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.110.10 with SMTP id t10mr740659yhg.7.1308775918260; Wed, 22 Jun 2011 13:51:58 -0700 (PDT) Reply-To: gchare@google.com, crowl@google.com, dnovillo@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <002354867bf2b2d7a104a6532313@google.com> Date: Wed, 22 Jun 2011 21:04:00 -0000 Subject: Re: [pph] Stream scope_chain->bindings instead of global namespace (issue4661045) From: dnovillo@google.com To: gchare@google.com, crowl@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: base64 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01717.txt.bz2 DQpodHRwOi8vY29kZXJldmlldy5hcHBzcG90LmNvbS80NjYxMDQ1L2RpZmYv MS9nY2MvY3AvcHBoLXN0cmVhbWVyLWluLmMNCkZpbGUgZ2NjL2NwL3BwaC1z dHJlYW1lci1pbi5jIChyaWdodCk6DQoNCmh0dHA6Ly9jb2RlcmV2aWV3LmFw cHNwb3QuY29tLzQ2NjEwNDUvZGlmZi8xL2djYy9jcC9wcGgtc3RyZWFtZXIt aW4uYyNuZXdjb2RlMTAwMw0KZ2NjL2NwL3BwaC1zdHJlYW1lci1pbi5jOjEw MDM6IG5hbWVzcGFjZS4NCiAgMTAwMSAgICAgICAvKiBGSVhNRSBwcGg6IHRo aXMgY2FycmllZCBvdmVyIGZyb20NCnBwaF9hZGRfbmFtZXNfdG9fbmFtZXNw YWNlLA0KICAxMDAyILsgICAgICAgIGl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8g dXNlIHRoaXMgd2hlbiBtZXJnaW5nIG5hbWVzIGluIGFuDQpleGlzdGluZw0K ICAxMDAzILsgICAgICAgIG5hbWVzcGFjZS4NCg0KcHBoX2FkZF9uYW1lc190 b19uYW1lc3BhY2UgZG9lcyBub3QgZXhpc3QgYW55bW9yZS4gIEkgZG9uJ3Qg dW5kZXJzdGFuZA0KdGhpcyBjb21tZW50Lg0KDQpodHRwOi8vY29kZXJldmll dy5hcHBzcG90LmNvbS80NjYxMDQ1L2RpZmYvMS9nY2MvY3AvcHBoLXN0cmVh bWVyLW91dC5jDQpGaWxlIGdjYy9jcC9wcGgtc3RyZWFtZXItb3V0LmMgKHJp Z2h0KToNCg0KaHR0cDovL2NvZGVyZXZpZXcuYXBwc3BvdC5jb20vNDY2MTA0 NS9kaWZmLzEvZ2NjL2NwL3BwaC1zdHJlYW1lci1vdXQuYyNuZXdjb2RlOTQ3 DQpnY2MvY3AvcHBoLXN0cmVhbWVyLW91dC5jOjk0NzogZ2NjX2Fzc2VydCAo IHNzLT5vbGRfbmFtZXNwYWNlID09DQpnbG9iYWxfbmFtZXNwYWNlDQogICA5 NDUgICAvKiBvbGRfbmFtZXNwYWNlIHNob3VsZCBiZSBnbG9iYWxfbmFtZXNw YWNlIGFuZCBhbGwgZW50cmllcw0KbGlzdGVkIGJlbG93DQogICA5NDYgICAg ICBzaG91bGQgYmUgTlVMTCBvciAwOyBvdGhlcndpc2UgdGhlIGhlYWRlciBw YXJzZWQgd2FzDQppbmNvbXBsZXRlLiAgKi8NCiAgIDk0NyAgIGdjY19hc3Nl cnQgKCBzcy0+b2xkX25hbWVzcGFjZSA9PSBnbG9iYWxfbmFtZXNwYWNlDQoN Ck5vIHNwYWNlIGFmdGVyICcoJy4NCg0KaHR0cDovL2NvZGVyZXZpZXcuYXBw c3BvdC5jb20vNDY2MTA0NS9kaWZmLzEvZ2NjL2NwL3BwaC1zdHJlYW1lci1v dXQuYyNuZXdjb2RlOTQ5DQpnY2MvY3AvcHBoLXN0cmVhbWVyLW91dC5jOjk0 OTogfHwgc3MtPmZ1bmN0aW9uX2RlY2wgfHwNCnNzLT50ZW1wbGF0ZV9wYXJt cyB8fCBzcy0+eF9zYXZlZF90cmVlDQogICA5NDggICAgICAgJiYgIShzcy0+ Y2xhc3NfbmFtZSB8fCBzcy0+Y2xhc3NfdHlwZSB8fA0Kc3MtPmFjY2Vzc19z cGVjaWZpZXINCiAgIDk0OSAgICAgICAgICAgIHx8IHNzLT5mdW5jdGlvbl9k ZWNsIHx8IHNzLT50ZW1wbGF0ZV9wYXJtcyB8fA0Kc3MtPnhfc2F2ZWRfdHJl ZQ0KDQpBbGlnbiAnJiYnIHZlcnRpY2FsbHkgd2l0aCB0aGUgb3BlbiBicmFj ZS4NCg0KaHR0cDovL2NvZGVyZXZpZXcuYXBwc3BvdC5jb20vNDY2MTA0NS9k aWZmLzEvZ2NjL2NwL3BwaC1zdHJlYW1lci5jDQpGaWxlIGdjYy9jcC9wcGgt c3RyZWFtZXIuYyAocmlnaHQpOg0KDQpodHRwOi8vY29kZXJldmlldy5hcHBz cG90LmNvbS80NjYxMDQ1L2RpZmYvMS9nY2MvY3AvcHBoLXN0cmVhbWVyLmMj bmV3Y29kZTM0DQpnY2MvY3AvcHBoLXN0cmVhbWVyLmM6MzQ6ICNpbmNsdWRl ICJuYW1lLWxvb2t1cC5oIg0KICAgMzMgI2luY2x1ZGUgImNwcGJ1aWx0aW4u aCINCisgMzQgI2luY2x1ZGUgIm5hbWUtbG9va3VwLmgiDQoNCllvdSBhbHNv IG5lZWQgdG8gYWRkIGNwL25hbWUtbG9va3VwLmggdG8gdGhlIGxpc3Qgb2Yg ZGVwZW5kZW5jaWVzIGZvcg0KY3AvcHBoLm8gaW4gY3AvTWFrZS1sYW5nLmlu Lg0KDQpodHRwOi8vY29kZXJldmlldy5hcHBzcG90LmNvbS80NjYxMDQ1Lw0K