From: "Hale Wang" <hale.wang@arm.com>
To: "'Segher Boessenkool'" <segher@kernel.crashing.org>
Cc: <law@redhat.com>, "GCC Patches" <gcc-patches@gcc.gnu.org>,
"Richard Sandiford" <Richard.Sandiford@arm.com>,
"'Terry Guo'" <flameroc@gmail.com>
Subject: RE: [PATCH] [gcc, combine] Backport to GCC 5.0 branch "PR46164: Don't combine the insns if a volatile register is contained".
Date: Mon, 18 May 2015 07:35:00 -0000 [thread overview]
Message-ID: <002e01d0913c$f32f1a00$d98d4e00$@arm.com> (raw)
In-Reply-To: <20150514132922.GD1081@gate.crashing.org>
> -----Original Message-----
> From: Segher Boessenkool [mailto:segher@kernel.crashing.org]
> Sent: Thursday, May 14, 2015 9:29 PM
> To: Hale Wang
> Cc: law@redhat.com; GCC Patches; Richard Sandiford; 'Terry Guo'
> Subject: Re: [PATCH] [gcc, combine] Backport to GCC 5.0 branch "PR46164:
> Don't combine the insns if a volatile register is contained".
>
> On Thu, May 14, 2015 at 01:56:54PM +0800, Hale Wang wrote:
> > > >> gcc/ChangeLog:
> > > >> 2015-04-22 Hale Wang <hale.wang@arm.com>
> > > >> Terry Guo <terry.guo@arm.com>
> > > >>
> > > >> PR rtl-optimization/64818
> > > >> * combine.c (can_combine_p): Don't combine user-specified
> > > >> register
> > > if
> > > >> it is in an asm input.
> > > >>
> > > >> gcc/testsuite/ChangeLog:
> > > >> 2015-04-22 Hale Wang <hale.wang@arm.com>
> > > >> Terry Guo <terry.guo@arm.com>
> > > >>
> > > >> PR rtl-optimization/64818
> > > >> * gcc.target/arm/pr64818.c: New.
>
> > This patch applies cleanly on GCC 5.0 branch. Bootstrap and regression
test
> are OK for X86_64.
> >
> > Can we backport this patch to GCC 5.0 branch?
>
> It should be perfectly safe, and it's a pretty nasty bug. But it is
technically not
> a regression (or is it?), so I'll defer to the release managers.
>
Yes, I agree it is not a regression.
>
> Segher
prev parent reply other threads:[~2015-05-18 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 7:59 Hale Wang
2015-05-14 13:36 ` Segher Boessenkool
2015-05-18 7:35 ` Hale Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002e01d0913c$f32f1a00$d98d4e00$@arm.com' \
--to=hale.wang@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=flameroc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).