[PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

[PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

[Thomas Preud'homme]

Hi,

Testcase for PR65647 assumes that the compiler can compile for ARMv6-M
which might not be the case if passing some extra options via
RUNTESTFLAGS (eg. -marm/-mcpu=cortex-a9). This patch restricts the
testcase to ARMv6-M effective targets.


Testsuite ChangeLog entry is as follows:

2015-06-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

        * gcc.target/arm/pr65647.c: Restrict to ARMv6-M effective targets.


diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c
index d3b44b2..d828d23 100644
--- a/gcc/testsuite/gcc.target/arm/pr65647.c
+++ b/gcc/testsuite/gcc.target/arm/pr65647.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target arm_arch_v6m_ok } */
 /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */
 
 a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x,


Patch was tested by running the testcase once with -mcpu=cortex-a9
(skipped as expected) and once with -mcpu=cortex-m0 (passes).

Is this ok for trunk?

Best regards,

Thomas

Re: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

[Richard Earnshaw]

On 26/06/15 09:45, Thomas Preud'homme wrote:
> Hi,
> 
> Testcase for PR65647 assumes that the compiler can compile for ARMv6-M
> which might not be the case if passing some extra options via
> RUNTESTFLAGS (eg. -marm/-mcpu=cortex-a9). This patch restricts the
> testcase to ARMv6-M effective targets.
> 
> 
> Testsuite ChangeLog entry is as follows:
> 
> 2015-06-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> 
>         * gcc.target/arm/pr65647.c: Restrict to ARMv6-M effective targets.
> 
> 
> diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c
> index d3b44b2..d828d23 100644
> --- a/gcc/testsuite/gcc.target/arm/pr65647.c
> +++ b/gcc/testsuite/gcc.target/arm/pr65647.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target arm_arch_v6m_ok } */
>  /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */
>  
>  a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x,
> 
> 
> Patch was tested by running the testcase once with -mcpu=cortex-a9
> (skipped as expected) and once with -mcpu=cortex-m0 (passes).
> 
> Is this ok for trunk?
> 

OK.

R.

> Best regards,
> 
> Thomas
> 
> 

Re: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

[James Greenhalgh]

On Fri, Jun 26, 2015 at 09:50:33AM +0100, Richard Earnshaw wrote:
> On 26/06/15 09:45, Thomas Preud'homme wrote:
> > Hi,
> > 
> > Testcase for PR65647 assumes that the compiler can compile for ARMv6-M
> > which might not be the case if passing some extra options via
> > RUNTESTFLAGS (eg. -marm/-mcpu=cortex-a9). This patch restricts the
> > testcase to ARMv6-M effective targets.
> > 
> > 
> > Testsuite ChangeLog entry is as follows:
> > 
> > 2015-06-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >         * gcc.target/arm/pr65647.c: Restrict to ARMv6-M effective targets.
> > 
> > 
> > diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c
> > index d3b44b2..d828d23 100644
> > --- a/gcc/testsuite/gcc.target/arm/pr65647.c
> > +++ b/gcc/testsuite/gcc.target/arm/pr65647.c
> > @@ -1,4 +1,5 @@
> >  /* { dg-do compile } */
> > +/* { dg-require-effective-target arm_arch_v6m_ok } */
> >  /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */
> >  
> >  a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x,
> > 
> > 
> > Patch was tested by running the testcase once with -mcpu=cortex-a9
> > (skipped as expected) and once with -mcpu=cortex-m0 (passes).
> > 
> > Is this ok for trunk?
> > 
> 
> OK.

This should already have been covered by:

  https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01105.html

	2015-06-16  James Greenhalgh  <james.greenhalgh@arm.com>

	* gcc.target/arm/pr65647.c: Do not override -mfloat-abi directives
	passed by the testsuite driver.

Thanks,
James

---
diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c
index d3b44b2..26b4e39 100644
--- a/gcc/testsuite/gcc.target/arm/pr65647.c
+++ b/gcc/testsuite/gcc.target/arm/pr65647.c
@@ -1,4 +1,6 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target arm_arch_v6m_ok } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } {"-mfloat-abi=soft" } } */
 /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */
 
 a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x,

> > Best regards,
> > 
> > Thomas
> > 
> > 
> 

RE: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

[Thomas Preud'homme]

> From: James Greenhalgh [mailto:james.greenhalgh@arm.com]
> Sent: Friday, June 26, 2015 6:15 PM
> 
> This should already have been covered by:
> 
>   https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01105.html
> 
> 	2015-06-16  James Greenhalgh  <james.greenhalgh@arm.com>
> 
> 	* gcc.target/arm/pr65647.c: Do not override -mfloat-abi
> directives
> 	passed by the testsuite driver.

Indeed, time to git pull. Sorry for the noise :-(

Best regards,

Thomas