* [C PATCH] PR c/98198: ICE-on-invalid-code error recovery.
@ 2022-03-16 16:20 Roger Sayle
2022-03-16 17:57 ` Joseph Myers
0 siblings, 1 reply; 2+ messages in thread
From: Roger Sayle @ 2022-03-16 16:20 UTC (permalink / raw)
To: 'GCC Patches'
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
This is Christophe Lyon's fix to PR c/98198, an ICE-on-invalid-code
regression affecting mainline, and a suitable testcase.
Tested on x86_64-pc-linux-gnu with make bootstrap and make -k check
with no new failures. Ok for mainline?
2022-03-16 Christophe Lyon <christophe.lyon@arm.com>
Roger Sayle <roger@nextmovesoftware.com>
gcc/c-family/ChangeLog
PR c/98198
* c-attribs.cc (decl_or_type_attrs): Add error_mark_node check.
gcc/testsuite/ChangeLog
PR c/98198
* gcc.dg/pr98198.c: New test case.
Thanks in advance,
Roger
--
[-- Attachment #2: patchce.txt --]
[-- Type: text/plain, Size: 777 bytes --]
diff --git a/gcc/c-family/c-attribs.cc b/gcc/c-family/c-attribs.cc
index c885d88..111a33f 100644
--- a/gcc/c-family/c-attribs.cc
+++ b/gcc/c-family/c-attribs.cc
@@ -806,6 +806,8 @@ decl_or_type_attrs (tree node)
return attrs;
tree type = TREE_TYPE (node);
+ if (type == error_mark_node)
+ return NULL_TREE;
return TYPE_ATTRIBUTES (type);
}
diff --git a/gcc/testsuite/gcc.dg/pr98198.c b/gcc/testsuite/gcc.dg/pr98198.c
new file mode 100644
index 0000000..489afae
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr98198.c
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+static inline void sub_1 ( ) {
+ struct struct_1 var_9 , var_10
+}
+
+static int var_9[1] __attribute__ ( ( section ( ".data" ) ) ) ;
+/* { dg-excess-errors "" } */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [C PATCH] PR c/98198: ICE-on-invalid-code error recovery.
2022-03-16 16:20 [C PATCH] PR c/98198: ICE-on-invalid-code error recovery Roger Sayle
@ 2022-03-16 17:57 ` Joseph Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Myers @ 2022-03-16 17:57 UTC (permalink / raw)
To: Roger Sayle; +Cc: 'GCC Patches'
On Wed, 16 Mar 2022, Roger Sayle wrote:
> This is Christophe Lyon's fix to PR c/98198, an ICE-on-invalid-code
> regression affecting mainline, and a suitable testcase.
> Tested on x86_64-pc-linux-gnu with make bootstrap and make -k check
> with no new failures. Ok for mainline?
>
>
> 2022-03-16 Christophe Lyon <christophe.lyon@arm.com>
> Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/c-family/ChangeLog
> PR c/98198
> * c-attribs.cc (decl_or_type_attrs): Add error_mark_node check.
>
> gcc/testsuite/ChangeLog
> PR c/98198
> * gcc.dg/pr98198.c: New test case.
OK.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 16:20 [C PATCH] PR c/98198: ICE-on-invalid-code error recovery Roger Sayle
2022-03-16 17:57 ` Joseph Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).