From: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
To: palmer <palmer@dabbelt.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
kito.cheng <kito.cheng@gmail.com>,
Kito.cheng <Kito.cheng@sifive.com>
Subject: Re: Re: [committed] RISC-V: Add crypto vector builtin function.
Date: Fri, 5 Jan 2024 11:28:19 +0800 [thread overview]
Message-ID: <004CB9DB70A724B5+2024010511281905548718@rivai.ai> (raw)
In-Reply-To: <mhng-ba0a7622-416c-4d7c-831b-30e2aab89a3d@palmer-ri-x1c9a>
[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]
We (me and kito) has reviewed vector-crypto.
I believe Wang Feng has done && passed the regression (with no RTL check), but he just didn't enable RTL check I guessed.
(By default, RTL check is disabled in riscv-gnu-toolchain, developers need to enable it manually).
It's ok to revert the patch, then commit it after he fixes the ICE with enabling RTL check.
juzhe.zhong@rivai.ai
From: Palmer Dabbelt
Date: 2024-01-05 11:24
To: juzhe.zhong
CC: gcc-patches; Kito Cheng; Kito.cheng
Subject: Re: [committed] RISC-V: Add crypto vector builtin function.
On Thu, 04 Jan 2024 19:17:21 PST (-0800), juzhe.zhong@rivai.ai wrote:
> Hi, Wang Feng.
>
> Your patch has some ICEs:
> FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (internal compiler error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, at config/riscv/riscv-v.cc:4930)
> FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (test for excess errors)
> FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (internal compiler error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, at config/riscv/riscv-v.cc:4930)
> FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (test for excess errors)
> FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (internal compiler error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, at config/riscv/riscv-v.cc:4930)
> FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (test for excess errors)
So let's just revert it, it doesn't even look like it was reviewed.
We've set a really bad precedent here where we're just merging a bunch
of unreviewed code and sorting out the regressions in trunk, that's not
the right way to do things.
>
> I suspect you didn't enable rtl check in the regression:
>
> ../../configure --enable-gcc-checking=rtl.
> Plz enable rtl check in the regression tests.
>
>
>
> juzhe.zhong@rivai.ai
next prev parent reply other threads:[~2024-01-05 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 3:17 juzhe.zhong
2024-01-05 3:24 ` Palmer Dabbelt
2024-01-05 3:28 ` juzhe.zhong [this message]
2024-01-05 6:57 ` Feng Wang
2024-01-05 3:38 ` juzhe.zhong
2024-01-05 15:50 ` Jeff Law
2024-01-05 23:54 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=004CB9DB70A724B5+2024010511281905548718@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=Kito.cheng@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).