From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13957 invoked by alias); 12 Sep 2013 06:13:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13940 invoked by uid 89); 12 Sep 2013 06:13:54 -0000 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Sep 2013 06:13:54 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 12 Sep 2013 07:13:50 +0100 Received: from SHAWIN162 ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 12 Sep 2013 07:13:48 +0100 From: "bin.cheng" To: "'Bill Schmidt'" , "Yufeng Zhang" , "Yufeng Zhang" Cc: "Richard Biener" , "GCC Patches" References: <003f01cea7a9$8e984ae0$abc8e0a0$@arm.com> <1378685738.3730.16.camel@gnopaine> <004801cead25$724765c0$56d63140$@arm.com> <1378740018.3730.21.camel@gnopaine> <1378740932.3730.23.camel@gnopaine> <004901ceadf9$195f9700$4c1ec500$@arm.com> <1378819832.3730.35.camel@gnopaine> In-Reply-To: <1378819832.3730.35.camel@gnopaine> Subject: RE: [PATCH GCC]Catch more MEM_REFs sharing common addressing part in gimple strength reduction Date: Thu, 12 Sep 2013 08:07:00 -0000 Message-ID: <005001ceaf7f$338eb160$9aac1420$@arm.com> MIME-Version: 1.0 X-MC-Unique: 113091207135001601 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00897.txt.bz2 On Tue, Sep 10, 2013 at 9:30 PM, Bill Schmidt = wrote: > > > On Tue, 2013-09-10 at 15:41 +0800, bin.cheng wrote: >> On Mon, Sep 9, 2013 at 11:35 PM, Bill Schmidt wrote: >> > >> >> > I rely on size_binop to convert T2 into sizetype, because T2' may b= e in other kind of type. Otherwise there will be ssa_verify error later. >> >> >> >> OK, I see now. I had thought this was handled by fold_build2, but >> >> apparently not. I guess all T2's formerly handled were already sizet= ype >> >> as expected. Thanks for the explanation! >> > >> > So, wouldn't it suffice to change t2 to fold_convert (sizetype, t2) in >> > the argument list to fold_build2? It's picking nits, but that would be >> > slightly more efficient. >> >> Hi Bill, >> >> This is the 2nd version of patch with your comments incorporated. >> Bootstrap and re-test on x86. Re-test on ARM ongoing. Is it ok if test= s pass? > > Looks good to me! Thanks, Bin. > Sorry I have to hold on this patch since it causes several tests failed on = ARM. Will investigate it and get back ASAP. Thanks. bin