public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sebastian Paul Pop <s.pop@samsung.com>
To: 'Richard Biener' <richard.guenther@gmail.com>, sebpop@gmail.com
Cc: gcc-patches@gcc.gnu.org, hiraditya@msn.com
Subject: RE: [PATCH 2/2] [graphite] fix invalid bounds on array refs
Date: Wed, 02 Dec 2015 21:36:00 -0000	[thread overview]
Message-ID: <005501d12d49$856b2870$90417950$@samsung.com> (raw)
In-Reply-To: <26A4BFA1-EF5B-4DA1-A203-4EA3B41AC996@gmail.com>

Do you recommend that we add a gcc_assert that min is always lower than max?
The change in Graphite code can be reverted then:

>+  /* Fortran has some arrays where high bound is -1 and low is 0.  */
>+  if (integer_onep (fold_build2 (LT_EXPR, boolean_type_node, high,
>low)))
>+    return false;


-----Original Message-----

But either that is the case or the frontend has a bug and should be fixed.  So your patch doesn't make any sense.

Richard.


  reply	other threads:[~2015-12-02 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 16:34 [PATCH 1/2] [graphite] rename flag_loop_optimize_isl to flag_loop_nest_optimize Sebastian Pop
2015-12-02 16:34 ` [PATCH 2/2] [graphite] fix invalid bounds on array refs Sebastian Pop
2015-12-02 21:18   ` Richard Biener
2015-12-02 21:36     ` Sebastian Paul Pop [this message]
2015-12-03  9:50       ` Richard Biener
2015-12-03 21:14         ` Sebastian Pop
2015-12-04 10:13           ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005501d12d49$856b2870$90417950$@samsung.com' \
    --to=s.pop@samsung.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hiraditya@msn.com \
    --cc=richard.guenther@gmail.com \
    --cc=sebpop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).