From: "Dave Korn" <dave.korn@artimi.com>
To: "'Mark Mitchell'" <mark@codesourcery.com>,
"'\"Seongbae Park (박성배, 朴成培)\"'" <seongbae.park@gmail.com>
Cc: "'gcc-patches'" <gcc-patches@gcc.gnu.org>,
"'Nathan Sidwell'" <nathan@codesourcery.com>
Subject: RE: [PATCH] Wrong line number for the closing brace of template functions
Date: Mon, 06 Aug 2007 18:47:00 -0000 [thread overview]
Message-ID: <009701c7d85a$35cd4610$2e08a8c0@CAM.ARTIMI.COM> (raw)
In-Reply-To: <46B7644E.9080808@codesourcery.com>
On 06 August 2007 19:11, Mark Mitchell wrote:
> However, this comment:
>
> + /* Make sure the current input_location
> + is set correctly to the end of the function
> + - this makes finish_function to set
> + function_end_locus of this specialization correctly. */
>
> could be written better as:
>
> /* Set the current input_location to the end of the function so
> that finish_function knows where we are. */
>
> The "makes x to set y" construct is not grammatical.
FYI, anyone whose first language isn't English:
The very similar construction "causes x to set y" is grammatical, and although "makes" and "causes" mean the same in this context, only "causes" may be used in that construct. "makes x set y" would also be grammatical. (I don't know why "causes" requires an infinitive (actually, probably a gerund) and "makes" requires a finite verb phrase, but there you go).
cheers,
DaveK
--
Can't think of a witty .sigline today....
prev parent reply other threads:[~2007-08-06 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 17:36 Seongbae Park (박성배, 朴成培)
2007-08-06 18:11 ` Mark Mitchell
2007-08-06 18:47 ` Dave Korn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009701c7d85a$35cd4610$2e08a8c0@CAM.ARTIMI.COM' \
--to=dave.korn@artimi.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@codesourcery.com \
--cc=nathan@codesourcery.com \
--cc=seongbae.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).