From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-200946-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17110 invoked by alias); 6 Aug 2007 18:47:30 -0000
Received: (qmail 17076 invoked by uid 22791); 6 Aug 2007 18:47:30 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.artimi.com (HELO mail.artimi.com) (194.72.81.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 18:47:21 +0000
Received: from rainbow ([192.168.8.46]) by mail.artimi.com with Microsoft SMTPSVC(6.0.3790.3959); 	 Mon, 6 Aug 2007 19:47:16 +0100
From: "Dave Korn" <dave.korn@artimi.com>
To: "'Mark Mitchell'" <mark@codesourcery.com>, 	=?UTF-8?B?JyJTZW9uZ2JhZSBQYXJrICjrsJXshLHrsLAsIOactOaIkOWfuSkiJw==?= <seongbae.park@gmail.com>
Cc: "'gcc-patches'" <gcc-patches@gcc.gnu.org>, 	"'Nathan Sidwell'" <nathan@codesourcery.com>
References: <ab3a61990708061036gbcb1a62pcdb81954e5d5c5de@mail.gmail.com> <46B7644E.9080808@codesourcery.com>
Subject: RE: [PATCH] Wrong line number for the closing brace of template functions
Date: Mon, 06 Aug 2007 18:47:00 -0000
Message-ID: <009701c7d85a$35cd4610$2e08a8c0@CAM.ARTIMI.COM>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Office Outlook 11
In-Reply-To: <46B7644E.9080808@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-08/txt/msg00380.txt.bz2

On 06 August 2007 19:11, Mark Mitchell wrote:

> However, this comment:
>=20
> +      /* Make sure the current input_location
> +         is set correctly to the end of the function
> +	 - this makes finish_function to set
> +	 function_end_locus of this specialization correctly. */
>=20
> could be written better as:
>=20
> /* Set the current input_location to the end of the function so
>    that finish_function knows where we are.  */
>=20
> The "makes x to set y" construct is not grammatical.

  FYI, anyone whose first language isn't English:

  The very similar construction "causes x to set y" is grammatical, and alt=
hough "makes" and "causes" mean the same in this context, only "causes" may=
 be used in that construct.  "makes x set y" would also be grammatical.  (I=
 don't know why "causes" requires an infinitive (actually, probably a gerun=
d) and "makes" requires a finite verb phrase, but there you go).


    cheers,
      DaveK
--=20
Can't think of a witty .sigline today....