* [PATCH,rs6000] Correct dejagnu directives in several newly added tests
@ 2017-09-29 16:49 Kelvin Nilsen
2017-09-29 22:50 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Kelvin Nilsen @ 2017-09-29 16:49 UTC (permalink / raw)
To: gcc-patches; +Cc: Segher Boessenkool
This patch corrects an error in several newly added test programs that
was causing these programs to be SUPPORTED on platforms where they were
not supposed to be SUPPORTED, which was causing unexpected FAILS.
The patch has been preapproved by segher@gcc.gnu.org.
gcc/testsuite/ChangeLog:
2017-09-29 Kelvin Nilsen <kelvin@gcc.gnu.org>
* gcc.target/powerpc/swaps-p8-30.c: Exchange the order of dg-do
and dg-require-effective-target directives to correct testing
behavior.
* gcc.target/powerpc/swaps-p8-32.c: Likewise.
* gcc.target/powerpc/swaps-p8-41.c: Likewise.
* gcc.target/powerpc/swaps-p8-34.c: Likewise.
* gcc.target/powerpc/swaps-p8-43.c: Likewise.
* gcc.target/powerpc/swaps-p8-36.c: Likewise.
* gcc.target/powerpc/swaps-p8-45.c: Likewise.
* gcc.target/powerpc/swaps-p8-29.c: Likewise.
* gcc.target/powerpc/swaps-p8-38.c: Likewise.
* gcc.target/powerpc/swaps-p8-31.c: Likewise.
* gcc.target/powerpc/swaps-p8-40.c: Likewise.
* gcc.target/powerpc/swaps-p8-33.c: Likewise.
* gcc.target/powerpc/swaps-p8-42.c: Likewise.
* gcc.target/powerpc/swaps-p8-35.c: Likewise.
* gcc.target/powerpc/swaps-p8-44.c: Likewise.
* gcc.target/powerpc/swaps-p8-28.c: Likewise.
* gcc.target/powerpc/swaps-p8-37.c: Likewise.
* gcc.target/powerpc/swaps-p8-39.c: Likewise.
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-30.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-30.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-30.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-32.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-32.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-32.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-41.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-41.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-41.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-34.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-34.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-34.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-43.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-43.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-43.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-36.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-36.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-36.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-45.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-45.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-45.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-29.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-29.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-29.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-38.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-38.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-38.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-31.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-31.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-31.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-40.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-40.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-40.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-33.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-33.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-33.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-42.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-42.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-42.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-35.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-35.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-35.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-44.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-44.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-44.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-28.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-28.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-28.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-37.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-37.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-37.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-require-effective-target p8vector_hw } */
-/* { dg-do run { target { powerpc*-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
Index: gcc/testsuite/gcc.target/powerpc/swaps-p8-39.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/swaps-p8-39.c (revision 253294)
+++ gcc/testsuite/gcc.target/powerpc/swaps-p8-39.c (working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
-/* { dg-do compile { target { powerpc64le-*-* } } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
/* { dg-options "-mcpu=power8 -O3 " } */
/* { dg-final { scan-assembler-not "xxpermdi" } } */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH,rs6000] Correct dejagnu directives in several newly added tests
2017-09-29 16:49 [PATCH,rs6000] Correct dejagnu directives in several newly added tests Kelvin Nilsen
@ 2017-09-29 22:50 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-09-29 22:50 UTC (permalink / raw)
To: Kelvin Nilsen; +Cc: gcc-patches
Hi Kelvin,
> * gcc.target/powerpc/swaps-p8-30.c: Exchange the order of dg-do
> and dg-require-effective-target directives to correct testing
> behavior.
> * gcc.target/powerpc/swaps-p8-32.c: Likewise.
> * gcc.target/powerpc/swaps-p8-41.c: Likewise.
> * gcc.target/powerpc/swaps-p8-34.c: Likewise.
> * gcc.target/powerpc/swaps-p8-43.c: Likewise.
> * gcc.target/powerpc/swaps-p8-36.c: Likewise.
> * gcc.target/powerpc/swaps-p8-45.c: Likewise.
> * gcc.target/powerpc/swaps-p8-29.c: Likewise.
> * gcc.target/powerpc/swaps-p8-38.c: Likewise.
> * gcc.target/powerpc/swaps-p8-31.c: Likewise.
> * gcc.target/powerpc/swaps-p8-40.c: Likewise.
> * gcc.target/powerpc/swaps-p8-33.c: Likewise.
> * gcc.target/powerpc/swaps-p8-42.c: Likewise.
> * gcc.target/powerpc/swaps-p8-35.c: Likewise.
> * gcc.target/powerpc/swaps-p8-44.c: Likewise.
> * gcc.target/powerpc/swaps-p8-28.c: Likewise.
> * gcc.target/powerpc/swaps-p8-37.c: Likewise.
> * gcc.target/powerpc/swaps-p8-39.c: Likewise.
In cases like this, please sort the entries :-)
(I've fixed it, nothing more to do).
Thanks for the patch,
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-29 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 16:49 [PATCH,rs6000] Correct dejagnu directives in several newly added tests Kelvin Nilsen
2017-09-29 22:50 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).