From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1520C3858D26 for ; Thu, 23 May 2024 06:05:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1520C3858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1520C3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716444343; cv=none; b=Wzk180o3smlrsuN1ynNkQdj8IFwKaduLPmSpTGrSVOP1cYqA/lw8Ylxg/fjgFZ5g4gHfg/l32cxZefX6vXZTdtQ5LV5aMyogbiO0GOUzFv887grf+vY5WXjPIMhC8zpsFrCAxbdHA2mQlrGsX5TLU/Zw8LZBdFb+RAitXzs8XTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716444343; c=relaxed/simple; bh=15FoXLD5bC4yp/LhnjnKGzDrxjKltSRx763sDFQLgSI=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=YWe/BB1g/YJLBAi7tx1mM/4SPDpQtzmLaBBSbEQQWLxGCIm9SWNooYMvyxvR5dKCbiW7SU6Fem5AfVYLNihMQ5ZRAjpcJYk+1zsXC0hSzWyXlCU7ZyCaJ3l6+9NMH2eMRCXQt6WmTl096iWN0ItT3JRMriipDAJwg340AKwiimk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA1a5-00015M-Ef for gcc-patches@gcc.gnu.org; Thu, 23 May 2024 02:05:40 -0400 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Cx76+l3E5mNu0CAA--.2785S3; Thu, 23 May 2024 14:05:26 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxJMWk3E5mv2QGAA--.7295S3; Thu, 23 May 2024 14:05:25 +0800 (CST) Subject: Re: [PATCH] LoongArch: Guard REGNO with REG_P in loongarch_expand_conditional_move [PR115169] To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20240522112455.39096-1-xry111@xry111.site> From: Lulu Cheng Message-ID: <00a658ca-5621-4a10-f655-2d80f86c9e7c@loongson.cn> Date: Thu, 23 May 2024 14:05:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20240522112455.39096-1-xry111@xry111.site> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxJMWk3E5mv2QGAA--.7295S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7WF1xAF4xuw43JF1UurWrXrc_yoW8Zw47pr yxu39xKr48J39a93WkGay8X34DGrnrta12ga4ayFyIkws8Xr1UZr45KF9IvFy0vwsYqr48 Xrn5Zws8XFyjkabCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU7XTm DUUUU Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9,MIME_CHARSET_FARAWAY=2.45,NICE_REPLY_A=-1.89,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM! Thanks! ÔÚ 2024/5/22 ÏÂÎç7:24, Xi Ruoyao дµÀ: > gcc/ChangeLog: > > PR target/115169 > * config/loongarch/loongarch.cc > (loongarch_expand_conditional_move): Guard REGNO with REG_P. > --- > > Bootstrapped with --enable-checking=all. Ok for trunk and 14? > > gcc/config/loongarch/loongarch.cc | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc > index e7835ae34ae..1b6df6a4365 100644 > --- a/gcc/config/loongarch/loongarch.cc > +++ b/gcc/config/loongarch/loongarch.cc > @@ -5344,6 +5344,7 @@ loongarch_expand_conditional_move (rtx *operands) > rtx op1_extend = op1; > > /* Record whether operands[2] and operands[3] modes are promoted to word_mode. */ > + bool promote_op[2] = {false, false}; > bool promote_p = false; > machine_mode mode = GET_MODE (operands[0]); > > @@ -5351,9 +5352,15 @@ loongarch_expand_conditional_move (rtx *operands) > loongarch_emit_float_compare (&code, &op0, &op1); > else > { > - if ((REGNO (op0) == REGNO (operands[2]) > - || (REGNO (op1) == REGNO (operands[3]) && (op1 != const0_rtx))) > - && (GET_MODE_SIZE (GET_MODE (op0)) < word_mode)) > + if (GET_MODE_SIZE (GET_MODE (op0)) < word_mode) > + { > + promote_op[0] = (REG_P (op0) && REG_P (operands[2]) && > + REGNO (op0) == REGNO (operands[2])); > + promote_op[1] = (REG_P (op1) && REG_P (operands[3]) && > + REGNO (op1) == REGNO (operands[3])); > + } > + > + if (promote_op[0] || promote_op[1]) > { > mode = word_mode; > promote_p = true; > @@ -5395,7 +5402,7 @@ loongarch_expand_conditional_move (rtx *operands) > > if (promote_p) > { > - if (REGNO (XEXP (operands[1], 0)) == REGNO (operands[2])) > + if (promote_op[0]) > op2 = op0_extend; > else > { > @@ -5403,7 +5410,7 @@ loongarch_expand_conditional_move (rtx *operands) > op2 = force_reg (mode, op2); > } > > - if (REGNO (XEXP (operands[1], 1)) == REGNO (operands[3])) > + if (promote_op[1]) > op3 = op1_extend; > else > {