From: "Kyrylo Tkachov" <kyrylo.tkachov@arm.com>
To: <gcc-patches@gcc.gnu.org>
Cc: "Richard Earnshaw" <Richard.Earnshaw@arm.com>,
"Ramana Radhakrishnan" <Ramana.Radhakrishnan@arm.com>
Subject: [PATCH][ARM] Define predicable attribute for arm_abssi2 and arm_neg_abssi2
Date: Mon, 19 Nov 2012 17:51:00 -0000 [thread overview]
Message-ID: <00ab01cdc67e$72294a60$567bdf20$@tkachov@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi all,
This patch updates the arm_abssi2 and arm_neg_abssi2 patterns in the ARM
machine description.
We define the predicable attribute based on the alternative. When the
patterns were introduced it was not possible to do that.
Now the second alternative in each of the patterns that supports predication
is defined as predicable.
No regressions on arm-none-eabi with qemu.
Ok for trunk?
Thanks,
Kyrill
gcc/ChangeLog
2012-11-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* config/arm/arm.md (*arm_abssi2): Define predicable attribute.
(*arm_neg_abssi2): Define predicable attribute.
[-- Attachment #2: abssi_predicable.txt --]
[-- Type: text/plain, Size: 698 bytes --]
--- a/gcc/config/arm/arm.md
+++ b/gcc/config/arm/arm.md
@@ -4263,7 +4263,7 @@ (define_insn "*arm_abssi2"
eor%?\\t%0, %1, %1, asr #31\;sub%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "8")]
)
@@ -4291,7 +4291,7 @@ (define_insn "*arm_neg_abssi2"
eor%?\\t%0, %1, %1, asr #31\;rsb%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "8")]
)
next reply other threads:[~2012-11-19 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 17:51 Kyrylo Tkachov [this message]
2012-11-19 18:05 ` Ramana Radhakrishnan
2012-11-20 10:25 ` Kyrylo Tkachov
2012-11-20 10:32 ` Richard Earnshaw
2012-11-22 11:35 ` Kyrylo Tkachov
2012-11-20 9:17 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ab01cdc67e$72294a60$567bdf20$@tkachov@arm.com' \
--to=kyrylo.tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).