public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Thomas Schwinge <thomas@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [committed][nvptx] Fix ASM_SPEC workaround for sm_30
Date: Mon, 11 Apr 2022 11:10:37 +0200	[thread overview]
Message-ID: <00ae61ab-427e-a09d-77be-414d1beca101@suse.de> (raw)
In-Reply-To: <87pmlt3rmd.fsf@dem-tschwing-1.ger.mentorg.com>

On 4/7/22 16:17, Thomas Schwinge wrote:
> Hi!
> 
> On 2022-03-31T09:40:47+0200, Tom de Vries via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>> Newer versions of CUDA no longer support sm_30, and nvptx-tools as
>> currently doesn't handle that gracefully when verifying
>> ( https://github.com/MentorEmbedded/nvptx-tools/issues/30 ).
> 
> There's now <https://github.com/MentorEmbedded/nvptx-tools/pull/33>
> 'as: Deal with CUDA 11.0, "Support for Kepler 'sm_30' and 'sm_32'
> architecture based products is dropped"' available for comment/testing.
> 
>> There's a --no-verify work-around in place in ASM_SPEC, but that one doesn't
>> work when using -Wa,--verify on the command line.
> 
> With that resolved in nvptx-tools, we may then revert these GCC-level
> workarounds, GCC commit bf4832d6fa817f66009f100a9cd68953062add7d
> "[nvptx] Fix ASM_SPEC workaround for sm_30", and
> GCC commit 12fa7641ceed9c9139e2ea7b62c11f3dc5b6f6f4
> "[nvptx] Use --no-verify for sm_30".  OK to push, once nvptx-tools ready?
> 
>> Use a more robust workaround: verify using sm_35 when misa=sm_30 is specified
>> (either implicitly or explicitly).
> 
> Thanks for that suggestion!
> 

Hi,

I've tested the nvptx-tools patch in combination with a patch that 
remote ASM_SPEC, and that went fine.

[ Well apart from a new	libgomp FAIL:
...
FAIL: libgomp.oacc-fortran/private-variables.f90 
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -foffload=nvptx-none  -O1 
  at line 142 (test for bogus messages, line 131)
...
but I assume that's unrelated ]

So, patch that removes ASM_SPEC pre-approved.

Thanks,
- Tom

      reply	other threads:[~2022-04-11  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  9:45 [committed][nvptx] Use --no-verify " Tom de Vries
2022-03-31  7:40 ` [committed][nvptx] Fix ASM_SPEC workaround " Tom de Vries
2022-04-07 14:17   ` Thomas Schwinge
2022-04-11  9:10     ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00ae61ab-427e-a09d-77be-414d1beca101@suse.de \
    --to=tdevries@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).