From: "Kyrylo Tkachov" <kyrylo.tkachov@arm.com>
To: <gcc-patches@gcc.gnu.org>
Cc: "Ramana Radhakrishnan" <Ramana.Radhakrishnan@arm.com>,
"Richard Earnshaw" <Richard.Earnshaw@arm.com>
Subject: RE: [PATCH][ARM] Define predicable attribute for arm_abssi2 and arm_neg_abssi2
Date: Tue, 20 Nov 2012 10:25:00 -0000 [thread overview]
Message-ID: <00af01cdc709$53e608f0$fbb21ad0$@tkachov@arm.com> (raw)
In-Reply-To: <50AA74CB.2020908@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
Hi all,
This is the updated version of the patch. It defines the predicable
attribute for the equivalent abssi2 and neg_abssi2 patterns in thumb2.md.
The previous version (with the changes only to arm.md) has been okayed but
not applied and this patch supersedes it.
The previous version is:
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01578.html
No regressions for arm-none-eabi for qemu.
Ok for trunk?
Thanks,
Kyrill
gcc/ChangeLog
2012-11-20 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* config/arm/arm.md (*arm_abssi2): Define predicable attribute.
(*arm_neg_abssi2): Likewise.
* config/arm/thumb2.md (*thumb2_abssi2): Likewise.
(*thumb2_neg_abssi2): Likewise.
-----Original Message-----
From: Ramana Radhakrishnan
Sent: 19 November 2012 18:05
To: Kyrylo Tkachov
Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw
Subject: Re: [PATCH][ARM] Define predicable attribute for arm_abssi2 and
arm_neg_abssi2
On 11/19/12 17:51, Kyrylo Tkachov wrote:
> Hi all,
> This patch updates the arm_abssi2 and arm_neg_abssi2 patterns in the ARM
> machine description.
> We define the predicable attribute based on the alternative. When the
> patterns were introduced it was not possible to do that.
> Now the second alternative in each of the patterns that supports
predication
> is defined as predicable.
>
> No regressions on arm-none-eabi with qemu.
>
> Ok for trunk?
Ok, please apply.
Ramana
[-- Attachment #2: abssi_predicable.txt --]
[-- Type: text/plain, Size: 1573 bytes --]
--- a/gcc/config/arm/arm.md
+++ b/gcc/config/arm/arm.md
@@ -4263,7 +4263,7 @@ (define_insn "*arm_abssi2"
eor%?\\t%0, %1, %1, asr #31\;sub%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "8")]
)
@@ -4291,7 +4291,7 @@ (define_insn "*arm_neg_abssi2"
eor%?\\t%0, %1, %1, asr #31\;rsb%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "8")]
)
diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md
index a5302f479f5091d08f4bf1a9ee9b0423692372af..0000000000000000000000000000000000000000 100644
--- a/gcc/config/arm/thumb2.md
+++ b/gcc/config/arm/thumb2.md
@@ -141,7 +141,7 @@ (define_insn "*thumb2_abssi2"
eor%?\\t%0, %1, %1, asr #31\;sub%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "10,8")]
)
@@ -155,7 +155,7 @@ (define_insn "*thumb2_neg_abssi2"
eor%?\\t%0, %1, %1, asr #31\;rsb%?\\t%0, %0, %1, asr #31"
[(set_attr "conds" "clob,*")
(set_attr "shift" "1")
- ;; predicable can't be set based on the variant, so left as no
+ (set_attr "predicable" "no, yes")
(set_attr "length" "10,8")]
)
next prev parent reply other threads:[~2012-11-20 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 17:51 Kyrylo Tkachov
2012-11-19 18:05 ` Ramana Radhakrishnan
2012-11-20 10:25 ` Kyrylo Tkachov [this message]
2012-11-20 10:32 ` Richard Earnshaw
2012-11-22 11:35 ` Kyrylo Tkachov
2012-11-20 9:17 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00af01cdc709$53e608f0$fbb21ad0$@tkachov@arm.com' \
--to=kyrylo.tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).